From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCEF015667D for ; Sat, 25 Oct 2025 00:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761352884; cv=none; b=tKuGeIelzv8hJKAHaqnZV+Apf2jOmpXCu/A19774uymAS2vQRkkTr8QYBBt9NpCTtwMvSQj8HW+bkUAjZXKBxKvB4bNMrZYrcDd639nYUbkIcZrOwKe5S0WTgjRjB4XMZkEWQwYcqZw4XOqVrGIFFnt9WGvz1Z1JI3x9fkI1LWI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761352884; c=relaxed/simple; bh=QbZ9GJPkmkuF9RKGFB5uu4i2+W2OdqDczAhVKCOTVRU=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=J3H6ejoTh2D97cWfPzBQHmoU4BFL9wNd+Ms6E2/WN25Tw72Jg2Yg2l5D51+dvounll6Mi9w8xTFcQAYp3fcqwW1MyyrV4WpHyX9TlQxVUTt6g+IVvRPBGoRv//rRpm9PVN9oqfLUZjM4kJueTsu8KeYHhmNRnotmM0jXNYZ0mfk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HyYHbihJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HyYHbihJ" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59OI9EST018800 for ; Sat, 25 Oct 2025 00:41:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ya8Q6uFCCxVarjTky3xl1Z6ewP/ZO6Fn6dKVnrcxZ5g=; b=HyYHbihJDASOeksK Y7kb56aLOxi4/wvzvHC4WTbI7w6kCerS3XOGnfZQUp7BPRcN17tUB+3EW3BR9Oc2 RapLfuDSCbxdAnq6lUA3u6A8W9uFDVIng0a1wjirgMSXA1nwKhTay5mrylsAIMLr hH7XaaGiXKUCL5V6IHnWfsHu3ZX9LHF/yc2gydEsd6vCncp5xmTUrN0UGflWeHq6 0WUClzfDizYsrGF/yDdE90POESFOwk4Z0BWz88Agg8Bm82HeAA20fKEjBRecZ+QK 9H4LkRmCt/Gpnuxm1QnJfL4vgkNAIAWhmT8wdlRj1H7LB7zQsiGAJe51ibhGZC5D 2GXmpg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49yp6k4tv0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 25 Oct 2025 00:41:21 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2909daa65f2so44757745ad.0 for ; Fri, 24 Oct 2025 17:41:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761352881; x=1761957681; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ya8Q6uFCCxVarjTky3xl1Z6ewP/ZO6Fn6dKVnrcxZ5g=; b=M7W1bPQViwwjkQ2gDquL1wyhV5gTEX5uVxKHUpG3Z26dj35+RUsG41r+B+29FNonId aBgS14BL4aT6/zk/I8ErzVvn/ivOo/ti/8Sc/5APvbQYZYexiwRpAbNt6YH3Aq/zZ2sS fYwFK8zuvCorU/5vaH/7rzRKb74uY8lvE2hJ2mJr16Bf8+Zvk3Fmn1oP1rU7DSx59rX0 u9rHWHeixm05nTYl7SjFuTJ4NwdgtqsYsXtFu/68291tzR6pizbc3Dea40+LW44PswXa RJClcFUSNTb46AAc/ZvwK9jEE/4+jMDHlfk0TKXM54Ukb8QLzS1I/uOtUHQiBv5Da179 vQUw== X-Forwarded-Encrypted: i=1; AJvYcCXtfkFkW7t1SoydkGqU6WAGOYLnTg2Zn/E9zHGQDFPF21ugI6waooZWmB8FlUkvrrUTx39xP+qkKW5gmTiL@vger.kernel.org X-Gm-Message-State: AOJu0YwO08mra+Z1bDRIHfx6wr9mC0IWA7CQvHOfCXmGRV+QMd96dFbv tmGbl8gFZP/anDrh1bh9jwfi8yknbd1St6GZ2TGrDgtXGhgEdI4Mg4P994pcCoYTiAM4SGjbAdT NmrOXgVhTB+nEZcJM6tPwVIKhKqhlJ70XgorcVLb7OvMl6CUhMh1tV6MzKd+7Igh/gQRC X-Gm-Gg: ASbGncvnlTX8GlNVyCmEEYgWA7RRIiXsGrTCkQa1+3n4062ywwNFcYMROQwtTJDuPg3 vuWo3ov4+duau5HbZqQX3tP1N1ALynUMaQx0XKU0THge5KYZIQ2cqSAdVN66oWYJe59mLImbPU6 Y1ulaS5rzVI6b3WC1Rclxrc0kcaV8bFTtkQUxULC4zZQWQ9we+h0E+6vk59XoUBoUEkoSTCJcb7 2MBZvtF37/YJH172Z0RTfH+xc0wfPWmSivGr2V0fhxPL6hnkVmmLEAUyNyoP4TH8CNfvAehIaiW yXuIp7EGIz6WEADEWPtStlzcDz7r4hqmtaTDZ+EEPx8zQMfIzeCdwKab11+O+eLv/WkUt1Kt93Z jSf20bi/TziwIFMDdEwGWVWpHM6q1vE49EzjyFxfn X-Received: by 2002:a17:902:e847:b0:25b:e5a2:fb29 with SMTP id d9443c01a7336-29489df3872mr54903935ad.12.1761352880869; Fri, 24 Oct 2025 17:41:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnu5Z8NPBgBgFB2GFR1aP8qmtpDHK45P3Rv0Oz7knL23wjldQEPCmVxD+1gC0RKhDO+yVGeQ== X-Received: by 2002:a17:902:e847:b0:25b:e5a2:fb29 with SMTP id d9443c01a7336-29489df3872mr54903645ad.12.1761352880384; Fri, 24 Oct 2025 17:41:20 -0700 (PDT) Received: from [10.73.53.19] (pat_11.qualcomm.com. [192.35.156.11]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29498d40a7esm5035005ad.70.2025.10.24.17.41.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Oct 2025 17:41:19 -0700 (PDT) Message-ID: <39732bf6-dd6f-b808-7c10-b3faa4d46489@oss.qualcomm.com> Date: Fri, 24 Oct 2025 17:41:18 -0700 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v5 07/10] phy: qualcomm: qmp-combo: Update QMP PHY with Glymur settings Content-Language: en-US From: Wesley Cheng To: Abel Vesa Cc: krzk+dt@kernel.org, conor+dt@kernel.org, konrad.dybcio@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, kishon@kernel.org, vkoul@kernel.org, gregkh@linuxfoundation.org, robh@kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251006222002.2182777-1-wesley.cheng@oss.qualcomm.com> <20251006222002.2182777-8-wesley.cheng@oss.qualcomm.com> <9d3dd1cf-4969-3dcb-18dc-59cfb68033f7@oss.qualcomm.com> In-Reply-To: <9d3dd1cf-4969-3dcb-18dc-59cfb68033f7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDIzMDEzMSBTYWx0ZWRfX1qJHmvg5ObVE Vy1K/rYbc125ihKrsx6G/3FGg4vl5q4sRrcA0seuzHrpmFq/LS2rNuydug84pbadkyOXIMDA6h8 R2P+BBff8oKECGYJJugWjECQK4+fHWs+RSYeoP1WSIunMZHUW4kTnXgSS+LMHOgqt5VEntRro0Q 11Jyn4LhzCtICG4bUekqD/ZP2igSzQDc2M8a8EYEuAs8y4lcpDsVxm5JEGHyvPt6/w03XQvVOuN eJ3PVeVhfQcZ66yjpnINzyIIb72hJNCnvAgnxZibxdRtH3XSJHuV47tz9OJN5rX2S/Rq8tz9hLl BpOeK3KHRLNMpTfb2rLjNDGG1uPX9SsiP4Odf0RAW2djwoYueQhFMoBytSKwgzcDMCYGnWTe727 Ulb1JqGnZbxXT57CjjKKAk7J8uApbw== X-Proofpoint-GUID: jsEw2pbJwJR4kA-nJwKgBCh4KddOUFb2 X-Authority-Analysis: v=2.4 cv=bL8b4f+Z c=1 sm=1 tr=0 ts=68fc1cb1 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZdW6uxA9NKXbfdqeeS2OGA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=RNL1vAbd1nz3C39zmhQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: jsEw2pbJwJR4kA-nJwKgBCh4KddOUFb2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-24_05,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 spamscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510230131 On 10/24/2025 5:02 PM, Wesley Cheng wrote: > > > On 10/24/2025 3:04 AM, Abel Vesa wrote: >> On 25-10-06 15:19:59, Wesley Cheng wrote: >>> For SuperSpeed USB to work properly, there is a set of HW settings that >>> need to be programmed into the USB blocks within the QMP PHY.  Ensure >>> that >>> these settings follow the latest settings mentioned in the HW >>> programming >>> guide.  The QMP USB PHY on Glymur is a USB43 based PHY that will have >>> some >>> new ways to define certain registers, such as the replacement of TXA/RXA >>> and TXB/RXB register sets.  This was replaced with the LALB register >>> set. >>> >>> There are also some PHY init updates to modify the PCS MISC register >>> space. >>> Without these, the QMP PHY PLL locking fails. >>> >>> Reviewed-by: Dmitry Baryshkov >>> Signed-off-by: Wesley Cheng >>> --- >>>   drivers/phy/qualcomm/phy-qcom-qmp-combo.c     | 314 ++++++++- >>>   .../phy/qualcomm/phy-qcom-qmp-pcs-aon-v8.h    |  17 + >>>   .../phy/qualcomm/phy-qcom-qmp-pcs-misc-v8.h   |  12 + >>>   .../qualcomm/phy-qcom-qmp-qserdes-lalb-v8.h   | 639 ++++++++++++++++++ >>>   .../phy/qualcomm/phy-qcom-qmp-usb43-pcs-v8.h  |  33 + >>>   .../phy-qcom-qmp-usb43-qserdes-com-v8.h       | 224 ++++++ >>>   drivers/phy/qualcomm/phy-qcom-qmp.h           |   2 + >>>   7 files changed, 1240 insertions(+), 1 deletion(-) >>>   create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-aon-v8.h >>>   create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-misc-v8.h >>>   create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-qserdes-lalb-v8.h >>>   create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-usb43-pcs-v8.h >>>   create mode 100644 >>> drivers/phy/qualcomm/phy-qcom-qmp-usb43-qserdes-com-v8.h >>> >>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >>> b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >>> index 1caa1fb6a8c7..8216820e388f 100644 >>> --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >> >> [...] >> >>> +static const struct qmp_phy_cfg glymur_usb3dpphy_cfg = { >>> +    .offsets        = &qmp_combo_usb43dp_offsets_v8, >>> + >>> +    .serdes_tbl        = glymur_usb43dp_serdes_tbl, >>> +    .serdes_tbl_num        = ARRAY_SIZE(glymur_usb43dp_serdes_tbl), >>> +    .tx_tbl            = glymur_usb43dp_lalb_tbl, >>> +    .tx_tbl_num        = ARRAY_SIZE(glymur_usb43dp_lalb_tbl), >>> +    .pcs_tbl        = glymur_usb43dp_pcs_tbl, >>> +    .pcs_tbl_num        = ARRAY_SIZE(glymur_usb43dp_pcs_tbl), >>> +    .pcs_usb_tbl        = glymur_usb43dp_pcs_usb_tbl, >>> +    .pcs_usb_tbl_num    = ARRAY_SIZE(glymur_usb43dp_pcs_usb_tbl), >>> +    .pcs_misc_tbl        = glymur_usb43dp_pcs_misc_tbl, >>> +    .pcs_misc_tbl_num    = ARRAY_SIZE(glymur_usb43dp_pcs_misc_tbl), >>> + >>> +    .dp_serdes_tbl        = qmp_v6_n4_dp_serdes_tbl, >>> +    .dp_serdes_tbl_num    = ARRAY_SIZE(qmp_v6_n4_dp_serdes_tbl), >>> +    .dp_tx_tbl        = qmp_v6_n4_dp_tx_tbl, >>> +    .dp_tx_tbl_num        = ARRAY_SIZE(qmp_v6_n4_dp_tx_tbl), >>> + >>> +    .serdes_tbl_rbr        = qmp_v6_n4_dp_serdes_tbl_rbr, >>> +    .serdes_tbl_rbr_num    = ARRAY_SIZE(qmp_v6_n4_dp_serdes_tbl_rbr), >>> +    .serdes_tbl_hbr        = qmp_v6_n4_dp_serdes_tbl_hbr, >>> +    .serdes_tbl_hbr_num    = ARRAY_SIZE(qmp_v6_n4_dp_serdes_tbl_hbr), >>> +    .serdes_tbl_hbr2    = qmp_v6_n4_dp_serdes_tbl_hbr2, >>> +    .serdes_tbl_hbr2_num    = ARRAY_SIZE(qmp_v6_n4_dp_serdes_tbl_hbr2), >>> +    .serdes_tbl_hbr3    = qmp_v6_n4_dp_serdes_tbl_hbr3, >>> +    .serdes_tbl_hbr3_num    = ARRAY_SIZE(qmp_v6_n4_dp_serdes_tbl_hbr3), >>> + >>> +    .swing_hbr_rbr        = &qmp_dp_v6_voltage_swing_hbr_rbr, >>> +    .pre_emphasis_hbr_rbr    = &qmp_dp_v6_pre_emphasis_hbr_rbr, >>> +    .swing_hbr3_hbr2    = &qmp_dp_v5_voltage_swing_hbr3_hbr2, >>> +    .pre_emphasis_hbr3_hbr2    = &qmp_dp_v5_pre_emphasis_hbr3_hbr2, >>> + >>> +    .dp_aux_init        = qmp_v4_dp_aux_init, >>> +    .configure_dp_tx    = qmp_v4_configure_dp_tx, >>> +    .configure_dp_phy    = qmp_v4_configure_dp_phy, >>> +    .calibrate_dp_phy    = qmp_v4_calibrate_dp_phy, >> >> So I see you are adding the DP related config here as well, but it is >> definitely not compatible with v6 N4. I'm assyuming you picked v6 N4 >> as a default >> just to allow the USB part work for now, right ? >> >> I don't suppose we can drop the DP related config from this patch and >> still have the USB part working, right? >> >> Otherwise, we need to mention the fact that even though the DP part >> is also being added, it is broken. > > Hi Abel, > > That is correct.  Without these defined, the USB path won't work, and > we'll need to supplement this if we wanted to add DP support.  Hence, > why I didn't add any mention of DP altmode in the commit text.  I can > clarify that we added DP placeholders if that makes it more clear in the > commit text. > Hi Abel, I take that back...I went back and reviewed the QMP combo driver again, and gave it a try w/o any of the DP init tables. SS USB is working fine. I will update the patch to remove the DP entries. Thanks for catching this. Thanks Wesley Cheng