From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEE0113E3F6 for ; Tue, 28 May 2024 12:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716900995; cv=none; b=qwYrEjItmR5GE/8iLR+GkvQsp2R3YK6yGJryerqZXxU/qQGEnXO/21V+vOuXRJLJcLZzqlLJmb8xCa08YR1x118orqAKKJnRPF39Vm6lKeUWYPbORgJiShNfKw31xMmIhDyECdoOyBreGH910l5v8otIzb51f3MYKIz2s/A1/qo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716900995; c=relaxed/simple; bh=c6bKxcXWNYjOOH0xRtK0KGI6gOon/19zEjgMhAayAqw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UF5ozCOXnKujTtaAyA8QVUkUE9kQUeBVxVqpAS9R3NXaFU64GooYv85zN79Q4cA+8/UmrCnpJoPOelBgvx2SavraB1rq0LF1XT+b1WZAEJl90d6ON+//Ouy7dQEePf9OkLgP2QbmYyfhdaEhN7U4j9f0sxVYNqwvyruJhYRDZTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rfpQDhSw; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rfpQDhSw" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-52389c1308dso1014505e87.3 for ; Tue, 28 May 2024 05:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716900992; x=1717505792; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UBJydv2oVIxF33glNXhfsH0j7NMZZydOoyfGkqd3Bng=; b=rfpQDhSwEJGotNqLcxKrMS0y+28gjfTNNNHNkRA+UutyICUhBLYdckTobq8zgztGBf qtqKcyHM+v2Jh4umHeIotadX3d9/ZONqddlBisRiwRSaSpOb/7xVnKeaGAE8RaKYVVL7 3HamyEo5WoOrbHTW8+4VtBob8j5GHwODjasLpuVS54zQ0Hw5cxBSoC9twYJIlJsYZGjw x8e9NzWE6EZBOfvVxxrl8F7pfjy3ebvN7vvCBzmHA2VGW7hhrOnb7nDQHtaVJd5ilX8d B4xkzwhLvV6EUWyoRvC9T1CFHvEf/VltbpviDc5xtDnME2Cfhgyu6y7NvEfdVqEP8dGE 7Udg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716900992; x=1717505792; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UBJydv2oVIxF33glNXhfsH0j7NMZZydOoyfGkqd3Bng=; b=Xv3MfwzyxkD3G4mUd+1I/QBHathiKXWOWgtdXnj4LdS4cthrGfdf3Rr69Zrsn80PMZ plXb4bzem1gQB1ti5EEO8spDSEzjvacLFOBOb7xHaADd8Eu2iw90etgUcbEG6686KJh5 szHiMM1kiWHfZAzdUTH8/W2ZNKKgqCVjowhzYCNLMV9n3wOvWwCTCXOsgrDyySLRdwMO BOJFF/wCbwuIfIuNZD/rzdfSOmcVUN9Xom2cXmeR+jEBQJDZaB828BJ29E62oqwlo5iI c4BRjwIYB5cOHNoihXEZBmVjTZ/ab/VhLfxMeRfQNPoidYvqhwZE0uqVwwUsCQpJwM9b lCvw== X-Gm-Message-State: AOJu0Yyw5hq2j+xLn+vb3goSBstZzI7MmuowtNpFI9zoCxO4BaMNKX3k EBAOzAEBkkiZEe3k4gQ4RzTcL5zHUUUYPcJIW0aumKsmMxxmhUt4EyRMywrnmDI= X-Google-Smtp-Source: AGHT+IG0zOMeIXAZKtGkaGkYMDbA0TJClGnE+TMJJZXkxFvHDGGTT9Qi+laKp696WC+OBF1yN6ki/g== X-Received: by 2002:a05:6512:b9c:b0:51a:cafd:3872 with SMTP id 2adb3069b0e04-529644ec0cfmr9508409e87.3.1716900992046; Tue, 28 May 2024 05:56:32 -0700 (PDT) Received: from ?IPV6:2a00:f41:c97:23a9:35bc:df2e:d894:2c76? ([2a00:f41:c97:23a9:35bc:df2e:d894:2c76]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5297066b885sm996984e87.127.2024.05.28.05.56.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 May 2024 05:56:31 -0700 (PDT) Message-ID: <39e8aa68-a68f-48d8-9845-0d273004e21b@linaro.org> Date: Tue, 28 May 2024 14:56:27 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/10] arm64: dts: qcom: sc8180x-lenovo-flex-5g: Enable USB multiport controller To: Bjorn Andersson , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Wesley Cheng Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org, Bjorn Andersson References: <20240525-sc8180x-usb-mp-v1-0-60a904392438@quicinc.com> <20240525-sc8180x-usb-mp-v1-10-60a904392438@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240525-sc8180x-usb-mp-v1-10-60a904392438@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/25/24 20:04, Bjorn Andersson wrote: > From: Bjorn Andersson > > The Lenovo Flex 5G has a camera attached to the multiport USB > controller, enable the controller and the four phys to enable this. Any chance you could leave a comment above each pair of PHYs that would say e.g. /* Left rear port */ &usb_mp0_hsphy { ... ? [...] > +&usb_mp0_hsphy { > + status = "okay"; > + vdda-pll-supply = <&vreg_l5e_0p88>; > + vdda18-supply = <&vreg_l12a_1p8>; > + vdda33-supply = <&vreg_l16e_3p0>; status last > +}; > + > +&usb_mp0_qmpphy { > + vdda-phy-supply = <&vreg_l3c_1p2>; > + vdda-pll-supply = <&vreg_l5e_0p88>; > + > + status = "okay"; > +}; > + > +&usb_mp1_hsphy { > + status = "okay"; > + vdda-pll-supply = <&vreg_l5e_0p88>; > + vdda18-supply = <&vreg_l12a_1p8>; > + vdda33-supply = <&vreg_l16e_3p0>; ditto Konrad