linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Jessica Zhang <quic_jesszhan@quicinc.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>
Cc: quic_abhinavk@quicinc.com, ppaalanen@gmail.com,
	contact@emersion.fr, laurent.pinchart@ideasonboard.com,
	sebastian.wick@redhat.com, ville.syrjala@linux.intel.com,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	wayland-devel@lists.freedesktop.org
Subject: Re: [PATCH RFC v4 5/7] drm/msm/dpu: Add solid fill and pixel source properties
Date: Fri, 30 Jun 2023 03:49:27 +0300	[thread overview]
Message-ID: <39ee5eac-1452-1c08-c24f-6c70c13ce804@linaro.org> (raw)
In-Reply-To: <20230404-solid-fill-v4-5-f4ec0caa742d@quicinc.com>

On 30/06/2023 03:25, Jessica Zhang wrote:
> Add solid_fill and pixel_source properties to DPU plane
> 
> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 ++
>   1 file changed, 2 insertions(+)

This should be the last commit.
Otherwise:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> index c2aaaded07ed..5f0984ce62b1 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> @@ -1429,6 +1429,8 @@ struct drm_plane *dpu_plane_init(struct drm_device *dev,
>   		DPU_ERROR("failed to install zpos property, rc = %d\n", ret);
>   
>   	drm_plane_create_alpha_property(plane);
> +	drm_plane_create_solid_fill_property(plane);
> +	drm_plane_create_pixel_source_property(plane, BIT(DRM_PLANE_PIXEL_SOURCE_COLOR));
>   	drm_plane_create_blend_mode_property(plane,
>   			BIT(DRM_MODE_BLEND_PIXEL_NONE) |
>   			BIT(DRM_MODE_BLEND_PREMULTI) |
> 

-- 
With best wishes
Dmitry


  reply	other threads:[~2023-06-30  0:50 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-30  0:24 [PATCH RFC v4 0/7] Support for Solid Fill Planes Jessica Zhang
2023-06-30  0:25 ` [PATCH RFC v4 1/7] drm: Introduce solid fill DRM plane property Jessica Zhang
2023-06-30  8:27   ` Pekka Paalanen
2023-07-10 23:12     ` [Freedreno] " Jessica Zhang
2023-07-11  7:42       ` Pekka Paalanen
2023-07-11 21:47         ` Jessica Zhang
2023-06-30 10:33   ` Dmitry Baryshkov
2023-06-30 17:54     ` Jessica Zhang
2023-06-30  0:25 ` [PATCH RFC v4 2/7] drm: Introduce pixel_source " Jessica Zhang
2023-06-30  0:42   ` Dmitry Baryshkov
2023-06-30  8:27     ` Pekka Paalanen
2023-07-10 19:51       ` Jessica Zhang
2023-07-10 20:11         ` Dmitry Baryshkov
2023-07-11 22:07           ` Jessica Zhang
2023-07-11 22:19             ` Dmitry Baryshkov
2023-07-11 22:42               ` Abhinav Kumar
2023-07-11 23:00                 ` Dmitry Baryshkov
2023-07-12  7:35                 ` Pekka Paalanen
2023-06-30 14:43   ` Sebastian Wick
2023-06-30 21:27     ` Jessica Zhang
2023-07-03 11:49       ` Sebastian Wick
2023-06-30  0:25 ` [PATCH RFC v4 3/7] drm/atomic: Move framebuffer checks to helper Jessica Zhang
2023-06-30  0:43   ` Dmitry Baryshkov
2023-06-30 17:59     ` Jessica Zhang
2023-06-30  0:25 ` [PATCH RFC v4 4/7] drm/atomic: Loosen FB atomic checks Jessica Zhang
2023-06-30  0:48   ` Dmitry Baryshkov
2023-06-30 23:41     ` Jessica Zhang
2023-06-30  0:25 ` [PATCH RFC v4 5/7] drm/msm/dpu: Add solid fill and pixel source properties Jessica Zhang
2023-06-30  0:49   ` Dmitry Baryshkov [this message]
2023-06-30 23:41     ` Jessica Zhang
2023-06-30  0:25 ` [PATCH RFC v4 6/7] drm/msm/dpu: Allow NULL FBs in atomic commit Jessica Zhang
2023-06-30  0:52   ` Dmitry Baryshkov
2023-06-30  8:21     ` Pekka Paalanen
2023-07-01  1:14       ` Jessica Zhang
2023-06-30  0:25 ` [PATCH RFC v4 7/7] drm/msm/dpu: Use DRM solid_fill property Jessica Zhang
2023-06-30  0:59   ` Dmitry Baryshkov
2023-07-01  1:26     ` Jessica Zhang
2023-06-30  8:26   ` Pekka Paalanen
2023-07-03  7:42     ` Pekka Paalanen
2023-07-12  0:01       ` Jessica Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39ee5eac-1452-1c08-c24f-6c70c13ce804@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=airlied@gmail.com \
    --cc=contact@emersion.fr \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=ppaalanen@gmail.com \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_jesszhan@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=sebastian.wick@redhat.com \
    --cc=tzimmermann@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    --cc=wayland-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).