From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F21CC001DE for ; Fri, 28 Jul 2023 15:52:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233545AbjG1PwK (ORCPT ); Fri, 28 Jul 2023 11:52:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235081AbjG1PwH (ORCPT ); Fri, 28 Jul 2023 11:52:07 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 862D53C03 for ; Fri, 28 Jul 2023 08:51:59 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4fe1344b707so3975963e87.1 for ; Fri, 28 Jul 2023 08:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690559518; x=1691164318; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4XCAN+LIkW+VnqJkhSb2CWVPMCXFRGDrRJr1SX5q7MQ=; b=tubAVlpOtIztV2drODQdV0+BcMMwr8sRiRhpQX88br/pqwIp1e1FV2RGwVDViPVu3E kxvFKmYkDBrKBxjOLXhjFqRSPr0r16IXBkKiVUtkkpVv/5Wipkg1JGIqMTC7xN6JkCbv gAIF3t+CBcga1lJh9ByiEzTOZk+gj5PFm9sYsv0YcC35FpcWKMiUZtw6PqiYb8DWlwS6 3P0MvNGUW4ZloomcF17kVwtXafH+UaamMj+6qnZ3uZssyKBTo8vcEfivUxr04eYx80vK b121vAq+2IhdAbe/2sFrtCz/r1dqz0fLcJ3/5fYRKQ4x4rtwd6Iqrs5WkldKPR9BMt8w chPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690559518; x=1691164318; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4XCAN+LIkW+VnqJkhSb2CWVPMCXFRGDrRJr1SX5q7MQ=; b=CG1fNHXW8g/dvRgw58dqHXrCA9sJPvYNK+KG5EtYnqnD8YGB6Z+tvLWskMBskNpULi bIG0ofG/LFj4gg0Jaz4H8SHOmLH2B1agkpUBCDlzfqz67i6JaC0+/5gdbNtatmDfAquG OQdN7iW4DUnwNKpJ9dwwd1O3Vy/f+FgL6UQ3+4e//UqV9N9sFLjmfVtKr90jaGn1OVIm AoSFlv7EaepgFKqz/ABUAJx8SnNHcXO3F8yC31Jrozfe0dkXNIU33+oHByhZWrRapyCY uJDdLpdKlN8GRqD53ybykzsD13dLl6LSCM26VKtUmzDmXsb4X1+Ik/32XsjnOMkwhaBV 2mjQ== X-Gm-Message-State: ABy/qLZ8Cp1i7mUSLQ+L9nunhzoDsKSTcGhIwahp5cSP1SkPjCa6Z2ro TWEJYdZRwc/HKFUR/WHjBclRSA== X-Google-Smtp-Source: APBJJlFhZSZroexG6Q3XHDIZ66SYC2BREDtDz4hzbQa+ygCJ7CKdpgwFvwG0l1mgMccUIxjl5+Kndw== X-Received: by 2002:a05:6512:340d:b0:4fd:b223:92c with SMTP id i13-20020a056512340d00b004fdb223092cmr2712985lfr.60.1690559517648; Fri, 28 Jul 2023 08:51:57 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id a24-20020a19f818000000b004fe20d1b288sm340493lff.159.2023.07.28.08.51.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 08:51:57 -0700 (PDT) Message-ID: <3a1132ad-23e8-6415-dc8a-417eb64cdee8@linaro.org> Date: Fri, 28 Jul 2023 18:51:56 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 33/33] iris: enable building of iris video driver Content-Language: en-GB To: Bryan O'Donoghue , Vikash Garodia , stanimir.k.varbanov@gmail.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org, hans.verkuil@cisco.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: quic_dikshita@quicinc.com References: <1690550624-14642-1-git-send-email-quic_vgarodia@quicinc.com> <1690550624-14642-34-git-send-email-quic_vgarodia@quicinc.com> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 28/07/2023 18:25, Bryan O'Donoghue wrote: > On 28/07/2023 14:23, Vikash Garodia wrote: >> From: Dikshita Agarwal >> >> This adds iris driver Makefile and Kconfig, also changes >> v4l2 platform/qcom Makefile/Kconfig in order to >> enable compilation of the driver. > > This is not a meaningfully bisectable patch. > > It should go with the addition of the driver. Its good practice to break > up incremental changes to a driver in a series but, I don't see why you > really need to do that when adding a whole new driver. > > Just > > - Documentation > - Bindings > - Driver code > > On the other hand if you were switching on IRIS in the default defconfig > then that should be a separate patch. > > If we were say adding inter-frame power-collapse to the existing venus > as part of a series, then that makes sense as a standalone patch but IMO > when adding a whole new driver, add it as one. > > Its easier to read that way It wouldn't pass through mailing list filters. -- With best wishes Dmitry