From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A905AC001B0 for ; Tue, 4 Jul 2023 13:50:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230090AbjGDNu1 (ORCPT ); Tue, 4 Jul 2023 09:50:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230300AbjGDNu0 (ORCPT ); Tue, 4 Jul 2023 09:50:26 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38044E6 for ; Tue, 4 Jul 2023 06:50:24 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4f954d7309fso7026697e87.1 for ; Tue, 04 Jul 2023 06:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688478622; x=1691070622; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8DsZYUEHTqBU3AGKVXdDyeX9gb+lep1XYSsRWjvSZ/I=; b=WKNuf3B5GGVejJYAW9LuXXw4+PS33E2LeapZGIUL6ADxTRm91x8bmjoKpA5mlZ/X8G 7MR9wRGTLSrVuf/Fi7gXmHazP0tYZxSi47S5Mnc79Qd2bJEU4PV3an8129x/i9tN2qPm xwnTagR+NSsvrThZpYnCBo8V3Litsui7nf7hPw67DsxGA7YnbaZTdT3eR3D6AuKib2dJ ++f4fKb7Oc//QAvyuv2JJVrlZCTP4vCtTyv8qS/eouEntZBHpKdFVklyGE6vbxGXNijm IrCkUwJuHuiI/FbeBXIh3gusYJqXYK3GOC1E1L5mCqvvqSKmOjPo8/1D6Q/EJMiekREY oW5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688478622; x=1691070622; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8DsZYUEHTqBU3AGKVXdDyeX9gb+lep1XYSsRWjvSZ/I=; b=eSdkrKct5Lu+7K5O7qdJetVfHtCQvdQPWwoL0CHbzxkzaJgbHsApw8AqU8tTipl9E2 hkdO8iVaKoMkcUieUnppOo7KY5JSIGoUcnUAFlf2jPT+dL74WHEs19kVyA7lQQlX5+le +g2VpyrP46j+gluljKJGS3Z8h5xRFu6QRXUkEHWz+nDPcpVcmfyv8tUFSbfC2DVBQHce A+qX6BFPSteUdKoo95DeqtCwlCZ2TjxbTf2P+PaT0ePcO6Gq3QrKejysmmDkFcdFrK+v tM3h8sms6GuO4zlCuh9B7jAauNfJvXSM2jAhxjTBMbXCnb5IXhAOh9fpVcC1Yx7PY3Cc aMlg== X-Gm-Message-State: AC+VfDxvwEIJLV2ETlHSQD30K67oS2+fX2HV8Cujp3sdcPNBKaiPPM9/ HNw768eB+/xjAXSbTwz2D1mt3A== X-Google-Smtp-Source: ACHHUZ40dzDwz/sUzcpkcaTq5m/CZjEKlgEj3OYPpc+HneTDxI2+nl4kPhWRf9VGETUxPCD/Rj4GPQ== X-Received: by 2002:ac2:4e0c:0:b0:4f4:7a5:e800 with SMTP id e12-20020ac24e0c000000b004f407a5e800mr6424265lfr.10.1688478622464; Tue, 04 Jul 2023 06:50:22 -0700 (PDT) Received: from [192.168.1.101] (abyj26.neoplus.adsl.tpnet.pl. [83.9.29.26]) by smtp.gmail.com with ESMTPSA id f14-20020ac2532e000000b004fb77cb4b8esm4291607lfh.14.2023.07.04.06.50.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jul 2023 06:50:22 -0700 (PDT) Message-ID: <3a305852-b44f-0b4b-e8dc-fbb0749ddb18@linaro.org> Date: Tue, 4 Jul 2023 15:50:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RFC PATCH 4/8] ARM: dts: qcom: msm8960-cdp: constraint cpufreq regulators Content-Language: en-US To: Dmitry Baryshkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Ilia Lin , Viresh Kumar , Nishanth Menon , Stephen Boyd , Michael Turquette , "Rafael J. Wysocki" , Georgi Djakov , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, Christian Marangi , Stephan Gerhold References: <20230702175045.122041-1-dmitry.baryshkov@linaro.org> <20230702175045.122041-5-dmitry.baryshkov@linaro.org> <971262d5-98b3-c48e-89fd-ce107275008a@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 4.07.2023 15:34, Dmitry Baryshkov wrote: > On Tue, 4 Jul 2023 at 16:03, Konrad Dybcio wrote: >> >> On 2.07.2023 19:50, Dmitry Baryshkov wrote: >>> Add additional constraints to the CPUfreq-related regulators, it is >>> better be safe than sorry there. >>> >>> Signed-off-by: Dmitry Baryshkov >>> --- >> I'm squinting quite hard at >> >> https://github.com/LineageOS/sony-kernel-msm8960/blob/jb-dev/arch/arm/mach-msm/acpuclock-8960.c >> >> but I can't figure out where these min values came from > > These should be the minimum values for vdd_min and vdd_dig in > l2_freq_tbl_8960_kraitv2 (v1 is unsupported in mainline). > See below, > >> >> Konrad >>> arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts b/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts >>> index 414881d34c60..cba0d1e460a1 100644 >>> --- a/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts >>> +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts >>> @@ -131,7 +131,7 @@ pm8921_s2: s2 { >>> }; >>> >>> pm8921_s3: s3 { >>> - regulator-min-microvolt = <500000>; >>> + regulator-min-microvolt = <950000>; > > And this is obviously a c&p from 8064. This should be 1050000. Okay, please remember to fix all other boards from this patchset too. Konrad > >>> regulator-max-microvolt = <1150000>; >>> qcom,switch-mode-frequency = <4800000>; >>> bias-pull-down; >>> @@ -287,7 +287,7 @@ pm8921_l23: l23 { >>> }; >>> >>> pm8921_l24: l24 { >>> - regulator-min-microvolt = <750000>; >>> + regulator-min-microvolt = <1050000>; >>> regulator-max-microvolt = <1150000>; >>> bias-pull-down; >>> }; > > >