* [PATCH v2] arm64: dts: qcom: ipq9574: enable GPIO based LED
@ 2023-10-25 13:31 Kathiravan Thirumoorthy
2023-10-25 13:54 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kathiravan Thirumoorthy @ 2023-10-25 13:31 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Kathiravan Thirumoorthy
Add support for wlan-2g LED on GPIO64.
Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
---
Changes in v2:
- Added function and color property
- Link to v1: https://lore.kernel.org/r/20231025-ipq9574-led-v1-1-b8217e997dfb@quicinc.com
---
arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
index 49c9b6478357..91e104b0f865 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
@@ -10,6 +10,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
#include "ipq9574.dtsi"
/ {
@@ -51,6 +52,20 @@ button-wps {
debounce-interval = <60>;
};
};
+
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-0 = <&gpio_leds_default>;
+ pinctrl-names = "default";
+
+ led-0 {
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_WLAN;
+ gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "phy0tx";
+ default-state = "off";
+ };
+ };
};
&blsp1_spi0 {
@@ -117,6 +132,13 @@ gpio_keys_default: gpio-keys-default-state {
drive-strength = <8>;
bias-pull-up;
};
+
+ gpio_leds_default: gpio-leds-default-state {
+ pins = "gpio64";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
};
&usb_0_dwc3 {
---
base-commit: fe1998aa935b44ef873193c0772c43bce74f17dc
change-id: 20231025-ipq9574-led-8bdaab4c9cf6
Best regards,
--
Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: ipq9574: enable GPIO based LED
2023-10-25 13:31 [PATCH v2] arm64: dts: qcom: ipq9574: enable GPIO based LED Kathiravan Thirumoorthy
@ 2023-10-25 13:54 ` Krzysztof Kozlowski
2023-12-01 13:38 ` Kathiravan Thirumoorthy
2023-12-08 2:57 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-25 13:54 UTC (permalink / raw)
To: Kathiravan Thirumoorthy, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 25/10/2023 15:31, Kathiravan Thirumoorthy wrote:
> Add support for wlan-2g LED on GPIO64.
>
> Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
> ---
> Changes in v2:
> - Added function and color property
> - Link to v1: https://lore.kernel.org/r/20231025-ipq9574-led-v1-1-b8217e997dfb@quicinc.com
> ---
> arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: ipq9574: enable GPIO based LED
2023-10-25 13:31 [PATCH v2] arm64: dts: qcom: ipq9574: enable GPIO based LED Kathiravan Thirumoorthy
2023-10-25 13:54 ` Krzysztof Kozlowski
@ 2023-12-01 13:38 ` Kathiravan Thirumoorthy
2023-12-08 2:57 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Kathiravan Thirumoorthy @ 2023-12-01 13:38 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 10/25/2023 7:01 PM, Kathiravan Thirumoorthy wrote:
> Add support for wlan-2g LED on GPIO64.
Gentle Reminder...
>
> Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
> ---
> Changes in v2:
> - Added function and color property
> - Link to v1: https://lore.kernel.org/r/20231025-ipq9574-led-v1-1-b8217e997dfb@quicinc.com
> ---
> arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> index 49c9b6478357..91e104b0f865 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> @@ -10,6 +10,7 @@
>
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
> #include "ipq9574.dtsi"
>
> / {
> @@ -51,6 +52,20 @@ button-wps {
> debounce-interval = <60>;
> };
> };
> +
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-0 = <&gpio_leds_default>;
> + pinctrl-names = "default";
> +
> + led-0 {
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_WLAN;
> + gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "phy0tx";
> + default-state = "off";
> + };
> + };
> };
>
> &blsp1_spi0 {
> @@ -117,6 +132,13 @@ gpio_keys_default: gpio-keys-default-state {
> drive-strength = <8>;
> bias-pull-up;
> };
> +
> + gpio_leds_default: gpio-leds-default-state {
> + pins = "gpio64";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-pull-up;
> + };
> };
>
> &usb_0_dwc3 {
>
> ---
> base-commit: fe1998aa935b44ef873193c0772c43bce74f17dc
> change-id: 20231025-ipq9574-led-8bdaab4c9cf6
>
> Best regards,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: ipq9574: enable GPIO based LED
2023-10-25 13:31 [PATCH v2] arm64: dts: qcom: ipq9574: enable GPIO based LED Kathiravan Thirumoorthy
2023-10-25 13:54 ` Krzysztof Kozlowski
2023-12-01 13:38 ` Kathiravan Thirumoorthy
@ 2023-12-08 2:57 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-12-08 2:57 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Kathiravan Thirumoorthy
Cc: linux-arm-msm, devicetree, linux-kernel
On Wed, 25 Oct 2023 19:01:25 +0530, Kathiravan Thirumoorthy wrote:
> Add support for wlan-2g LED on GPIO64.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: ipq9574: enable GPIO based LED
commit: 2928212b6ef24d6a4f2af849157ac18546030b97
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-08 2:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-25 13:31 [PATCH v2] arm64: dts: qcom: ipq9574: enable GPIO based LED Kathiravan Thirumoorthy
2023-10-25 13:54 ` Krzysztof Kozlowski
2023-12-01 13:38 ` Kathiravan Thirumoorthy
2023-12-08 2:57 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).