From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BF2619E81F for ; Wed, 13 Aug 2025 21:31:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755120668; cv=none; b=YyvACU6v7qhNwnMfCl6szUdb6dtIrsHQlX+bwQL6tYMTZqsduBXVu8Wa8saOkeplvgmCq7hAjEe3S0gul/GPpbpPxLay458uZfEhuhAD+CpflRUkg+TIpKGI8VG239p7vva4zh903ouWbVd5kWFRABhm8kEPnwOtRpEQMW0oPNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755120668; c=relaxed/simple; bh=TeX7DeSqXZtDYblYksVwf1fig6hqiNvqQB7PVDcz6og=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P3Z8r9gdOOM4mu/dD24occsGs864nRd/7mno28U0CivcjMTHiBvCzT4JhhRiPI0VQrnxR/fRyhy91m88RDg7fj0zFQJU6Mm1ZwByESNBY69QxYnk6fYc+v0nCtDDxl9ZWT76X4IDTpPx4OeVBiU0s7FUsvzJkAsSfph2I+IKz5w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xTG5U3c8; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xTG5U3c8" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-45a1b065d58so1488785e9.1 for ; Wed, 13 Aug 2025 14:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755120665; x=1755725465; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q28JPzSY5BSXepdcH+rALVB7OoEskPnJ+f7XashvyCs=; b=xTG5U3c8yYaYTUoJ77FvupDAbIx0CJ8gqZK5dt775Md7nnLoQikKe+/jO+u2ZP0YQE 2PLn/s9iMA3YVjcUi1xV6gpYYGrzDHJJ7cuL5u3WYYn9ZPMkj1pxtxRMvBgjJbcAczNF lwg0mzk4JJlXibH6/CYHptK455CoB9sjb5qFW2+VFibuUeAzST2zN+Q9u3RYLWHo7dKP ynYxE4MXFgh1f4xzfx2QHR57jZY82sa6Ckoh2gnM4aMZxSAQBL2QlGpZswxVc/qrvebN fTKodRj2UbFjgE3/2fWFHO0D6YqgUvdnfcqbLYtEqY+NlufzgErS9sFBDhru3UeexbH3 UaZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755120665; x=1755725465; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q28JPzSY5BSXepdcH+rALVB7OoEskPnJ+f7XashvyCs=; b=l9mBqEdXuha3fzlIBKIm0T5dIB3oPdxsxqKLAdcZxjkimZvyz4f12o+4MWNQMkr92H v57Mgc+bT9iSKQDFlSCeMHNLNseayXEe/Kl3O//P64FTSonMNtBo1htM1fI2mB0E6U57 wraRP7dRGm6n6LPEcsp+iVBxVtZ56zo5oE0Ag/RgipYqul0EAEiJKifokvfspJYmc17P A1fSHELPGdzmgIlJnUb0k4TNMaRQJY/ApVFVqhrD/UsTkkWoeLZjjUFNtpTZnHmZ6mpd YmZd4KJL/jo5ZNbwPwDgungkFqnWokKYUJgMn37IbDiwn1WGuEYf2k00C1bQs29/GUDi Jj/Q== X-Forwarded-Encrypted: i=1; AJvYcCX2mUzC3SNXrYqh92FfY1l/Pm0b59dVpoTqJUcRZVgXEWvwHxkebTKcFKauzQWfj8aWYUbz7z7tNK+25piq@vger.kernel.org X-Gm-Message-State: AOJu0YxEcficuYgYTsFFF5WpdGO/TwYICYPUfmMYFyhxrwx22L7ClkcW uKpTNszRM00KbJ5ZX4bGvrmNUNBXObr61OmKKaZRNBGO6Hc7MUiS0nFtPFQ6AqGh6uQ= X-Gm-Gg: ASbGncvO/rq6kvPRTFh84Ji2lU2Y/Wwia/Rcf6SUS95a5GJac52/tWrxPB6MC0TSglT KyiERdT1BjEA5UB31hHN0rFHJ1jQGmDWJaNNDmcZQCKZOi/59GWEI7yGAY/uLWmPKYsPROQNHSi paD5fmc9+ZGdCtv0U8WNzu5ZMC5EAd2OBJi9wWTkPEcWzn1JRcm0Z2ZnleZA5EtCU4GMBxgN0jw f8aQe5MhUN2cUprasPctEZlFpMLm1ibtXBm4YtN6u4p1ueMOALx4jW9w58GGMQt/3tURRbV6dQC nY0lTS0lUE42yZxz9U3VNwoyJgbP6AX9uIYa65p+kHjS0HoTbJCAdsIvzi4MStkccl4eEhD9jxc PBgvJqQ9rfamYKJRVK/w0CorFtf1Py0z+Ds9tvp1e6ww33BA1ECjqiEy679M76YCp X-Google-Smtp-Source: AGHT+IFBQaA6gR9SrP5Rhp/Q1WznnuyKq4IQ8wctfb7KsjHauNUHTH5r/vnFl/447I18x+THFRzg/w== X-Received: by 2002:a05:600c:3154:b0:459:dde3:1a56 with SMTP id 5b1f17b1804b1-45a1b655e6emr2082495e9.28.1755120664539; Wed, 13 Aug 2025 14:31:04 -0700 (PDT) Received: from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1a536d32sm17125035e9.20.2025.08.13.14.31.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Aug 2025 14:31:04 -0700 (PDT) Message-ID: <3b0a2067-9dda-496c-adf5-4e40999a1fa3@linaro.org> Date: Wed, 13 Aug 2025 22:31:02 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/7] media: dt-bindings: Add qcom,qcs8300-camss compatible To: Vikram Sharma , rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20250813053724.232494-1-quic_vikramsa@quicinc.com> <20250813053724.232494-2-quic_vikramsa@quicinc.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20250813053724.232494-2-quic_vikramsa@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/08/2025 06:37, Vikram Sharma wrote: > Add the compatible string "qcom,qcs8300-camss" to support the > Camera Subsystem (CAMSS) on the Qualcomm QCS8300 platform. > > The QCS8300 platform provides: > - 2 x VFE (version 690), each with 3 RDI > - 5 x VFE Lite (version 690), each with 6 RDI > - 2 x CSID (version 690) > - 5 x CSID Lite (version 690) > - 3 x CSIPHY (version 690) > - 3 x TPG > > Signed-off-by: Vikram Sharma > Reviewed-by: Krzysztof Kozlowski > --- > .../bindings/media/qcom,qcs8300-camss.yaml | 336 ++++++++++++++++++ > 1 file changed, 336 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/qcom,qcs8300-camss.yaml > > diff --git a/Documentation/devicetree/bindings/media/qcom,qcs8300-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcs8300-camss.yaml > new file mode 100644 > index 000000000000..80a4540a22dc > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/qcom,qcs8300-camss.yaml > @@ -0,0 +1,336 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/qcom,qcs8300-camss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm QCS8300 CAMSS ISP > + > +maintainers: > + - Vikram Sharma > + > +description: > + The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms. > + > +properties: > + compatible: > + const: qcom,qcs8300-camss > + > + reg: > + maxItems: 21 > + > + reg-names: > + items: > + - const: csid_wrapper > + - const: csid0 > + - const: csid1 > + - const: csid_lite0 > + - const: csid_lite1 > + - const: csid_lite2 > + - const: csid_lite3 > + - const: csid_lite4 > + - const: csiphy0 > + - const: csiphy1 > + - const: csiphy2 > + - const: tpg0 > + - const: tpg1 > + - const: tpg2 > + - const: vfe0 > + - const: vfe1 > + - const: vfe_lite0 > + - const: vfe_lite1 > + - const: vfe_lite2 > + - const: vfe_lite3 > + - const: vfe_lite4 > + > + clocks: > + maxItems: 26 > + > + clock-names: > + items: > + - const: camnoc_axi > + - const: core_ahb > + - const: cpas_ahb > + - const: cpas_fast_ahb_clk > + - const: cpas_vfe_lite > + - const: cpas_vfe0 > + - const: cpas_vfe1 > + - const: csid > + - const: csiphy0 > + - const: csiphy0_timer > + - const: csiphy1 > + - const: csiphy1_timer > + - const: csiphy2 > + - const: csiphy2_timer > + - const: csiphy_rx > + - const: gcc_axi_hf > + - const: gcc_axi_sf > + - const: icp_ahb > + - const: vfe0 > + - const: vfe0_fast_ahb > + - const: vfe1 > + - const: vfe1_fast_ahb > + - const: vfe_lite > + - const: vfe_lite_ahb > + - const: vfe_lite_cphy_rx > + - const: vfe_lite_csid > + > + interrupts: > + maxItems: 20 > + > + interrupt-names: > + items: > + - const: csid0 > + - const: csid1 > + - const: csid_lite0 > + - const: csid_lite1 > + - const: csid_lite2 > + - const: csid_lite3 > + - const: csid_lite4 > + - const: csiphy0 > + - const: csiphy1 > + - const: csiphy2 > + - const: tpg0 > + - const: tpg1 > + - const: tpg2 > + - const: vfe0 > + - const: vfe1 > + - const: vfe_lite0 > + - const: vfe_lite1 > + - const: vfe_lite2 > + - const: vfe_lite3 > + - const: vfe_lite4 > + > + interconnects: > + maxItems: 2 > + > + interconnect-names: > + items: > + - const: ahb > + - const: hf_0 > + > + iommus: > + maxItems: 1 > + > + power-domains: > + items: > + - description: Titan GDSC - Titan ISP Block, Global Distributed Switch Controller. > + > + power-domain-names: > + items: > + - const: top > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + description: > + CSI input ports. > + > + patternProperties: > + "^port@[0-2]+$": > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: > + Input port for receiving CSI data on CSIPHY 0-2. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + required: > + - data-lanes > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - clock-names > + - interrupts > + - interrupt-names > + - interconnects > + - interconnect-names > + - iommus > + - power-domains > + - power-domain-names > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + #include > + #include > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + isp@ac78000 { > + compatible = "qcom,qcs8300-camss"; > + > + reg = <0x0 0xac78000 0x0 0x1000>, > + <0x0 0xac7a000 0x0 0x0f00>, > + <0x0 0xac7c000 0x0 0x0f00>, > + <0x0 0xac84000 0x0 0x0f00>, > + <0x0 0xac88000 0x0 0x0f00>, > + <0x0 0xac8c000 0x0 0x0f00>, > + <0x0 0xac90000 0x0 0x0f00>, > + <0x0 0xac94000 0x0 0x0f00>, > + <0x0 0xac9c000 0x0 0x2000>, > + <0x0 0xac9e000 0x0 0x2000>, > + <0x0 0xaca0000 0x0 0x2000>, > + <0x0 0xacac000 0x0 0x0400>, > + <0x0 0xacad000 0x0 0x0400>, > + <0x0 0xacae000 0x0 0x0400>, > + <0x0 0xac4d000 0x0 0xd000>, > + <0x0 0xac60000 0x0 0xd000>, > + <0x0 0xac85000 0x0 0x0d00>, > + <0x0 0xac89000 0x0 0x0d00>, > + <0x0 0xac8d000 0x0 0x0d00>, > + <0x0 0xac91000 0x0 0x0d00>, > + <0x0 0xac95000 0x0 0x0d00>; > + reg-names = "csid_wrapper", > + "csid0", > + "csid1", > + "csid_lite0", > + "csid_lite1", > + "csid_lite2", > + "csid_lite3", > + "csid_lite4", > + "csiphy0", > + "csiphy1", > + "csiphy2", > + "tpg0", > + "tpg1", > + "tpg2", > + "vfe0", > + "vfe1", > + "vfe_lite0", > + "vfe_lite1", > + "vfe_lite2", > + "vfe_lite3", > + "vfe_lite4"; > + > + clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>, > + <&camcc CAM_CC_CORE_AHB_CLK>, > + <&camcc CAM_CC_CPAS_AHB_CLK>, > + <&camcc CAM_CC_CPAS_FAST_AHB_CLK>, > + <&camcc CAM_CC_CPAS_IFE_LITE_CLK>, > + <&camcc CAM_CC_CPAS_IFE_0_CLK>, > + <&camcc CAM_CC_CPAS_IFE_1_CLK>, > + <&camcc CAM_CC_CSID_CLK>, > + <&camcc CAM_CC_CSIPHY0_CLK>, > + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY1_CLK>, > + <&camcc CAM_CC_CSI1PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY2_CLK>, > + <&camcc CAM_CC_CSI2PHYTIMER_CLK>, > + <&camcc CAM_CC_CSID_CSIPHY_RX_CLK>, > + <&gcc GCC_CAMERA_HF_AXI_CLK>, > + <&gcc GCC_CAMERA_SF_AXI_CLK>, > + <&camcc CAM_CC_ICP_AHB_CLK>, > + <&camcc CAM_CC_IFE_0_CLK>, > + <&camcc CAM_CC_IFE_0_FAST_AHB_CLK>, > + <&camcc CAM_CC_IFE_1_CLK>, > + <&camcc CAM_CC_IFE_1_FAST_AHB_CLK>, > + <&camcc CAM_CC_IFE_LITE_CLK>, > + <&camcc CAM_CC_IFE_LITE_AHB_CLK>, > + <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>, > + <&camcc CAM_CC_IFE_LITE_CSID_CLK>; > + clock-names = "camnoc_axi", > + "core_ahb", > + "cpas_ahb", > + "cpas_fast_ahb_clk", > + "cpas_vfe_lite", > + "cpas_vfe0", > + "cpas_vfe1", > + "csid", > + "csiphy0", > + "csiphy0_timer", > + "csiphy1", > + "csiphy1_timer", > + "csiphy2", > + "csiphy2_timer", > + "csiphy_rx", > + "gcc_axi_hf", > + "gcc_axi_sf", > + "icp_ahb", > + "vfe0", > + "vfe0_fast_ahb", > + "vfe1", > + "vfe1_fast_ahb", > + "vfe_lite", > + "vfe_lite_ahb", > + "vfe_lite_cphy_rx", > + "vfe_lite_csid"; > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + interrupt-names = "csid0", > + "csid1", > + "csid_lite0", > + "csid_lite1", > + "csid_lite2", > + "csid_lite3", > + "csid_lite4", > + "csiphy0", > + "csiphy1", > + "csiphy2", > + "tpg0", > + "tpg1", > + "tpg2", > + "vfe0", > + "vfe1", > + "vfe_lite0", > + "vfe_lite1", > + "vfe_lite2", > + "vfe_lite3", > + "vfe_lite4"; > + > + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY > + &config_noc SLAVE_CAMERA_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, > + <&mmss_noc MASTER_CAMNOC_HF QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; > + interconnect-names = "ahb", > + "hf_0"; > + > + iommus = <&apps_smmu 0x2400 0x20>; > + > + power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>; > + power-domain-names = "top"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > + }; Reviewed-by: Bryan O'Donoghue