Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shawn Guo <shengchao.guo@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: arm: qcom,ids: Correct SoC ID for Nord SA8797P
Date: Sun, 22 Nov 2026 18:47:26 +0100	[thread overview]
Message-ID: <3b14efca-a115-4f43-b594-e7652421e7d9@kernel.org> (raw)
In-Reply-To: <9eda2209-d64a-4a1c-915d-4415ac47df45@kernel.org>

On 17/11/2026 11:02, Krzysztof Kozlowski wrote:
> On 14/11/2026 14:33, Shawn Guo wrote:
>> QCOM_ID_SA8797P was defined as 690, but per Qualcomm chip info that
>> ID belongs to the QAM8797P/QAM8397P Snapdragon Ride module SKUs of
>> the Nord (NordAU) SoC. SA8797P itself is the default chip info
>> variant of the family with ID 648.
>>
>> Correct QCOM_ID_SA8797P to 648 and add QCOM_ID_QAM8797P for 690.
>>
>> Note this changes the value of an existing define. There are no
>> in-tree users other than the socinfo driver.
> 
> That ABI break for a marketing reason (which model names you use for
> actual SKUs). Honestly, we should either treat it as ABI, so not change
> it, or stop adding to DT bindings.

I sent a patchset for that.

Best regards,
Krzysztof

  reply	other threads:[~2026-11-22 17:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 13:33 [PATCH 0/4] soc: qcom: socinfo: Fix SA8797P and add IQ10800MD SoC IDs Shawn Guo
2026-11-14 13:33 ` [PATCH 1/4] dt-bindings: arm: qcom,ids: Correct SoC ID for Nord SA8797P Shawn Guo
2026-11-17 10:02   ` Krzysztof Kozlowski
2026-11-22 17:47     ` Krzysztof Kozlowski [this message]
2026-11-14 13:33 ` [PATCH 2/4] soc: qcom: socinfo: " Shawn Guo
2026-11-17  8:52   ` Abel Vesa
2026-11-14 13:33 ` [PATCH 3/4] dt-bindings: arm: qcom,ids: Add SoC ID for IQ10800MD Shawn Guo
2026-11-14 13:33 ` [PATCH 4/4] soc: qcom: socinfo: " Shawn Guo
2026-11-17  8:50   ` Abel Vesa
2026-11-17  8:29 ` [PATCH 0/4] soc: qcom: socinfo: Fix SA8797P and add IQ10800MD SoC IDs Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b14efca-a115-4f43-b594-e7652421e7d9@kernel.org \
    --to=krzk@kernel.org \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=deepti.jaggi@oss.qualcomm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=shengchao.guo@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox