From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: stanimir.varbanov@linaro.org, svarbanov@mm-sol.com,
linux-pci@vger.kernel.org, bhelgaas@google.com,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: qcom: use regulator bluk api for apq8064 supplies
Date: Wed, 14 Feb 2018 16:14:59 +0000 [thread overview]
Message-ID: <3b256b44-d3fe-9022-ed3b-b671ba5cadd1@linaro.org> (raw)
In-Reply-To: <20180214153545.GA93895@bjorns-mbp-2.lan>
On 14/02/18 15:35, Bjorn Andersson wrote:
>> + res->supplies[1].supply = "vdda_phy";
>> + res->supplies[1].supply = "vdda_refclk";
> 2
>
>> + ret = devm_regulator_bulk_get(dev, QCOM_PCIE_2_1_0_MAX_SUPPLY,
> Use ARRAY_SIZE(res->supplies) instead.
Thanks, Will fix it and send a new one.
--srini
>
>> + res->supplies);
>> + if (ret)
>> + return ret;
>>
> Other than that, this looks good.
prev parent reply other threads:[~2018-02-14 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 12:23 [PATCH] PCI: qcom: use regulator bluk api for apq8064 supplies srinivas.kandagatla
2018-02-14 15:35 ` Bjorn Andersson
2018-02-14 16:14 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b256b44-d3fe-9022-ed3b-b671ba5cadd1@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).