From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH] PCI: qcom: use regulator bluk api for apq8064 supplies Date: Wed, 14 Feb 2018 16:14:59 +0000 Message-ID: <3b256b44-d3fe-9022-ed3b-b671ba5cadd1@linaro.org> References: <20180214122315.2069-1-srinivas.kandagatla@linaro.org> <20180214153545.GA93895@bjorns-mbp-2.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180214153545.GA93895@bjorns-mbp-2.lan> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Andersson Cc: stanimir.varbanov@linaro.org, svarbanov@mm-sol.com, linux-pci@vger.kernel.org, bhelgaas@google.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On 14/02/18 15:35, Bjorn Andersson wrote: >> + res->supplies[1].supply = "vdda_phy"; >> + res->supplies[1].supply = "vdda_refclk"; > 2 > >> + ret = devm_regulator_bulk_get(dev, QCOM_PCIE_2_1_0_MAX_SUPPLY, > Use ARRAY_SIZE(res->supplies) instead. Thanks, Will fix it and send a new one. --srini > >> + res->supplies); >> + if (ret) >> + return ret; >> > Other than that, this looks good.