From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>, manivannan.sadhasivam@linaro.org
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
linux-kernel@vger.kernel.org, loic.poulain@linaro.org,
carl.yin@quectel.com, naveen.kumar@quectel.com
Subject: Re: [PATCH v4 1/3] bus: mhi: core: Clear devices when moving execution environments
Date: Fri, 19 Feb 2021 09:10:11 -0700 [thread overview]
Message-ID: <3b3476ff-3126-097a-5d1b-130ac570cce6@codeaurora.org> (raw)
In-Reply-To: <1613701052-38885-2-git-send-email-bbhatt@codeaurora.org>
On 2/18/2021 7:17 PM, Bhaumik Bhatt wrote:
> When moving from SBL to mission mode execution environment, there
> is no remove callback notification to MHI client drivers which
> operate on SBL mode only. Client driver devices are being created
> in SBL or AMSS(mission mode) and only destroyed after power down
> or SYS_ERROR. If there exist any SBL-specific channels, those are
> left open and client drivers are thus unaware of the new execution
> environment where those channels cannot operate. Close the gap and
> issue remove callbacks to SBL-specific client drivers once device
> enters mission mode.
>
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> ---
I like the idea, but I question where this is limited to the transition
to mission mode. Feels like something that should occur on all EE
changes. We might not have a current usecase that is outside what
you've implemented here, but I don't think there is anything preventing
that in future.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2021-02-19 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 2:17 [PATCH v4 0/3] Serialize execution environment changes for MHI Bhaumik Bhatt
2021-02-19 2:17 ` [PATCH v4 1/3] bus: mhi: core: Clear devices when moving execution environments Bhaumik Bhatt
2021-02-19 16:10 ` Jeffrey Hugo [this message]
2021-02-19 19:13 ` Bhaumik Bhatt
2021-02-19 2:17 ` [PATCH v4 2/3] bus: mhi: core: Download AMSS image from appropriate function Bhaumik Bhatt
2021-02-19 2:17 ` [PATCH v4 3/3] bus: mhi: core: Process execution environment changes serially Bhaumik Bhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b3476ff-3126-097a-5d1b-130ac570cce6@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=bbhatt@codeaurora.org \
--cc=carl.yin@quectel.com \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=naveen.kumar@quectel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox