From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA24237756E for ; Tue, 24 Feb 2026 10:16:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771928187; cv=none; b=JOTuDaJf9gX9hFxMa3ENn/pSVrERAahe9+W4dI/7yRrXF5biDU+qy4N+UGZN8pZqy0vjgNky9GlkQRQNK2ZAw21GPYGUrsJBe0b+f7FkH0ppGHdFlgL0pdW27Ub/GGoie+DdlbUiWhEY2cWBqlvf4sHkOMjdastkcj03NwjyZec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771928187; c=relaxed/simple; bh=tXSUvXCwunQ23EDzKHiUTSeV6Lu2PRx2BSlcE39rkkQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=URrVTsE6+JTx7O/dn+lt6ekH/T994gNDF+ePYhkTS6Dk/Z4GMRY7uP1OFXLwK4g1T1ELAxnjSAAbKGJQ29u89ISrDNEcJL8xg5svCQ6WLLFETVao07gahq26Li0DOyGQ1AOh9J748DQ3LIs2KMDSeZj3TV+m8ezdjr+4+gkEjao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=k55crp6B; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bekabLQZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="k55crp6B"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bekabLQZ" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61OAFemK1775185 for ; Tue, 24 Feb 2026 10:16:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SSFe2tWFC3c+9T/6vQ7AhbqX1hOj5PYF7zeMFWf212E=; b=k55crp6BYValQdOv gDW7zOqVuoB3RfmpldUW0H79OrK9FIkE2bEfqfgaTqE6EaBNM8fdNTymQ3Xa0Qzw EOyFTsJAulgmDqF4Cn4d21JEB8imiLRUdnYqW7BXtIoc+MJu3NqFJKSNeRR2vo/o 59HZWKnoS7oM0InEhV7YWiQpnjgWdQIHWILurUY12wX3W1FxHKnB8iiqmjSyqUmB 5Z/qsQTvftbkcDjinK7n3gsQ39tuhUWnz70pitScnPA6/LrXk/nq63+k+g3y74ag lhJ+++Pb8pB+OjXobtgUGQ/IiqPZkSFSIYEw/ws7oFctB6pK4313rbt5WREXgtAv x/TSSA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cgpj8bjm9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Feb 2026 10:16:23 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb456d53a5so567577485a.2 for ; Tue, 24 Feb 2026 02:16:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771928183; x=1772532983; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SSFe2tWFC3c+9T/6vQ7AhbqX1hOj5PYF7zeMFWf212E=; b=bekabLQZWtPPLLnOTJVI/6/G8HKVtuaCQZiWgLL/WGBTa7dcFwtJepPhzy20cIuB80 dodEroEuK/n1eMiHm7u+9e9zZk/y4tdGwsdWlqWHFfk6xCTaLBh9sOya0ZcDbPYIG2Bx svgo0TxRSysJLch2gMsCQz0neGcwzrLNH1x56xPbSy+fvz6unXYWM12oEkSXQN5gpXmU Te/2WC6+XGW9PVtWsSdCqa6E9OayA4qhKFPSVY0ia/Veb/tJTZPM0HP8GQDMxkOIagYp JpHV20gD0+eiVzymQnrcLNmddy5raA6MFP+emUFH2vfGCmmhgNtFWu8LdPWMRXlnq6tI wp7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771928183; x=1772532983; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SSFe2tWFC3c+9T/6vQ7AhbqX1hOj5PYF7zeMFWf212E=; b=YYjBmhwpuu/qG9ZlYZ33X9ORSKYeY7R37iBLoWpIsBkZC4Q1wuIq9/XaqLxv6y2G5B BsR0K2P6Jm+3CL/I6abFM9GCmLjLtfmyo0KLUe0SvAtJt6Y5BX0c90DTagqhMFirv5cT CUESvn0bBpMwSP8pGjg459ah92qX8R+i0s3DEcxWS1VPLqhKpkSqFPvJBXWyXIHSPRu4 4LJKcrL3H7NCW7ovNBichhR3Uli1lhABviZUf7RZWWx2pBYEiRlJd/01klHOup7o8IYG FFW5+8aISvRTTAK1W357n4yTBgSIc32TUwYizd4nbHRSmdisb8HkkNlQsanx8zMDjDyV PEWA== X-Forwarded-Encrypted: i=1; AJvYcCWZAvvls/h23olayiecUYha6PGwGoISmLT7ziip/JeCYhbNr2XB+jjX1lVXGVFkrBewXmWafiUaY4EMZEE6@vger.kernel.org X-Gm-Message-State: AOJu0Yxeqli5LJpp0+nhou98rK5cGWgYoO6CxymqWYAck3R6G0TREDpi hN60ZTLD9zRS/lzYsl2LzVZ0+Ii+yCKjCvi7dZTHLPoQ3E884UN9LreU1kNfI9N4CcZqCyzN6+V 492OlBXMK48VLg03DPRTFt3WEONxiZXAlNP0Ihlk4F3GdUSHc4vn04rbGcPkCRVQ1K/LM X-Gm-Gg: AZuq6aIPmG3ac2MOlV1Vtn6SFPM286x/7+G5YJDe2F4ut51XMPn+z2u0sg1+OJJGuSU R+eSTC3yPBv1QPYZw12RlLLWfmTKNs8ly97iNgCJ2r1AUEDAX5OFafP75My+U09CiGFAEsNmF9H 9ncb4O0YJoZZj0EW39SUn2L1Dn8SwRmykwv8stdJfvdbOgaBBkwWtaFukVau5jbqZ08At1hYeXY ZjPzDni0YO2jH7FHU8zybvOCGmFusHLCHtadR6arFBde0H9SmZ8D9EAHW+dH+M+brhzQTvpnM2d sU7FHsxtL1LtKekpyPHVYACNIAiM1IkhrmB+4Jhm070tyiYxMgRx2fnzyL/xp1wU26yoXGrpNXG jetSfc40TtMvh0r+HtOo+MzwzK0N3FmrvCecrvOntqOmNvsyNxyjd4lpEe6+ppp8kSbZdgFdH7l kBRK0= X-Received: by 2002:a05:620a:400e:b0:8b2:e346:de7b with SMTP id af79cd13be357-8cb8ca198ecmr1054713385a.1.1771928183028; Tue, 24 Feb 2026 02:16:23 -0800 (PST) X-Received: by 2002:a05:620a:400e:b0:8b2:e346:de7b with SMTP id af79cd13be357-8cb8ca198ecmr1054710785a.1.1771928182446; Tue, 24 Feb 2026 02:16:22 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9084c84c37sm405006366b.23.2026.02.24.02.16.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Feb 2026 02:16:21 -0800 (PST) Message-ID: <3b4dfe95-9043-4682-8fee-7588fa1fde37@oss.qualcomm.com> Date: Tue, 24 Feb 2026 11:16:18 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 14/14] ASoC: qcom: q6apm: Add support for early buffer mapping on DSP To: Srinivas Kandagatla , broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org References: <20260223180740.444311-1-srinivas.kandagatla@oss.qualcomm.com> <20260223180740.444311-15-srinivas.kandagatla@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260223180740.444311-15-srinivas.kandagatla@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI0MDA4NCBTYWx0ZWRfX7YpFpHJ0a4BG Hnn0mqy7W0wte39mSGf65ybWtE4+5h5YELjfzUHDRHtDYmBNxDun1D5C/mkdjcvCBPeFoa/lll+ EzQqNDUyNDiqZZECV9S+KuFzWyTx1UXXfaZmsOOhMKfTXwd5SxmryVYuCUtY0xlNbZxJFcyjOSo SI0df3QN9FXPe3zdInXQnyLaY8uPuCtXUjMDgk0ky01nk6HpW3brwm4RnmnbT+1bTYxCK00dyUu FF2Bj1g9CIBknqC2F7Vh2NuIzNI6Q3UHZg+sKLRPFmMBx2jYzd83hMo8cHX0YWGm9211EsyyHMb EqCXcCnhm40YbcBc2DKH7IssE4/FcdD2D53+xBZ9iWsU4BfAQYJzzARUz4wNZo5BB0/LM2hNE55 yEd8cN6lZre0Z2aq909KSa3d4M0BDJYYalyUfeAy22RSCP+UGNauj1oZ60l8aU26pC5t7ybpiSX Spbo0KN4HoO93ujihqA== X-Proofpoint-GUID: HhW0E-ZP2JSAyZ9ZZCSFldri_Vw8fnUh X-Authority-Analysis: v=2.4 cv=Z5Lh3XRA c=1 sm=1 tr=0 ts=699d7a77 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=TT9Tk4Jx3cP5QYn9PwMA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: HhW0E-ZP2JSAyZ9ZZCSFldri_Vw8fnUh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-24_01,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 adultscore=0 impostorscore=0 priorityscore=1501 phishscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602240084 On 2/23/26 7:07 PM, Srinivas Kandagatla wrote: > Buffers are allocated on pcm_new and mapped in the dsp on every prepare call, > which is inefficient and unnecessary. > > Add new functions q6apm_[un]map_memory_fixed_region to map it on > to dsp only once after allocation. > > Signed-off-by: Srinivas Kandagatla > --- [...] > -int q6apm_map_memory_regions(struct q6apm_graph *graph, unsigned int dir, phys_addr_t phys, > - size_t period_sz, unsigned int periods) > +int q6apm_set_memory_map_handle(struct q6apm_graph *graph, unsigned int dir) > +{ > + if (dir == SNDRV_PCM_STREAM_PLAYBACK) > + graph->rx_data.mem_map_handle = graph->info->mem_map_handle; > + else > + graph->tx_data.mem_map_handle = graph->info->mem_map_handle; > + > + return 0; > +} This doesn't return a useful value today, will it ever? [...] > + case APM_CMD_SHARED_MEM_UNMAP_REGIONS: > + apm->result.opcode = hdr->opcode; > + apm->result.status = 0; > + rsp = data->payload; > + > + info = idr_find(&apm->graph_info_idr, hdr->token); > + if (info) > + info->mem_map_handle = 0; > + else > + dev_err(dev, "Error (%d) Processing 0x%08x cmd\n", result->status, > + result->opcode); > + > + dev_err(dev, "Memory Map region %x\n", rsp->mem_map_handle); Looks like a debug leftover (also in the below 'case') Konrad