From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: "Trevor Gamblin" <tgamblin@baylibre.com>,
"Lucas Stankus" <lucas.p.stankus@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Dmitry Rokosov" <ddrokosov@sberdevices.ru>,
"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Saravanan Sekar" <sravanhome@gmail.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Jean-Baptiste Maneyrol" <jmaneyrol@invensense.com>,
"Crt Mori" <cmo@melexis.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [RESEND][PATCH] iio: simplify with regmap_set_bits(), regmap_clear_bits()
Date: Thu, 13 Jun 2024 17:24:14 +0800 [thread overview]
Message-ID: <3b7950db-bde8-407e-b568-51cacee93ad8@linux.alibaba.com> (raw)
In-Reply-To: <20240611165214.4091591-1-tgamblin@baylibre.com>
On 2024/6/12 00:52, Trevor Gamblin wrote:
> Simplify the way regmap is accessed in iio drivers.
>
> Instead of using regmap_update_bits() and passing the mask twice, use
> regmap_set_bits().
>
> Instead of using regmap_update_bits() and passing val = 0, use
> regmap_clear_bits().
>
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
> ---
[...]
> diff --git a/drivers/iio/adc/sc27xx_adc.c b/drivers/iio/adc/sc27xx_adc.c
> index b4a2e057d80f..2535c2c3e60b 100644
> --- a/drivers/iio/adc/sc27xx_adc.c
> +++ b/drivers/iio/adc/sc27xx_adc.c
> @@ -508,13 +508,13 @@ static int sc27xx_adc_read(struct sc27xx_adc_data *data, int channel,
> }
> }
>
> - ret = regmap_update_bits(data->regmap, data->base + SC27XX_ADC_CTL,
> - SC27XX_ADC_EN, SC27XX_ADC_EN);
> + ret = regmap_set_bits(data->regmap, data->base + SC27XX_ADC_CTL,
> + SC27XX_ADC_EN);
> if (ret)
> goto regulator_restore;
>
> - ret = regmap_update_bits(data->regmap, data->base + SC27XX_ADC_INT_CLR,
> - SC27XX_ADC_IRQ_CLR, SC27XX_ADC_IRQ_CLR);
> + ret = regmap_set_bits(data->regmap, data->base + SC27XX_ADC_INT_CLR,
> + SC27XX_ADC_IRQ_CLR);
> if (ret)
> goto disable_adc;
>
> @@ -537,8 +537,8 @@ static int sc27xx_adc_read(struct sc27xx_adc_data *data, int channel,
> if (ret)
> goto disable_adc;
>
> - ret = regmap_update_bits(data->regmap, data->base + SC27XX_ADC_CTL,
> - SC27XX_ADC_CHN_RUN, SC27XX_ADC_CHN_RUN);
> + ret = regmap_set_bits(data->regmap, data->base + SC27XX_ADC_CTL,
> + SC27XX_ADC_CHN_RUN);
> if (ret)
> goto disable_adc;
>
> @@ -559,8 +559,8 @@ static int sc27xx_adc_read(struct sc27xx_adc_data *data, int channel,
> value &= SC27XX_ADC_DATA_MASK;
>
> disable_adc:
> - regmap_update_bits(data->regmap, data->base + SC27XX_ADC_CTL,
> - SC27XX_ADC_EN, 0);
> + regmap_clear_bits(data->regmap, data->base + SC27XX_ADC_CTL,
> + SC27XX_ADC_EN);
> regulator_restore:
> if ((data->var_data->set_volref) && (channel == 30 || channel == 31)) {
> ret_volref = regulator_set_voltage(data->volref,
> @@ -765,15 +765,14 @@ static int sc27xx_adc_enable(struct sc27xx_adc_data *data)
> {
> int ret;
>
> - ret = regmap_update_bits(data->regmap, data->var_data->module_en,
> - SC27XX_MODULE_ADC_EN, SC27XX_MODULE_ADC_EN);
> + ret = regmap_set_bits(data->regmap, data->var_data->module_en,
> + SC27XX_MODULE_ADC_EN);
> if (ret)
> return ret;
>
> /* Enable ADC work clock and controller clock */
> - ret = regmap_update_bits(data->regmap, data->var_data->clk_en,
> - SC27XX_CLK_ADC_EN | SC27XX_CLK_ADC_CLK_EN,
> - SC27XX_CLK_ADC_EN | SC27XX_CLK_ADC_CLK_EN);
> + ret = regmap_set_bits(data->regmap, data->var_data->clk_en,
> + SC27XX_CLK_ADC_EN | SC27XX_CLK_ADC_CLK_EN);
> if (ret)
> goto disable_adc;
>
> @@ -789,11 +788,11 @@ static int sc27xx_adc_enable(struct sc27xx_adc_data *data)
> return 0;
>
> disable_clk:
> - regmap_update_bits(data->regmap, data->var_data->clk_en,
> - SC27XX_CLK_ADC_EN | SC27XX_CLK_ADC_CLK_EN, 0);
> + regmap_clear_bits(data->regmap, data->var_data->clk_en,
> + SC27XX_CLK_ADC_EN | SC27XX_CLK_ADC_CLK_EN);
> disable_adc:
> - regmap_update_bits(data->regmap, data->var_data->module_en,
> - SC27XX_MODULE_ADC_EN, 0);
> + regmap_clear_bits(data->regmap, data->var_data->module_en,
> + SC27XX_MODULE_ADC_EN);
>
> return ret;
> }
> @@ -803,11 +802,11 @@ static void sc27xx_adc_disable(void *_data)
> struct sc27xx_adc_data *data = _data;
>
> /* Disable ADC work clock and controller clock */
> - regmap_update_bits(data->regmap, data->var_data->clk_en,
> - SC27XX_CLK_ADC_EN | SC27XX_CLK_ADC_CLK_EN, 0);
> + regmap_clear_bits(data->regmap, data->var_data->clk_en,
> + SC27XX_CLK_ADC_EN | SC27XX_CLK_ADC_CLK_EN);
>
> - regmap_update_bits(data->regmap, data->var_data->module_en,
> - SC27XX_MODULE_ADC_EN, 0);
> + regmap_clear_bits(data->regmap, data->var_data->module_en,
> + SC27XX_MODULE_ADC_EN);
> }
>
> static const struct sc27xx_adc_variant_data sc2731_data = {
For SPRD sc27xx parts, looks good to me. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
next prev parent reply other threads:[~2024-06-13 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 16:52 [RESEND][PATCH] iio: simplify with regmap_set_bits(), regmap_clear_bits() Trevor Gamblin
2024-06-12 8:09 ` Uwe Kleine-König
2024-06-12 8:33 ` Crt Mori
2024-06-13 9:24 ` Baolin Wang [this message]
2024-06-13 17:20 ` Jonathan Cameron
2024-06-13 17:59 ` Trevor Gamblin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b7950db-bde8-407e-b568-51cacee93ad8@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandre.torgue@foss.st.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cmo@melexis.com \
--cc=cosmin.tanislav@analog.com \
--cc=ddrokosov@sberdevices.ru \
--cc=festevam@gmail.com \
--cc=hdegoede@redhat.com \
--cc=imx@lists.linux.dev \
--cc=jbrunet@baylibre.com \
--cc=jic23@kernel.org \
--cc=jmaneyrol@invensense.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lucas.p.stankus@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
--cc=orsonzhai@gmail.com \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=sravanhome@gmail.com \
--cc=tgamblin@baylibre.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=wens@csie.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox