Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: "Slark Xiao" <slark_xiao@163.com>
To: "Manivannan Sadhasivam" <mani@kernel.org>
Cc: hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH v2] bus: mhi: pci_generic: Add new device ID support for T99W175
Date: Fri, 5 Nov 2021 16:10:16 +0800 (CST)	[thread overview]
Message-ID: <3baf9d54.30a5.17cef25fd60.Coremail.slark_xiao@163.com> (raw)
In-Reply-To: <20211102035632.GA5646@thinkpad>



At 2021-11-02 11:56:32, "Manivannan Sadhasivam" <mani@kernel.org> wrote:
>On Fri, Oct 29, 2021 at 06:49:18PM +0800, Slark Xiao wrote:
>> Add new device ID 0xe0bf for T99W175.
>> This device ID is created because it is using Qualcomm SDX55 new base line.
>> 
>> Test evidence as below:
>> root@jbd-ThinkPad-P1-Gen-4:/dev# lspci -nn | grep Foxconn
>> 0000:08:00.0 Wireless controller [0d40]: Foxconn International, Inc. Device [105b:e0bf]
>> root@jbd-ThinkPad-P1-Gen-4:/dev# cat wwan0at0 & echo -ne "ati\r" > wwan0at0
>> [2] 2977
>> root@jbd-ThinkPad-P1-Gen-4:/dev# ati
>> Manufacturer: Qualcomm
>> Model: T99W175
>> Revision: T99W175.F0.6.0.0.6.CC.005  1  [Oct 21 2021 10:00:00]
>> IMEI:
>> +GCAP: +CGSM
>> 
>> OK
>> 
>> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>
>Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
>
>Thanks,
>Mani
>
Hi Mani,
    What's our next step? I didn't see any reject or confirm email.
   Could you help apply it if there is no concern?

Thanks
Slark
>> ---
>> 
>> v2: Add descriptions about the dfiiference between 0xe0ab and 0xeobf.
>> ---
>>  drivers/bus/mhi/pci_generic.c | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
>> index 59a4896a8030..94d8aa9c2eae 100644
>> --- a/drivers/bus/mhi/pci_generic.c
>> +++ b/drivers/bus/mhi/pci_generic.c
>> @@ -423,6 +423,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>>  	/* DW5930e (sdx55), Non-eSIM, It's also T99W175 */
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0b1),
>>  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
>> +	/* T99W175 (sdx55), Based on Qualcomm new baseline */
>> +	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0bf),
>> +		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
>>  	/* MV31-W (Cinterion) */
>>  	{ PCI_DEVICE(0x1269, 0x00b3),
>>  		.driver_data = (kernel_ulong_t) &mhi_mv31_info },
>> -- 
>> 2.25.1
>> 

  reply	other threads:[~2021-11-05  8:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29 10:49 [PATCH v2] bus: mhi: pci_generic: Add new device ID support for T99W175 Slark Xiao
2021-11-02  3:56 ` Manivannan Sadhasivam
2021-11-05  8:10   ` Slark Xiao [this message]
2021-11-18  6:03 ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3baf9d54.30a5.17cef25fd60.Coremail.slark_xiao@163.com \
    --to=slark_xiao@163.com \
    --cc=hemantk@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox