Re: [PATCH v5 0/4] Enable Bluetooth on qcs6490-rb3gen2 board

[Janaki Ramaiah Thota <quic_janathot@quicinc.com>]

On 12/11/2024 3:12 AM, Rob Herring (Arm) wrote:
> 
> On Mon, 09 Dec 2024 16:04:51 +0530, Janaki Ramaiah Thota wrote:
>> - Patch 1/4 Add description of the PMU of the WCN6750 module.
>> - Patch 2/4 add and enable BT node for qcs6490-rb3gen board.
>> - Patch 3/4 use the power sequencer for wcn6750.
>> - Patch 4/4 add support for the WCN6750 PMU.
>>
>> ----
>> Changes from v4:
>> * Added reviewed tag by Krzysztof in p1
>> * Updated the p2 commit message with sw_ctrl and wifi-enable are
>>    handled in wifi FW.
>> * Added blank line between the nodes in p2
>> * Placed the structures in proper order in p4
>> * Link to v4: https://lore.kernel.org/all/20241204131706.20791-1-quic_janathot@quicinc.com/
>>
>> Changes from v3:
>> * Defined the PMU node and used the its output to power up BT
>> * Used power sequencer for wcn wcn6750 module
>> * Split the patch to multiple as per subtree
>> * Add description of the PMU of the WCN6750 module
>> * Include separate UART state node for sleep pin configuarion
>> * Link to v3: https://lore.kernel.org/linux-arm-msm/20241022104600.3228-1-quic_janathot@quicinc.com/
>>
>> Changes from v2:
>> * Sorted nodes alphabetically
>> * Link to v2: https://lore.kernel.org/linux-arm-msm/20241010105107.30118-1-quic_janathot@quicinc.com/
>>
>> Changes from v1:
>> * Corrected the board name in subject
>> * Link to v1: https://lore.kernel.org/linux-arm-msm/20241009111436.23473-1-quic_janathot@quicinc.com/
>>
>> Janaki Ramaiah Thota (4):
>>    regulator:·dt-bindings:·qcom,qca6390-pmu:·document wcn6750-pmu
>>    arm64: dts: qcom: qcs6490-rb3gen: add and enable BT node
>>    Bluetooth: hci_qca: use the power sequencer for wcn6750
>>    power: sequencing: qcom-wcn: add support for the WCN6750 PMU
>>
>>   .../bindings/regulator/qcom,qca6390-pmu.yaml  |  27 +++
>>   arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts  | 168 +++++++++++++++++-
>>   drivers/bluetooth/hci_qca.c                   |   2 +-
>>   drivers/power/sequencing/pwrseq-qcom-wcn.c    |  22 +++
>>   4 files changed, 217 insertions(+), 2 deletions(-)
>>
>> --
>>
>>
>>
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>    pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y qcom/qcs6490-rb3gen2.dtb' for 20241209103455.9675-1-quic_janathot@quicinc.com:
> 
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'enable-gpios' is a required property
> 	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'swctrl-gpios' is a required property
> 	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'vddio-supply' is a required property
> 	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'vddbtcxmx-supply' is a required property
> 	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'vddasd-supply' is a required property
> 	from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml#
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pinctrl@f100000: Unevaluated properties are not allowed ('qup_uart7_sleep' was unexpected)
> 	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sc7280-pinctrl.yaml#
> 

Since the DTS files for all boards using the WCN6750 BT chip are not 
updated according to the PMU node, updating the 
bluetooth/qualcomm-bluetooth.yaml file will result in similar warnings 
for other boards.

Thanks,
Janakiram