From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36003C433EF for ; Wed, 13 Jul 2022 16:46:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237004AbiGMQqn (ORCPT ); Wed, 13 Jul 2022 12:46:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236826AbiGMQqb (ORCPT ); Wed, 13 Jul 2022 12:46:31 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C21F52FFE3; Wed, 13 Jul 2022 09:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1657730783; x=1689266783; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=kqLgUdZi53D6drYvYhKcGz92QsRtwzVgO8AAS9UQ2q0=; b=y21v731/ufUxDI49JyraQWlz4OhYm+dpXUZTDEBK2aFDqXh2agnNXmCx hHpwyIO3FqaP9bDi6aV6W8i4ysYZ/EV+TyuhqjQSzesFyD+riNF8Afddj 5GR/RcTeAsOMTm8onCYQxqDsMp1SqlYLRxOqDq7hyPPLkxA8LEIdwDiUA c=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-02.qualcomm.com with ESMTP; 13 Jul 2022 09:46:23 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2022 09:46:22 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 13 Jul 2022 09:46:22 -0700 Received: from [10.216.11.138] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 13 Jul 2022 09:46:05 -0700 Message-ID: <3def0f92-6784-df60-9533-e2902cda0185@quicinc.com> Date: Wed, 13 Jul 2022 22:15:59 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] soundwire: qcom: Update error prints to debug prints Content-Language: en-US To: Joe Perches , Pierre-Louis Bossart , , , , , , , , , , , , , , , , , , References: <1657714921-28072-1-git-send-email-quic_srivasam@quicinc.com> <75e9b775-3bbe-0b34-2bd6-b4ac74620672@linux.intel.com> <8cde58d2-3b10-b88b-2d10-88e76fbcac06@quicinc.com> <75404573094d1c46172fcd51dad6a4e564da1542.camel@perches.com> From: Srinivasa Rao Mandadapu Organization: Qualcomm In-Reply-To: <75404573094d1c46172fcd51dad6a4e564da1542.camel@perches.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 7/13/2022 9:31 PM, Joe Perches wrote: Thanks for your time Joe!!! > On Wed, 2022-07-13 at 20:22 +0530, Srinivasa Rao Mandadapu wrote: >> On 7/13/2022 7:53 PM, Pierre-Louis Bossart wrote: >> Thanks for your time Pierre-Louis!!! >>> On 7/13/22 07:22, Srinivasa Rao Mandadapu wrote: >>>> Upadte error prints to debug prints to avoid redundant logging in kernel >>> update > [] >>>> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > [] >>>> @@ -573,11 +573,10 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id) >>>> break; >>>> case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED: >>>> case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS: >>>> - dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n", >>>> - __func__); >>>> + dev_dbg(swrm->dev, "%s: SWR new slave attached\n", __func__); > Could also drop the "%s: ", __func__ as it's already a unique message > and dynamic debug could add it back if really desired. Okay. It's removed and posted v2 patch. >