From: Caleb Connolly <caleb.connolly@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: "James A. MacInnes" <james.a.macinnes@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, andersson@kernel.org,
konradybcio@kernel.org, quic_wcheng@quicinc.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, lgirdwood@gmail.com
Subject: Re: [PATCH 2/3] regulator: qcom_usb_vbus: Add support for PMI8998 VBUS
Date: Wed, 12 Feb 2025 16:09:01 +0000 [thread overview]
Message-ID: <3e8d6cb7-43e3-4375-94be-c6b28331da76@linaro.org> (raw)
In-Reply-To: <8ec05fd8-1623-457f-a3b5-1095acd62cf7@sirena.org.uk>
On 2/12/25 15:37, Mark Brown wrote:
> On Wed, Feb 12, 2025 at 03:29:54PM +0000, Caleb Connolly wrote:
>
>> I would suggest implementing a proper .is_enabled op to poll the status
>> register for OTG_STATE_ENABLED and configuring
>
> No, that would be buggy. Implement a get_status() operation if the
> device can report status. is_enabled() should report what the driver
> asked for.
Ahh yep, that's right. it should implement .get_status() (as per the
polling code in _regulator_do_enable()).
--
Caleb (they/them)
next prev parent reply other threads:[~2025-02-12 16:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 1:07 [PATCH 0/3] Add PMI8998 VBUS Regulator Support v2 James A. MacInnes
2025-02-12 1:07 ` [PATCH 1/3] regulator: qcom_usb_vbus: Update DTS binding for PMI8998 support James A. MacInnes
2025-02-12 2:04 ` Dmitry Baryshkov
2025-02-12 1:07 ` [PATCH 2/3] regulator: qcom_usb_vbus: Add support for PMI8998 VBUS James A. MacInnes
2025-02-12 3:48 ` Dmitry Baryshkov
2025-02-12 12:55 ` Konrad Dybcio
2025-02-12 16:46 ` James A. MacInnes
2025-02-12 15:29 ` Caleb Connolly
2025-02-12 15:37 ` Mark Brown
2025-02-12 16:09 ` Caleb Connolly [this message]
2025-02-12 19:25 ` James A. MacInnes
2025-02-12 16:56 ` James A. MacInnes
2025-02-12 17:12 ` Caleb Connolly
2025-02-12 1:07 ` [PATCH 3/3] arm64: boot: dts: pmi8998.dtsi: Add VBUS regulator node James A. MacInnes
2025-02-12 12:49 ` [PATCH 0/3] Add PMI8998 VBUS Regulator Support v2 Konrad Dybcio
-- strict thread matches above, loose matches on Subject: below --
2025-02-11 19:49 [PATCH 0/3] Add PMI8998 VBUS Regulator Support James A. MacInnes
2025-02-11 19:49 ` [PATCH 2/3] regulator: qcom_usb_vbus: Add support for PMI8998 VBUS James A. MacInnes
2025-02-11 20:00 ` Mark Brown
2025-02-11 23:16 ` Dmitry Baryshkov
2025-02-12 0:09 ` Mark Brown
2025-02-11 23:55 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e8d6cb7-43e3-4375-94be-c6b28331da76@linaro.org \
--to=caleb.connolly@linaro.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=james.a.macinnes@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox