Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
	andersson@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, ilia.lin@kernel.org,
	konradybcio@kernel.org, krzk+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	mturquette@baylibre.com, rafael@kernel.org, robh@kernel.org,
	ulf.hansson@linaro.org, viresh.kumar@linaro.org
Cc: Varadarajan Narayanan <quic_varada@quicinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v7 5/7] clk: qcom: gcc-ipq9574: Add CPR clock definition
Date: Wed, 28 Aug 2024 13:26:41 -0700	[thread overview]
Message-ID: <3ea62df4ff2d6615d0033322426f5f67.sboyd@kernel.org> (raw)
In-Reply-To: <20240820055705.3922754-6-quic_varada@quicinc.com>

Quoting Varadarajan Narayanan (2024-08-19 22:57:03)
> diff --git a/drivers/clk/qcom/gcc-ipq9574.c b/drivers/clk/qcom/gcc-ipq9574.c
> index 80fc94d705a0..058cde71b202 100644
> --- a/drivers/clk/qcom/gcc-ipq9574.c
> +++ b/drivers/clk/qcom/gcc-ipq9574.c
> @@ -3997,6 +3997,43 @@ static struct clk_branch gcc_xo_div4_clk = {
>         },
>  };
>  
> +static const struct freq_tbl ftbl_hmss_rbcpr_clk_src[] = {
> +       F(24000000, P_XO, 1, 0, 0),
> +       { }
> +};
> +
> +static struct clk_rcg2 rbcpr_clk_src = {
> +       .cmd_rcgr = 0x48044,
> +       .mnd_width = 0,
> +       .hid_width = 5,
> +       .parent_map = gcc_xo_map,
> +       .freq_tbl = ftbl_gp1_clk_src,
> +       .clkr.hw.init = &(struct clk_init_data){

Please mark these clk_init_data structures as const. 

> +               .name = "rbcpr_clk_src",
> +               .parent_data = gcc_xo_gpll0_gpll4,

  reply	other threads:[~2024-08-28 20:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20  5:56 [PATCH v7 0/7] Enable CPR for IPQ9574 Varadarajan Narayanan
2024-08-20  5:56 ` [PATCH v7 1/7] soc: qcom: cpr3: Fix 'acc_desc' usage Varadarajan Narayanan
2024-08-20  5:57 ` [PATCH v7 2/7] cpufreq: qcom-nvmem: Add support for IPQ9574 Varadarajan Narayanan
2024-08-20  5:57 ` [PATCH v7 3/7] dt-bindings: soc: qcom: cpr3: Add bindings " Varadarajan Narayanan
2024-08-28 20:59   ` Dmitry Baryshkov
2024-08-20  5:57 ` [PATCH v7 4/7] dt-bindings: clock: Add CPR clock defines " Varadarajan Narayanan
2024-08-20  5:57 ` [PATCH v7 5/7] clk: qcom: gcc-ipq9574: Add CPR clock definition Varadarajan Narayanan
2024-08-28 20:26   ` Stephen Boyd [this message]
2024-08-20  5:57 ` [PATCH v7 6/7] soc: qcom: cpr3: Add IPQ9574 definitions Varadarajan Narayanan
2024-08-28 21:01   ` Dmitry Baryshkov
2024-08-20  5:57 ` [PATCH v7 7/7] arm64: dts: qcom: ipq9574: Enable CPR Varadarajan Narayanan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ea62df4ff2d6615d0033322426f5f67.sboyd@kernel.org \
    --to=sboyd@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=ilia.lin@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_varada@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox