From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanimir Varbanov Subject: Re: [PATCH v2] venus: vdec: fix format enumeration Date: Sat, 24 Mar 2018 01:54:18 +0200 Message-ID: <3f82e52d-7e5e-4184-ea36-e76d924ab00c@linaro.org> References: <20180319093229.76253-1-acourbot@chromium.org> <35d51db4-bbca-e76a-abff-ed74172a5fe2@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <35d51db4-bbca-e76a-abff-ed74172a5fe2@linaro.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Hans Verkuil Cc: Alexandre Courbot , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org Hi Hans, Could you take this patch it not too late. On 20.03.2018 15:42, Stanimir Varbanov wrote: > Hi Alex, > > Thanks! > > On 03/19/2018 11:32 AM, Alexandre Courbot wrote: >> find_format_by_index() stops enumerating formats as soon as the index >> matches, and returns NULL if venus_helper_check_codec() finds out that >> the format is not supported. This prevents formats to be properly >> enumerated if a non-supported format is present, as the enumeration will >> end with it. >> >> Fix this by moving the call to venus_helper_check_codec() into the loop, >> and keep enumerating when it fails. >> >> Fixes: 29f0133ec6 media: venus: use helper function to check supported codecs >> >> Signed-off-by: Alexandre Courbot >> --- >> drivers/media/platform/qcom/venus/vdec.c | 13 +++++++------ >> drivers/media/platform/qcom/venus/venc.c | 13 +++++++------ >> 2 files changed, 14 insertions(+), 12 deletions(-) > > Acked-by: Stanimir Varbanov > regards, Stan