From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CC3818BC03 for ; Tue, 8 Oct 2024 10:02:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728381741; cv=none; b=YyC1+5WJTpvRo+Fbj9gYMyNdGW7urS6lh6HKg7BOnx+clx81H489y7GVWs3Sg/0+4fwH2e/Y7pbTmN8tgf4untbKJNwVFM+Syql1hBB8dH3q8Ujuqr1J+HcJt3oq8U8Hy5lRXx4S5MmnERkSlWZ9aa5YEGTND81wp66uHIJMIgE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728381741; c=relaxed/simple; bh=n8j8JNXdThPtkvPES1j61HnDlzBM8+UCGYT2Xypot7A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f7hKMbKvsHCfTQayVuai6zZA7vFeTPnPK1bTSOxCa2jZINLsGJ2X7bNXN9Y8BkO3T7Eg8tqP5SRy0fHy9VI7+mi1gYt661r0jRmgOmS635t+nlAkG0Nu+kttpnszEm7uO3oArK198VbCt8Le5DttCeBNdnuKNhz/PNweGhLO+y4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uUgrDllf; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uUgrDllf" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5389e190518so796460e87.1 for ; Tue, 08 Oct 2024 03:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728381737; x=1728986537; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tpOfxtVlCj+ReW9oGgsP720DcMraaz2lPqesL3hVXXY=; b=uUgrDllf6hl/GtudNKK5p5mMqKShlKNQ29vQjsx5ar16r9CbW1nzqLtYeRk5p9H6BI dIpAcAqSqErGZaitsHxEbmCVASah34vsGwQ6B+ZCpYE1lQMgt6cL7jQ/4AoFT1DGg46d QTK83PxkawQI8/LU65XpKQv8NQU3xjXuTk9dfLmDf6Hg3POh7FOjFjiu84ElLrtyaDBR 4ECBplpfW2pWE8zQ3xiVL9j7jsx4Nte6MPnpvIgyo5pV0rBsfV0MPZ1hGxvX12Tx/6LI Ak1XxpbRqgmb5UtygB7RStatCO5E+wQ8Wjk5CizKyxYVSlVLjUInViM8SHQQ5Fa2heE2 PW0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728381737; x=1728986537; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tpOfxtVlCj+ReW9oGgsP720DcMraaz2lPqesL3hVXXY=; b=B6McfhuCy2t/5n4hBH0H1jOXjk4YLr1Ed0RxRWRVRuD+nB5/v7V92ez0AYhiU7nNjr WBitFqoop/dP6NjMgEnZr3vZEVKt4LBkXQomu4sLRLkHEzQ/vypiNhnhndzJfpTnCPLG B+dO5MYmsXdact7yn3ecknLzbFQu+duknGZsa9TazTY5jRgb+f5Z1Ao6xz32XsSJdgjV vNXUSf+OoOxL7M9+WjyYuij3K3FKmr+qfPNLgcYQrkyeqK10DMPHLE6R+b9lps/Lfxhs 2vC8QI0W7Nka2p6YXJMEs/IZi0B9P9QA992ccOMsLXjTXM4rQ7fUrvPhv0wbEZ/0RPzD JqNw== X-Forwarded-Encrypted: i=1; AJvYcCVfhkfymMcK1giyf+6CqPm7lcOtimB8tzeZbB13xh74EQW4UJsA4G0GuQjTuWpEQubr0UqvZ6R082ZqJevd@vger.kernel.org X-Gm-Message-State: AOJu0YyrLCyuP1kJ2ReTzBM22OPJ50CzkRh7NYImtDf5INrkcTtGOOCp vxWTV1ToaRDnTccE3mNcjTAdAozv6FtimKNwx9NvWTrFQUmE/RdWZtH4FxUt0Gw= X-Google-Smtp-Source: AGHT+IHgeqyXij4u+nD1ePGJkAgVf28uEoo4swmpnqI06xa99FGkCCQPWG4HGuN7zAGO55WXBD4cFg== X-Received: by 2002:a05:6512:3a8c:b0:52f:287:a083 with SMTP id 2adb3069b0e04-539ab6d8d5amr2325191e87.0.1728381737052; Tue, 08 Oct 2024 03:02:17 -0700 (PDT) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-539aff23390sm1155019e87.212.2024.10.08.03.02.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Oct 2024 03:02:15 -0700 (PDT) Message-ID: <3f87e855-8779-4df3-8f26-e3d2b611d3e9@linaro.org> Date: Tue, 8 Oct 2024 13:02:07 +0300 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] dt-bindings: media: qcom,sc8280xp-camss: Fix interrupt types Content-Language: en-US To: Bjorn Andersson Cc: Robert Foss , Todor Tomov , Bryan O'Donoghue , Konrad Dybcio , Mauro Carvalho Chehab , Hans Verkuil , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski References: <20240923072827.3772504-1-vladimir.zapolskiy@linaro.org> <20240923072827.3772504-2-vladimir.zapolskiy@linaro.org> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bjorn, On 10/6/24 05:36, Bjorn Andersson wrote: > On Mon, Sep 23, 2024 at 10:28:22AM GMT, Vladimir Zapolskiy wrote: >> The expected type of all CAMSS interrupts is edge rising, fix it in >> the documented example from CAMSS device tree bindings for sc8280xp. >> > > Who/what expects them to be RISING? I've checked CAMSS device tree bindings in a number of downstream kernels, all of them describe interrupt types as edge rising. $ grep -Hn IRQF_TRIGGER drivers/media/platform/qcom/camss/* drivers/media/platform/qcom/camss/camss-csid.c:619: IRQF_TRIGGER_RISING | IRQF_NO_AUTOEN, drivers/media/platform/qcom/camss/camss-csiphy.c:605: IRQF_TRIGGER_RISING | IRQF_NO_AUTOEN, drivers/media/platform/qcom/camss/camss-ispif.c:1164: IRQF_TRIGGER_RISING, ispif->irq_name, ispif); drivers/media/platform/qcom/camss/camss-ispif.c:1168: IRQF_TRIGGER_RISING, ispif->irq_name, ispif); drivers/media/platform/qcom/camss/camss-vfe.c:1327: IRQF_TRIGGER_RISING, vfe->irq_name, vfe); From runtime point of view it's more important to get re-probed camss driver, see an absolutely similar and previously discussed case (in the cover letter): https://lore.kernel.org/lkml/20220530080842.37024-4-manivannan.sadhasivam@linaro.org/ Now in runtime I get this error, it's easy to check by unbinding/binding any camss device: irq: type mismatch, failed to map hwirq-509 for interrupt-controller@17a00000! Basically camss devices can not be bound on the second time on the number of platforms touched by this changeset. >> Fixes: bc5191e5799e ("media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding") >> Signed-off-by: Vladimir Zapolskiy >> Acked-by: Krzysztof Kozlowski >> --- >> .../bindings/media/qcom,sc8280xp-camss.yaml | 40 +++++++++---------- >> 1 file changed, 20 insertions(+), 20 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml >> index c0bc31709873..9936f0132417 100644 >> --- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml >> +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml >> @@ -328,26 +328,26 @@ examples: >> vdda-phy-supply = <&vreg_l6d>; >> vdda-pll-supply = <&vreg_l4d>; >> >> - interrupts = , >> - , >> - , >> - , >> - , >> - , >> - , >> - , >> - , >> - , >> - , >> - , >> - , >> - , >> - , >> - , >> - , >> - , >> - , >> - ; >> + interrupts = , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + ; >> >> interrupt-names = "csid1_lite", >> "vfe_lite1", >> -- >> 2.45.2 >> -- Best wishes, Vladimir