From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balakrishna Godavarthi Subject: Re: [PATCH v6 3/6] Bluetooth: hci_qca: Fix frame reassembly errors for wcn3990 Date: Fri, 28 Dec 2018 13:19:02 +0530 Message-ID: <3ff6a55912a5b4f9462484d90bab3084@codeaurora.org> References: <20181227073136.8431-1-bgodavar@codeaurora.org> <20181227073136.8431-4-bgodavar@codeaurora.org> <20181227202514.GK261387@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181227202514.GK261387@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Matthias Kaehlcke Cc: marcel@holtmann.org, johan.hedberg@gmail.com, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org Hi Matthias, On 2018-12-28 01:55, Matthias Kaehlcke wrote: > On Thu, Dec 27, 2018 at 01:01:33PM +0530, Balakrishna Godavarthi wrote: >> During initalization of wcn3990, we observed UART is reading some >> stray bytes on the Rx line. This is logging Frame reassembly errors >> on the serial console. This could be because of tristate of Tx line >> of wcn3990 during boot up. > > My testing suggests that this change is not needed if the Rx line of > the SoC/AP is configured with a pull-up. We'd probably all prefer not > to have this change if there's a neater way to address the garbage > data. Could you test with adding the pull-up and dropping this patch > on your side? > > Thanks > > Matthias Thanks a lot it worked to me. will drop this patch. -- Regards Balakrishna.