From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="JQqEzI7W" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B552094; Mon, 20 Nov 2023 17:03:50 -0800 (PST) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AL0YPPl010938; Tue, 21 Nov 2023 01:03:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=iuwUEciOgmI9mfsGHsJQiZaDbUpzR+ZnaxmmfqYKVv8=; b=JQqEzI7WfPVXl/fvnhPdUX6ZAepCKdOtB6jA4rBY5qKyrrE7grH8OTj/RwKPjqzw2otS CADNzdJGTDHBGeDIz9j1QJhrR/+lH1mFpE/F1RBCU6snQeOyAYJ0uv1wQTRJja/gIqEw +Or1MPUqEQBECFG000pasZJ2SUPc2HfdrBAUwZkmoCFZ3ug1TdbstIi3c0ictOONImUG +xMrc3IPHwc04w+VBGyTWCt4ugLcN3oSGbLbX9JiXb16lKRvCCLs0FBRX52qhulLUVpd F0bXbPnPkFz6izgeL2HZrJ/uY30XHHUsAK7dxuXNq3n12XY4UOY+Xnwtc1k+HZN2utFb oA== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ugdxmgg7k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 01:03:45 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AL13imJ003959 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 01:03:44 GMT Received: from [10.239.132.204] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 20 Nov 2023 17:03:42 -0800 Message-ID: <40b86f99-3d55-4237-8638-de7efacfc307@quicinc.com> Date: Tue, 21 Nov 2023 09:03:39 +0800 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/16] arm64: dts: qcom: sm8550-aim300: enable PMIC Volume and Power buttons To: Krzysztof Kozlowski , , , , , , , CC: , , , <-cc=kernel@quicinc.com> References: <20231117101817.4401-1-quic_tengfan@quicinc.com> <20231117101817.4401-13-quic_tengfan@quicinc.com> From: Tengfei Fan In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 2_CMwdHYiB-oSagY5Y-I-9nU8UVSueZ3 X-Proofpoint-ORIG-GUID: 2_CMwdHYiB-oSagY5Y-I-9nU8UVSueZ3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-20_22,2023-11-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 phishscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 lowpriorityscore=0 spamscore=0 adultscore=0 impostorscore=0 mlxlogscore=462 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311210004 在 11/17/2023 6:32 PM, Krzysztof Kozlowski 写道: > On 17/11/2023 11:18, Tengfei Fan wrote: >> The Volume Down & Power buttons are controlled by the PMIC via the PON >> hardware, and the Volume Up is connected to a PMIC gpio. >> >> Enable the necessary hardware and setup the GPIO state for the Volume Up >> gpio key. >> >> Signed-off-by: Tengfei Fan >> --- > > No, really, necessary hardware? So why it is missing in the previous patch? > > Stop useless splitting of work which is done. You cannot have "release > late, release often". The rule is: "release early, release often". > > NAK. > > Best regards, > Krzysztof > Hi Krzysztof, In next version patch series, I'm going to combine all the splited functions into one patch. -- Thx and BRs, Tengfei Fan