Re: [PATCH V7 RESEND 4/7] spi: spi-geni-qcom: Add interconnect support

Mark Brown
2020-06-09T13:41:17Z

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

On Tue, Jun 09, 2020 at 11:26:31AM +0530, Akash Asthana wrote:
> Get the interconnect paths for SPI based Serial Engine device
> and vote according to the current bus speed of the driver.
>
> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---

I've repeatedly acked this patch but my ack never seems to get carried
forward :(

> + /* Set the bus quota to a reasonable value for register access */
> + mas->se.icc_paths[GENI_TO_CORE].avg_bw = Bps_to_icc(CORE_2X_50_MHZ);
> + mas->se.icc_paths[CPU_TO_GENI].avg_bw = GENI_DEFAULT_BW;

Why are these asymmetric?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]