From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeykumar Sankaran Subject: Re: [PATCH v3 7/7] drm/msm/dpu: Make _dpu_plane_get_aspace void Date: Mon, 24 Sep 2018 11:01:15 -0700 Message-ID: <41c32e7d920f1e9d5d80d82cdd3a2067@codeaurora.org> References: <20180924164729.GE10761@jcrouse-lnx.qualcomm.com> <20180924174555.11494-1-bzwang@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180924174555.11494-1-bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Bruce Wang Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gMjAxOC0wOS0yNCAxMDo0NSwgQnJ1Y2UgV2FuZyB3cm90ZToKPiBSZW1vdmUgdW5uZWVkZWQg Y2hlY2tzIGZyb20gX2RwdV9wbGFuZV9nZXRfYXNwYWNlLiBUaGUgZnVuY3Rpb24KPiBubyBsb25n ZXIgbmVlZHMgdG8gcmV0dXJuIGFueXRoaW5nIHNvIGl0IGlzIGNoYW5nZWQgdG8gdm9pZC4KPiAK QXJlIHRoZSBzdWJqZWN0IGFuZCB0ZXh0IHN0aWxsIGFwcHJvcHJpYXRlIGZvciB0aGUgcGF0Y2g/ IFRoZSBmdW5jdGlvbiAKaXMgcmV0dXJuaW5nCmEgcHRyIHRvIG1zbV9nZW1fYWRkcmVzc19zcGFj ZS4KCj4gdjM6IGNoYW5nZSBfZHB1X3BsYW5lX2dldF9hc3BhY2UgdG8gcmV0dXJuIGEgc3RydWN0 Cj4gKm1zbV9nZW1fYWRkcmVzc19zcGFjZSBpbnN0ZWFkIHBhc3NpbmcgaW4gYSBwb2ludGVyIG9m IHRoZSBzYW1lCj4gdHlwZSB0byBlZGl0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEJydWNlIFdhbmcg PGJ6d2FuZ0BjaHJvbWl1bS5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9k cHUxL2RwdV9wbGFuZS5jIHwgMzUgKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMjkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9wbGFuZS5jCj4gYi9kcml2ZXJzL2dw dS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfcGxhbmUuYwo+IGluZGV4IDkyNGUzMjFhNWFjNC4uMDJj MjcyNDBkMzhmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2Rw dV9wbGFuZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X3BsYW5l LmMKPiBAQCAtNDMxLDIzICs0MzEsMTIgQEAgc3RhdGljIHZvaWQgX2RwdV9wbGFuZV9zZXRfcW9z X3JlbWFwKHN0cnVjdAo+IGRybV9wbGFuZSAqcGxhbmUpCj4gIC8qKgo+ICAgKiBfZHB1X3BsYW5l X2dldF9hc3BhY2U6IGdldHMgdGhlIGFkZHJlc3Mgc3BhY2UKPiAgICovCj4gLXN0YXRpYyBpbnQg X2RwdV9wbGFuZV9nZXRfYXNwYWNlKAo+IC0JCXN0cnVjdCBkcHVfcGxhbmUgKnBkcHUsCj4gLQkJ c3RydWN0IGRwdV9wbGFuZV9zdGF0ZSAqcHN0YXRlLAo+IC0JCXN0cnVjdCBtc21fZ2VtX2FkZHJl c3Nfc3BhY2UgKiphc3BhY2UpCj4gK3N0YXRpYyBpbmxpbmUgc3RydWN0IG1zbV9nZW1fYWRkcmVz c19zcGFjZSAqX2RwdV9wbGFuZV9nZXRfYXNwYWNlKAo+ICsJCXN0cnVjdCBkcHVfcGxhbmUgKnBk cHUpCj4gIHsKPiAtCXN0cnVjdCBkcHVfa21zICprbXM7Cj4gLQo+IC0JaWYgKCFwZHB1IHx8ICFw c3RhdGUgfHwgIWFzcGFjZSkgewo+IC0JCURQVV9FUlJPUigiaW52YWxpZCBwYXJhbWV0ZXJzXG4i KTsKPiAtCQlyZXR1cm4gLUVJTlZBTDsKPiAtCX0KPiAtCj4gLQlrbXMgPSBfZHB1X3BsYW5lX2dl dF9rbXMoJnBkcHUtPmJhc2UpOwo+ICsJc3RydWN0IGRwdV9rbXMgKmttcyA9IF9kcHVfcGxhbmVf Z2V0X2ttcygmcGRwdS0+YmFzZSk7Cj4gCj4gLQkqYXNwYWNlID0ga21zLT5iYXNlLmFzcGFjZTsK PiAtCj4gLQlyZXR1cm4gMDsKPiArCXJldHVybiBrbXMtPmJhc2UuYXNwYWNlOwo+ICB9Cj4gCj4g IHN0YXRpYyBpbmxpbmUgdm9pZCBfZHB1X3BsYW5lX3NldF9zY2Fub3V0KHN0cnVjdCBkcm1fcGxh bmUgKnBsYW5lLAo+IEBAIC00NTYsMTUgKzQ0NSw5IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBfZHB1 X3BsYW5lX3NldF9zY2Fub3V0KHN0cnVjdAo+IGRybV9wbGFuZSAqcGxhbmUsCj4gIAkJc3RydWN0 IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4gIHsKPiAgCXN0cnVjdCBkcHVfcGxhbmUgKnBkcHUgPSB0 b19kcHVfcGxhbmUocGxhbmUpOwo+IC0Jc3RydWN0IG1zbV9nZW1fYWRkcmVzc19zcGFjZSAqYXNw YWNlID0gTlVMTDsKPiArCXN0cnVjdCBtc21fZ2VtX2FkZHJlc3Nfc3BhY2UgKmFzcGFjZSA9Cj4g X2RwdV9wbGFuZV9nZXRfYXNwYWNlKHBkcHUpOwo+ICAJaW50IHJldDsKPiAKPiAtCXJldCA9IF9k cHVfcGxhbmVfZ2V0X2FzcGFjZShwZHB1LCBwc3RhdGUsICZhc3BhY2UpOwo+IC0JaWYgKHJldCkg ewo+IC0JCURQVV9FUlJPUl9QTEFORShwZHB1LCAiRmFpbGVkIHRvIGdldCBhc3BhY2UgJWRcbiIs IHJldCk7Cj4gLQkJcmV0dXJuOwo+IC0JfQo+IC0KPiAgCXJldCA9IGRwdV9mb3JtYXRfcG9wdWxh dGVfbGF5b3V0KGFzcGFjZSwgZmIsICZwaXBlX2NmZy0+bGF5b3V0KTsKPiAgCWlmIChyZXQgPT0g LUVBR0FJTikKPiAgCQlEUFVfREVCVUdfUExBTkUocGRwdSwgIm5vdCB1cGRhdGluZyBzYW1lIHNy YyBhZGRyc1xuIik7Cj4gQEAgLTgxNiw3ICs3OTksNyBAQCBzdGF0aWMgaW50IGRwdV9wbGFuZV9w cmVwYXJlX2ZiKHN0cnVjdCBkcm1fcGxhbmUKPiAqcGxhbmUsCj4gIAlzdHJ1Y3QgZHJtX2dlbV9v YmplY3QgKm9iajsKPiAgCXN0cnVjdCBtc21fZ2VtX29iamVjdCAqbXNtX29iajsKPiAgCXN0cnVj dCBkbWFfZmVuY2UgKmZlbmNlOwo+IC0Jc3RydWN0IG1zbV9nZW1fYWRkcmVzc19zcGFjZSAqYXNw YWNlOwo+ICsJc3RydWN0IG1zbV9nZW1fYWRkcmVzc19zcGFjZSAqYXNwYWNlID0KPiBfZHB1X3Bs YW5lX2dldF9hc3BhY2UocGRwdSk7Cj4gIAlpbnQgcmV0Owo+IAo+ICAJaWYgKCFuZXdfc3RhdGUt PmZiKQo+IEBAIC04MjQsMTIgKzgwNyw2IEBAIHN0YXRpYyBpbnQgZHB1X3BsYW5lX3ByZXBhcmVf ZmIoc3RydWN0IGRybV9wbGFuZQo+ICpwbGFuZSwKPiAKPiAgCURQVV9ERUJVR19QTEFORShwZHB1 LCAiRkJbJXVdXG4iLCBmYi0+YmFzZS5pZCk7Cj4gCj4gLQlyZXQgPSBfZHB1X3BsYW5lX2dldF9h c3BhY2UocGRwdSwgcHN0YXRlLCAmYXNwYWNlKTsKPiAtCWlmIChyZXQpIHsKPiAtCQlEUFVfRVJS T1JfUExBTkUocGRwdSwgIkZhaWxlZCB0byBnZXQgYXNwYWNlXG4iKTsKPiAtCQlyZXR1cm4gcmV0 Owo+IC0JfQo+IC0KPiAgCS8qIGNhY2hlIGFzcGFjZSAqLwo+ICAJcHN0YXRlLT5hc3BhY2UgPSBh c3BhY2U7CgotLSAKSmV5a3VtYXIgUwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9mcmVlZHJlbm8K