From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 951EF2E0B44 for ; Thu, 30 Oct 2025 17:06:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761843979; cv=none; b=LtInpbX0cY87dovasKdEgcvgZvU8DwDnYLgtulAqV0ZtonhKzT9H6U3DKBVsi8zZLV5Zgxpk9XbN9spz4oA5P7qjwGOIaGmfaKuXCL1AfvdKnpfxC4q/RO965/m7OcAck+PD0E1rGjDGb9ruV7fP9GByv2is1RUf1gkJuumHvXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761843979; c=relaxed/simple; bh=LvR0uV2UUFEjjW8GoIT53Fs/684GGpnkAc2fKO9ZbTg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a/VhzYtx9VxQUjGPKhxL0CqAPz22LTaFAxCREUFPh4ERHlbJ+sQ8LbshJYwaUEqM6RfAon27WEV333Tga8aeE8JLjureguHGz5/WlwY3ZRetfsTc5yCIWecoNTtPcS7g3G+zuZaZgwG6ly+WRuphJaE4e/XZqTScz8J4pm4477o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RGmKKO+E; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=U8yq1Nxj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RGmKKO+E"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U8yq1Nxj" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59U9WYr73117567 for ; Thu, 30 Oct 2025 17:06:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RQdiWSs1pdAq16tCBx6T1gHaJtXV5GNkrGHabI2OIg8=; b=RGmKKO+E4/IgzYXF UqQN3ci57t38sFZpHrc7kOnAmeiTEQVi/DZUBZ4Hj681989qjA6Y3DFklW4Q4eep nuboUKLPQQ8LFxfyN13dJ+JkiN4YtpxvJm0pORxCKmjmdhgWpfT95MXExIY7SlBI 5/QOpzeRRUSH0l0Y75228Td3lD5Rs7CxoGIhSSLowIhBgU38cIQ6Dn5V14U7jUR+ Lgt8YKplKSAFAQ9doaVIDSpkG2On7L6BMVHlA7XLyEgLJsCNs283+w0FhYjhmQal U1sicJL66EVvlFoA4eHoJ21WLjcXjCYg4dbpGUA9qRrpqnHZqTpKtqKiK73rbR9N crjsxA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a45frh9k0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Oct 2025 17:06:16 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-277f0ea6ee6so11981245ad.0 for ; Thu, 30 Oct 2025 10:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1761843975; x=1762448775; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RQdiWSs1pdAq16tCBx6T1gHaJtXV5GNkrGHabI2OIg8=; b=U8yq1Nxj00WAGdiB8Tzv/nFdLorkHXTwPWtkn+ODkTXfxf1JyF9IS0COi/EifgZHKt 9zw8c4Rgnq9r9GjkZl+nUX1kBEMj/4qcjObVhtXPUIkm8KOJsICNJFmSSK+ZnRYxPyDi HqUShdsc9hgEp/9X3l1+G4M2AgDLE1G3JVows9fUXw8yZ8KXTLcZwaSIULfQauNfxle6 uJfYhjsceIy6NGiCVTXxM1RMtcRL1iGGtfWgyCDMqxkspkOmt61DV+Nw6ZWcBVyloJW9 ZLx12N46kCvlUFL5xVq/LWh+/X/Xc31S++0NayFeHkKrs6BgUkxxVyIGRecDzm2/AKiP Mwjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761843975; x=1762448775; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RQdiWSs1pdAq16tCBx6T1gHaJtXV5GNkrGHabI2OIg8=; b=SyETDOE6kPah96++89CYjJMVPGIcykLTGWIUpv8y8a8o1Tr67W7mGjA0lZFkgU0QXl ARDulNc9L+LXSFjYM7xS7eJqROm+41XQo2CkO5LPHXkObhaPZbUCFYi31qkNHb8xVA2g Cm9N11peRU7hL8YFcmb/t6My8pHfre2mfKGJNSujUPQpBNr7AJInpoy5XIhEZvhLkua0 N/KFsRiqz+OXjc2yW3iKSewRFXycI7fmHITl00Tlz+CxMdtzXR0kuUnsNksd55hezjDl Ft9hFwPhnV1+khxsIL/8zrgTx+0KKTa0PVNRzqO7UBrEjkLV6SekuQcFrtxtM+e/MvKQ nAPQ== X-Gm-Message-State: AOJu0Yzz9BmPehCqh1qIwo26UDEw27TM2eXNZeti2txG5sCP33U/vQl+ Twsa4t/ESni4Su4nKhbm/SRxsFqk78mjpYnpmAdHLsWDFo1HXO/jCqTyUP5TFnF5+1NcBWlUt69 JHiKUekNG1Sr3f0ciUirPEKGR/BazMT7H+U3B496l2iQdYNUQO3GeCRdRU6Q8iYlCnIiX X-Gm-Gg: ASbGncvkX+YAt3G1Dy4jhr7MiuMWPMlYOy1pYVFCg29tEe0DtxHhSXgKpMgXPGUTUMf 7Kvs8yqcCIMzeP9NPrkANl2hAgTKUlrdhliT39mnsbuknIqaThklawiUaaOeXxODlkxNOk67ZGt RUKHaRR+dYuIGjacK9JTEibwmDAk3diZsKoTWPjpuSWqZXYZTBNPTwKfkROqGsrXNews6VXa1YE F6FxLza+BaIMGCS2la7Ie3APFb3cI5F5AH7TL3Xd6xtM/SqCGze5+3Hd9GerrzkRa9un1XOMBHa ipggBAKFd6nEMU8jxNE841VQycYdFhEWU/ZclUlanpiiW117hTodEhDGaffinAofZgWNSO5q3mL 4cFvco5rdHHMPyx78jppjQiGHH0I= X-Received: by 2002:a17:902:f644:b0:275:81ca:2c5 with SMTP id d9443c01a7336-2951a600875mr6526995ad.59.1761843975126; Thu, 30 Oct 2025 10:06:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGmWxDYd8AFe9Hj5FT5SvFYc4S0giUKw0u/xBUp8Hfu1jGx/wHegd1K6+sYRoSAbI9+qYjVCQ== X-Received: by 2002:a17:902:f644:b0:275:81ca:2c5 with SMTP id d9443c01a7336-2951a600875mr6524995ad.59.1761843974115; Thu, 30 Oct 2025 10:06:14 -0700 (PDT) Received: from [192.168.0.195] ([49.204.28.130]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29498cf3465sm197299615ad.1.2025.10.30.10.06.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Oct 2025 10:06:11 -0700 (PDT) Message-ID: <41e31da2-5ea5-443f-a8f3-ef8280f25a00@oss.qualcomm.com> Date: Thu, 30 Oct 2025 22:36:06 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] clk: qcom: ecpricc-qdu100: Add mem_enable_mask to the clock memory branch To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Ajit Pandey , Imran Shaik , Jagadeesh Kona References: <20251024-sm8750-videocc-v2-v3-0-6286bbda3c8e@oss.qualcomm.com> <20251024-sm8750-videocc-v2-v3-2-6286bbda3c8e@oss.qualcomm.com> <102d9042-49cb-4aff-8b93-a882ed8da27c@oss.qualcomm.com> <98da2c17-764d-43db-9b13-d950078ba41c@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: <98da2c17-764d-43db-9b13-d950078ba41c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=KupAGGWN c=1 sm=1 tr=0 ts=69039b08 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=kYOnW6kYNC4MuwyOue8uGA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=ve3y1cz88okj8OIuEZ0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: oJzWJlpFkhhc5WIRLSQHFayPvsahejP5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDMwMDE0MSBTYWx0ZWRfX8xDrHWMacc26 WDimyp4GdH/M4EqUViGfYIbZzNlmuxD8gG7hgtYyyYkBwYBxPcsXmDqOg3V88P5GJxGdOZO6FLK GeleTWorjhL0fU2Q0mTCXY7cISqQF7296jmaqMicUpgoPSREypttmphg2cdj/eZEv3/tqMMsWKn SW5y90QQZT1Ckg/Tjx8UcxLBwbZiM/cJagcijOLA41sj99oWmfNVcDyWiNIc3WpLwODHa3QK5l/ 90I5a/1ZRL+XRy7HStwh9ce8N00B9tYzjHFpu9D6Y9/PQSRZLvq2N7iH5Iw9InAu9FewG7FEQgl ACdxbaXZou06qlgUHP5LDhfQWnFkB9oZkz2okUroKhjOVhSe2vJ5mt2nHNAnp6ch644Qi3paN8p aWA97zCqAzKkci1xxdtPQWWFI1G9HA== X-Proofpoint-GUID: oJzWJlpFkhhc5WIRLSQHFayPvsahejP5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-10-30_05,2025-10-29_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2510300141 On 10/30/2025 4:41 PM, Konrad Dybcio wrote: > On 10/30/25 7:24 AM, Taniya Das wrote: >> >> >> On 10/24/2025 2:09 PM, Konrad Dybcio wrote: >>> On 10/24/25 6:24 AM, Taniya Das wrote: >>>> Add the newly introduced 'mem_enable_mask' to the memory control branch >>>> clocks of ECPRI clock controller to align to the new mem_ops handling. >>>> >>>> Signed-off-by: Taniya Das >>>> --- >>> >>> This probably fixes some ugly issue, could you please mention what >>> the impact/problem is? >>> >> Konrad, this isn’t an issue. Previously, the ECPRI clock controller’s >> mem_ops clocks used the mem_enable_ack_mask bit directly for both >> setting and polling. However, this approach didn’t apply to newer >> mem_ops clocks. > > Right, the videocc patch you attached makes use of this. I didn't notice > previously. > >> Based on the feedback from v2, I’ve refactored the mem_ops code to >> handle these cases more cleanly, which required updating the ECPRI >> clocks as well. > > Please split the changes into: > > 1. add new struct fields, explaining the reason for the change > 2. update the ECPRI driver (so that when the next patch lands the func > isn't broken) > 3. use the new fields in clk-branch.c now that all users (just qdu1000) have > the required data filled in > > So that the platform remains functional at any point in time (which is a > policy because it impacts bisect) > > 1&2 can be potentially squashed, potayto/potahto > Thanks Konrad, will update the changes accordingly. -- Thanks, Taniya Das