Re: [PATCH v2 2/2] interconnect: qcom: Add interconnect provider driver for SM8750

[Melody Olvera <quic_molvera@quicinc.com>]

On 12/3/2024 3:51 AM, Dmitry Baryshkov wrote:
> On Tue, 3 Dec 2024 at 00:04, Melody Olvera <quic_molvera@quicinc.com> wrote:
>>
>>
>> On 11/18/2024 10:01 AM, Melody Olvera wrote:
>>>
>>> On 11/15/2024 7:27 AM, Dmitry Baryshkov wrote:
>>>> On Mon, Nov 11, 2024 at 04:30:17PM -0800, Melody Olvera wrote:
>>>>> From: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com>
>>>>>
>>>>> Introduce SM8750 interconnect provider driver using the interconnect
>>>>> framework.
>>>>>
>>>>> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com>
>>>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>>>> ---
>>>>>    drivers/interconnect/qcom/Kconfig  |    9 +
>>>>>    drivers/interconnect/qcom/Makefile |    2 +
>>>>>    drivers/interconnect/qcom/sm8750.c | 1585
>>>>> ++++++++++++++++++++++++++++
>>>>>    drivers/interconnect/qcom/sm8750.h |  132 +++
>>>>>    4 files changed, 1728 insertions(+)
>>>>>    create mode 100644 drivers/interconnect/qcom/sm8750.c
>>>>>    create mode 100644 drivers/interconnect/qcom/sm8750.h
>>>>>
>>>>> diff --git a/drivers/interconnect/qcom/Kconfig
>>>>> b/drivers/interconnect/qcom/Kconfig
>>>>> index 362fb9b0a198..1219f4f23d40 100644
>>>>> --- a/drivers/interconnect/qcom/Kconfig
>>>>> +++ b/drivers/interconnect/qcom/Kconfig
>>>>> @@ -337,6 +337,15 @@ config INTERCONNECT_QCOM_SM8650
>>>>>          This is a driver for the Qualcomm Network-on-Chip on
>>>>> SM8650-based
>>>>>          platforms.
>>>>>    +config INTERCONNECT_QCOM_SM8750
>>>>> +    tristate "Qualcomm SM8750 interconnect driver"
>>>>> +    depends on INTERCONNECT_QCOM_RPMH_POSSIBLE
>>>>> +    select INTERCONNECT_QCOM_RPMH
>>>>> +    select INTERCONNECT_QCOM_BCM_VOTER
>>>>> +    help
>>>>> +      This is a driver for the Qualcomm Network-on-Chip on
>>>>> SM8750-based
>>>>> +      platforms.
>>>>> +
>>>>>    config INTERCONNECT_QCOM_X1E80100
>>>>>        tristate "Qualcomm X1E80100 interconnect driver"
>>>>>        depends on INTERCONNECT_QCOM_RPMH_POSSIBLE
>>>>> diff --git a/drivers/interconnect/qcom/Makefile
>>>>> b/drivers/interconnect/qcom/Makefile
>>>>> index 9997728c02bf..7887b1e8d69b 100644
>>>>> --- a/drivers/interconnect/qcom/Makefile
>>>>> +++ b/drivers/interconnect/qcom/Makefile
>>>>> @@ -40,6 +40,7 @@ qnoc-sm8350-objs            := sm8350.o
>>>>>    qnoc-sm8450-objs            := sm8450.o
>>>>>    qnoc-sm8550-objs            := sm8550.o
>>>>>    qnoc-sm8650-objs            := sm8650.o
>>>>> +qnoc-sm8750-objs            := sm8750.o
>>>>>    qnoc-x1e80100-objs            := x1e80100.o
>>>>>    icc-smd-rpm-objs            := smd-rpm.o icc-rpm.o icc-rpm-clocks.o
>>>>>    @@ -80,5 +81,6 @@ obj-$(CONFIG_INTERCONNECT_QCOM_SM8350) +=
>>>>> qnoc-sm8350.o
>>>>>    obj-$(CONFIG_INTERCONNECT_QCOM_SM8450) += qnoc-sm8450.o
>>>>>    obj-$(CONFIG_INTERCONNECT_QCOM_SM8550) += qnoc-sm8550.o
>>>>>    obj-$(CONFIG_INTERCONNECT_QCOM_SM8650) += qnoc-sm8650.o
>>>>> +obj-$(CONFIG_INTERCONNECT_QCOM_SM8750) += qnoc-sm8750.o
>>>>>    obj-$(CONFIG_INTERCONNECT_QCOM_X1E80100) += qnoc-x1e80100.o
>>>>>    obj-$(CONFIG_INTERCONNECT_QCOM_SMD_RPM) += icc-smd-rpm.o
>>>>> diff --git a/drivers/interconnect/qcom/sm8750.c
>>>>> b/drivers/interconnect/qcom/sm8750.c
>>>>> new file mode 100644
>>>>> index 000000000000..bc72954d54ff
>>>>> --- /dev/null
>>>>> +++ b/drivers/interconnect/qcom/sm8750.c
>>>>> @@ -0,0 +1,1585 @@
>>>>> +// SPDX-License-Identifier: GPL-2.0-only
>>>>> +/*
>>>>> + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights
>>>>> reserved.
>>>>> + *
>>>>> + */
>>>>> +
>>>>> +#include <linux/device.h>
>>>>> +#include <linux/interconnect.h>
>>>>> +#include <linux/interconnect-provider.h>
>>>>> +#include <linux/module.h>
>>>>> +#include <linux/of_platform.h>
>>>>> +#include <dt-bindings/interconnect/qcom,sm8750-rpmh.h>
>>>>> +
>>>>> +#include "bcm-voter.h"
>>>>> +#include "icc-rpmh.h"
>>>>> +#include "sm8750.h"
>>>> Nit: please merge sm8750.h here, there is no need to have a separate
>>>> header, there are no other users.
>>> Ack.
>>>
>>>> Also, is there QoS support? I see no qcom_icc_qosbox entries.
>>> Unsure; will let Raviteja comment.
>>>
>> Spoke w Raviteja; looks like he wants to do this later.
> Will that cause bindings changes?

 From what I can tell, no.