From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexey Minnekhanov <alexeymin@postmarketos.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Craig Tatlor <ctatlor97@gmail.com>,
Taniya Das <quic_tdas@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: clock: gcc-sdm660: Add missing SDCC resets
Date: Thu, 30 Jan 2025 13:06:27 +0100 [thread overview]
Message-ID: <42879d73-e983-4246-83cd-a5bd55b02d32@kernel.org> (raw)
In-Reply-To: <6312f316-f407-494b-91c4-04d761396e22@postmarketos.org>
On 30/01/2025 12:29, Alexey Minnekhanov wrote:
> On 1/30/25 11:35 AM, Krzysztof Kozlowski wrote:
>> On Thu, Jan 30, 2025 at 12:23:25AM +0300, Alexey Minnekhanov wrote:
>>> Add resets for eMMC/SD card blocks that were missed during initial
>>> driver submission.
>>>
>>> Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
>>> Fixes: f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for SDM660")
>>
>> Your SoB is always the last tag, but repeating what I asked during
>> previous review - what sort of bug is here? Missing feature is not a bug
>> per se.
>>
>> Best regards,
>> Krzysztof
>>
>
> I was hesitant about adding fixes tag myself, because there is no any
> user-observable bug being fixed here. In fact the behavior is unchanged,
> eMMC and SD worked fine before this and still work fine with this patch.
> From Linux side this is mostly for consistency with other
> younger/sibling SoCs, like MSM8998 & 8996 all have these resets
> specified. This will probably be much more useful for U-Boot port.
>
> Perhaps fixes tag should be removed completely?
Yes, drop the Fixes tag.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-01-30 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 21:23 [PATCH v2 1/3] dt-bindings: clock: gcc-sdm660: Add missing SDCC resets Alexey Minnekhanov
2025-01-29 21:23 ` [PATCH v2 2/3] clk: qcom: gcc-sdm660: Add missing SDCC block resets Alexey Minnekhanov
2025-01-31 12:56 ` Konrad Dybcio
2025-01-29 21:23 ` [PATCH v2 3/3] arm64: dts: qcom: sdm630: Add missing resets to mmc blocks Alexey Minnekhanov
2025-01-31 12:55 ` Konrad Dybcio
2025-01-30 8:35 ` [PATCH v2 1/3] dt-bindings: clock: gcc-sdm660: Add missing SDCC resets Krzysztof Kozlowski
2025-01-30 11:29 ` Alexey Minnekhanov
2025-01-30 12:06 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42879d73-e983-4246-83cd-a5bd55b02d32@kernel.org \
--to=krzk@kernel.org \
--cc=alexeymin@postmarketos.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=ctatlor97@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox