From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: "Kandpal, Suraj" <suraj.kandpal@intel.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"freedreno@lists.freedesktop.org"
<freedreno@lists.freedesktop.org>
Subject: Re: [PATCH v7 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters
Date: Wed, 17 May 2023 15:12:03 +0300 [thread overview]
Message-ID: <42ee22fe-929c-9e62-6525-e4e318d3cae6@linaro.org> (raw)
In-Reply-To: <SN7PR11MB67506715FEA682D6FC61C073E37E9@SN7PR11MB6750.namprd11.prod.outlook.com>
On 17/05/2023 13:42, Kandpal, Suraj wrote:
>>
>> The array of rc_parameters contains a mixture of parameters from DSC 1.1
>> and DSC 1.2 standards. Split these tow configuration arrays in preparation to
>> adding more configuration data.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> LGTM.
>
> Reviewed-by: Suraj Kandpal
Just to note, this is not a proper R-B tag, it doesn't contain your email:
313685b15740 drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters
-:12: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Suraj Kandpal'
#12:
Reviewed-by: Suraj Kandpal
total: 1 errors, 0 warnings, 0 checks, 239 lines checked
>
>> ---
>> drivers/gpu/drm/display/drm_dsc_helper.c | 139 ++++++++++++++++++----
>> drivers/gpu/drm/i915/display/intel_vdsc.c | 10 +-
>> include/drm/display/drm_dsc_helper.h | 7 +-
>> 3 files changed, 129 insertions(+), 27 deletions(-)
[skipped the patch]
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-05-17 12:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 10:27 [PATCH v7 0/8] drm/i915: move DSC RC tables to drm_dsc_helper.c Dmitry Baryshkov
2023-05-17 10:28 ` [PATCH v7 1/8] drm/i915/dsc: change DSC param tables to follow the DSC model Dmitry Baryshkov
2023-05-17 10:28 ` [PATCH v7 2/8] drm/i915/dsc: move rc_buf_thresh values to common helper Dmitry Baryshkov
2023-05-17 10:28 ` [PATCH v7 3/8] drm/i915/dsc: move DSC tables to DRM DSC helper Dmitry Baryshkov
2023-05-17 10:28 ` [PATCH v7 4/8] drm/i915/dsc: stop using interim structure for calculated params Dmitry Baryshkov
2023-05-17 10:28 ` [PATCH v7 5/8] drm/display/dsc: use flat array for rc_parameters lookup Dmitry Baryshkov
2023-05-17 10:28 ` [PATCH v7 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters Dmitry Baryshkov
2023-05-17 10:42 ` Kandpal, Suraj
2023-05-17 12:12 ` Dmitry Baryshkov [this message]
2023-05-19 10:46 ` Kandpal, Suraj
2023-05-17 10:28 ` [PATCH v7 7/8] drm/display/dsc: include the rest of pre-SCR parameters Dmitry Baryshkov
2023-05-17 10:28 ` [PATCH v7 8/8] drm/display/dsc: add YCbCr 4:2:2 and 4:2:0 RC parameters Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42ee22fe-929c-9e62-6525-e4e318d3cae6@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=rodrigo.vivi@intel.com \
--cc=sean@poorly.run \
--cc=suraj.kandpal@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox