From: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
To: "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Agustin Vega-Frias" <agustinv@codeaurora.org>,
"Marc Zyngier" <maz@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Markus Schneider-Pargmann <msp@baylibre.com>
Subject: Re: [PATCH] irqchip/qcom-irq-combiner: Rename driver struct to end in _driver
Date: Mon, 30 Jun 2025 12:31:16 -0600 [thread overview]
Message-ID: <4396deb6-049a-4649-afbc-fd20986b118a@oss.qualcomm.com> (raw)
In-Reply-To: <563db91f-3080-4a45-ba0d-04f415ed90d9@oss.qualcomm.com>
On 6/30/2025 11:25 AM, Konrad Dybcio wrote:
>
>
> On 30-Jun-25 19:23, Uwe Kleine-König wrote:
>> The modpost section mismatch checks are more lax for objects that have a
>> name that ends in "_probe". This is not justified here though, so rename
>> the driver struct according to the usual naming choice.
>>
>> Note that this change indeed results in modpost identifying a section
>> mismatch in this driver. This is not a false positive and should be
>> fixed by either converting the driver to use platform_driver_probe() or
>> by dropping __init from the .probe() callback. This problem was
>> introduced in commit f20cc9b00c7b ("irqchip/qcom: Add IRQ combiner
>> driver").
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
>> ---
>> Hello,
>>
>> I don't know if platform_driver_probe() works here, it might happen that
>> the driver is probed before the matching device appears. As I don't have
>> a machine with such a device I won't create a patch fixing the issue,
>> but if you have questions don't hesitate to ask.
>>
>> Please consider this patch as a bug report and better only apply it when
>> the issue is addressed to not result in build regressions.
>
> +Jeff is probably the last person on Earth that officially has one
We are talking about QDF2400 here?
-Jeff
next prev parent reply other threads:[~2025-06-30 18:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 17:23 [PATCH] irqchip/qcom-irq-combiner: Rename driver struct to end in _driver Uwe Kleine-König
2025-06-30 17:25 ` Konrad Dybcio
2025-06-30 18:31 ` Jeff Hugo [this message]
2025-07-01 7:40 ` Konrad Dybcio
2025-07-01 14:34 ` Jeff Hugo
2025-06-30 18:01 ` Thomas Gleixner
2025-06-30 19:40 ` Uwe Kleine-König
2025-07-01 9:01 ` Thomas Gleixner
2025-07-01 13:58 ` Uwe Kleine-König
2025-07-01 14:24 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4396deb6-049a-4649-afbc-fd20986b118a@oss.qualcomm.com \
--to=jeff.hugo@oss.qualcomm.com \
--cc=agustinv@codeaurora.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=msp@baylibre.com \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox