Re: [PATCH 2/2] clk: qcom: Add support for GPUCC and GXCLK for Glymur

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 1/27/26 12:31 PM, Konrad Dybcio wrote:
> On 1/27/26 8:15 AM, Taniya Das wrote:
>> Support the graphics clock controller for Glymur for Graphics SW
>> driver to use the clocks. GXCLKCTL (Graphics GX Clock Controller) is a
>> block dedicated to managing clocks for the GPU subsystem on GX power
>> domain. The GX clock controller driver manages only the GX GDSC and the
>> rest of the resources of the controller are managed by the firmware.
>>
>> Update the compatible for Graphics GX Clock Controller for Glymur as the
>> GX clock controller is a reuse of the Kaanapali driver.
>>
>> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
>> ---
> 
> [...]
> 
>> diff --git a/drivers/clk/qcom/gxclkctl-kaanapali.c b/drivers/clk/qcom/gxclkctl-kaanapali.c
>> index c209ce5fe4f003aabefd4421eb4f5662e257912a..3ee512f34967f1b165fdc5481bb28e1dadee133d 100644
>> --- a/drivers/clk/qcom/gxclkctl-kaanapali.c
>> +++ b/drivers/clk/qcom/gxclkctl-kaanapali.c
>> @@ -52,6 +52,7 @@ static const struct qcom_cc_desc gx_clkctl_kaanapali_desc = {
>>  };
>>  
>>  static const struct of_device_id gx_clkctl_kaanapali_match_table[] = {
>> +	{ .compatible = "qcom,glymur-gxclkctl" },
>>  	{ .compatible = "qcom,kaanapali-gxclkctl" },
> 
> I'm not sure this is correct - there's an extra GDSC on one of them

After an internal discussion, we figured it's not managed by Linux
and it's not necessary to represent it, so this simplified approach
is perfectly fine and can be split up & extended if that need ever
arises

Konrad