From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jinlong Mao <quic_jinlmao@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Tao Zhang <quic_taozha@quicinc.com>,
coresight@lists.linaro.org
Subject: Re: [PATCH] arm64: dts: qcom: Add coresight nodes for sm8450
Date: Wed, 20 Dec 2023 16:50:05 +0100 [thread overview]
Message-ID: <440e2ad2-ecc5-4888-9923-a172d94c710d@linaro.org> (raw)
In-Reply-To: <98407ed5-5e0c-4bee-be4c-70b3d8972823@quicinc.com>
On 20/12/2023 14:40, Jinlong Mao wrote:
>
>
> On 12/20/2023 9:21 PM, Krzysztof Kozlowski wrote:
>> On 20/12/2023 14:07, Jinlong Mao wrote:
>>>
>>>
>>> On 12/20/2023 8:46 PM, Krzysztof Kozlowski wrote:
>>>> On 20/12/2023 13:40, Mao Jinlong wrote:
>>>>> Add coresight components on Qualcomm SM8450 Soc. The components include
>>>>> TMC ETF/ETR, ETE, STM, TPDM, CTI.
>>>>>
>>>>> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
>>>>> ---
>>>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 742 +++++++++++++++++++++++++++
>>>>> 1 file changed, 742 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>> index 1783fa78bdbc..112b5a069c94 100644
>>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>> @@ -285,6 +285,192 @@ CLUSTER_SLEEP_1: cluster-sleep-1 {
>>>>> };
>>>>> };
>>>>>
>>>>> + ete0 {
>>>>
>>>> ete-0
>>> Thanks for the review.
>>>
>>> In arm,embedded-trace-extension.yaml, the node name pattern is
>>> "^ete([0-9a-f]+)$".
>>
>> I don't understand why this binding requires ete name. It's not like it
>> is a generic name worth preserving. Also, the recommended suffix for
>> names is with '-'.
>>
> The number in the ete name should be the same as the number of the CPU.
My question was why "ete" is needed.
> So we can know which CPU this ete belongs to from the name.
Wait, what? Why? Node names should not be for that.
>
> I will update the binding in arm,embedded-trace-extension.yaml.
No, wait, please finish this discussion first. You need to give people
chance to respond...
Best regards,
Krzysztof
prev parent reply other threads:[~2023-12-20 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 12:40 [PATCH] arm64: dts: qcom: Add coresight nodes for sm8450 Mao Jinlong
2023-12-20 12:46 ` Krzysztof Kozlowski
2023-12-20 13:07 ` Jinlong Mao
2023-12-20 13:21 ` Krzysztof Kozlowski
2023-12-20 13:40 ` Jinlong Mao
2023-12-20 15:50 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=440e2ad2-ecc5-4888-9923-a172d94c710d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox