From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE705128829 for ; Wed, 8 May 2024 16:12:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715184776; cv=none; b=mdspICve1ZwNjEYXb/f+OTZzGcgpfpYNKTr9pcfYfuDHSptWWM/SRpKWrge9gYddZMARkmlmnPWe3c7UliO3KmgbG4XqpnhGgH2ci5wOgq+Z0PIbqA21dt3vi8gN5NAfFyv2OE8iKnqndvxhK67fCj4uMPVo8cDeSesh0yq8BPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715184776; c=relaxed/simple; bh=3RC/slltpYapY2F0z6uYYs46/YRPjHS6+iJKdyjPMSI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WSLb24PhLC/08iEoKLktLhesC7ifbhbWxUpqKCM7/BiSrgQwroqPwSF7s1LIgkP2P4E9gxZku7+CU6FUxGarlqkjGhJRY/x+gIyuNHwRPPCwpQRyA/4Kl50aC/Tvj8X9oawU6dcPQ/0wcBYTur28/AxqQN4vXmk4OlwCobM/elk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jw4txY8l; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jw4txY8l" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-41dc9f98e8dso5996465e9.1 for ; Wed, 08 May 2024 09:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715184773; x=1715789573; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4GjzdAdHEKtNKnAx1lGW3dqaD5snc+8WTy5ik2iGruw=; b=jw4txY8lnQNVRM41kVyo00Z0nAwO/j6Dhyjv1JktTUcmmA/j6YyC5hWVI98gzIzSra offBNSVRC1N8MwLFCBaARTuBjPmu2qZgqBHbNQp2wKMOqOzJm++cj/NPH2UIPpukachN 2h9mm7i8fupyJk/il8SXSGuP0Tz4gJcdgvU5z2PlBxlpEr6Z1L0hbxsxSkP+OWQmSiTD U4fVrf67hMHsSG9iH+no3WWxWFgbE7/udcw2LfphO8UUVLgLFtiUea73kNQ5naT0IzhB eJUD/RYfmVCFV2zvXUrEuNrr09Txcu/W+Ja5Tva5/vVOMMncTi8v/3HzW+v6nplnrBJq nIbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715184773; x=1715789573; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4GjzdAdHEKtNKnAx1lGW3dqaD5snc+8WTy5ik2iGruw=; b=DELAhtu8KCVqW9jpnZdhrBmyNWyHUUPv8cVXT07QmzWy3BdQ3CMoJ5TSIxfPnJX7ND HV3k1M9zzSHgIv9wA9Xs5hKkmbxOkzozLmY2RcuxNO7zgmMSXFbrcqYIcOZfGqnUSQou W4sE17P/n8WIM5jVjpYKnueVrmJpCSVXNhIrZsGuOnLaKRST8GDzTPwr7jHl7a1/WnFg dBHcZszhOvfFIK5V7wRv6s66oPAFhWdGtrFO+GkiE/W2H0iAhzJNRi1G7B59xMnIcTzO rTUN9ltRwuqQTrV1Ven52CMXb9xhvLc+zO88jMjl14HZWVtDrSvMcJFG+YzYGoK4W+Jm lO/Q== X-Forwarded-Encrypted: i=1; AJvYcCXAGH+WkzHb6SE2FW0d1JKVGek7BNADwHXGX9sYL7/UAhUms5OexhEwfD/42Fw4MmqGV98pAE2l/tdUNVIBhyg14gkO9zbbLvmFUFmpMQ== X-Gm-Message-State: AOJu0YzFOr7LPM2XO/IhXnKj9t1uaZP6cBq5q0R9XiqLLAYJxBfqqF/i qqo+XCu2e9cip1WrXMBYV1/QVYjinhEBbqb4eAalPFWqbsFEIRsew/jZkT7kvd4= X-Google-Smtp-Source: AGHT+IH5Yksnpu8AA/SPMXll9db6J8MO+PCbYpEJpY3+2AVAvGf2IFN2hUFiazwk32/adRLFStXFTQ== X-Received: by 2002:a05:600c:3585:b0:418:2ab6:7123 with SMTP id 5b1f17b1804b1-41fbcc5f63bmr1147015e9.10.1715184773147; Wed, 08 May 2024 09:12:53 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id g18-20020a5d5412000000b00346bda84bf9sm15725249wrv.78.2024.05.08.09.12.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 May 2024 09:12:52 -0700 (PDT) Message-ID: <4468becb-dc03-4832-aa03-5f597023fcb2@linaro.org> Date: Wed, 8 May 2024 17:12:51 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/13] mfd: pm8008: deassert reset on probe To: Johan Hovold , Lee Jones , Mark Brown , Linus Walleij , Bjorn Andersson Cc: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Das Srinagesh , Satya Priya , Stephen Boyd , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20240506150830.23709-1-johan+linaro@kernel.org> <20240506150830.23709-4-johan+linaro@kernel.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240506150830.23709-4-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/05/2024 16:08, Johan Hovold wrote: > Request and deassert any (optional) reset gpio during probe in case it > has been left asserted by the boot firmware. > > Note the reset line is not asserted to avoid reverting to the default > I2C address in case the firmware has configured an alternate address. > > Signed-off-by: Johan Hovold > --- > drivers/mfd/qcom-pm8008.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c > index d53c987b0d49..d0f190c2ea2b 100644 > --- a/drivers/mfd/qcom-pm8008.c > +++ b/drivers/mfd/qcom-pm8008.c > @@ -4,6 +4,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -158,6 +159,7 @@ static struct regmap_config qcom_mfd_regmap_cfg = { > static int pm8008_probe(struct i2c_client *client) > { > struct regmap_irq_chip_data *irq_data; > + struct gpio_desc *reset; > int rc; > struct device *dev; > struct regmap *regmap; > @@ -169,6 +171,10 @@ static int pm8008_probe(struct i2c_client *client) > > i2c_set_clientdata(client, regmap); > > + reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); > + if (IS_ERR(reset)) > + return PTR_ERR(reset); > + > if (of_property_read_bool(dev->of_node, "interrupt-controller")) { > rc = devm_regmap_add_irq_chip(dev, regmap, client->irq, > IRQF_SHARED, 0, &pm8008_irq_chip, &irq_data); So not resetting is fine and I understand you want to retain the address given by the firmware, I think that's the right thing to do. You can add this now Tested-by: Bryan O'Donoghue In addition to adding a small delay suggested by Andy - a few microseconds pick a number, I think you should verify the chip is out of reset as we would do with many other i2c devices. A common pattern with i2c devices is take the device out of reset then read back an identity register as a smoke test. Take drivers/media/i2c/ov8856.c::ov8856_identify_module() as an example. In this case, suggest reading REVID_PERPH_TYPE @ 0x104 and REVID_PERPH_SUBTYPE @ 0x105 REVID_PERPH_TYPE @ 0x104 == 0x51 (PMIC) REVID_PERPH_SUBYTE @ 0x105 == 0x2C (PM8008) You can then add my Reviewed-by: Bryan O'Donoghue --- bod