From: Devi Priya <quic_devipriy@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<thierry.reding@gmail.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <ndesaulniers@google.com>,
<trix@redhat.com>, <baruch@tkos.co.il>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <llvm@lists.linux.dev>
Cc: <linux-pwm@vger.kernel.org>, <u.kleine-koenig@pengutronix.de>,
<nathan@kernel.org>
Subject: Re: [PATCH V12 3/3] arm64: dts: ipq6018: add pwm node
Date: Sat, 30 Sep 2023 22:43:02 +0530 [thread overview]
Message-ID: <446f4c92-ca04-d325-4a5f-140b9bcdbd19@quicinc.com> (raw)
In-Reply-To: <c673ba8e-76e5-4a23-b395-f61ec59d9bc7@linaro.org>
On 9/30/2023 9:05 PM, Krzysztof Kozlowski wrote:
> On 29/09/2023 13:47, Devi Priya wrote:
>>
>>
>> On 9/25/2023 12:29 PM, Devi Priya wrote:
>>> Describe the PWM block on IPQ6018.
>>>
>>> The PWM is in the TCSR area. Make &tcsr "simple-mfd" compatible, and add
>>> &pwm as child of &tcsr.
>>>
>>> Add also ipq6018 specific compatible string.
>>>
>>> Co-developed-by: Baruch Siach <baruch.siach@siklu.com>
>>> Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
>>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>
>>> ---
>>> v12:
>>>
>>> No change
>>>
>>> v11:
>>>
>>> No change
>>>
>>> v10:
>>>
>>> No change
>>>
>>> v9:
>>>
>>> Add 'ranges' property (Rob)
>>>
>>> v8:
>>>
>>> Add size cell to 'reg' (Rob)
>>>
>>> v7:
>>>
>>> Use 'reg' instead of 'offset' (Rob)
>>>
>>> Add qcom,tcsr-ipq6018 (Rob)
>>>
>>> Drop clock-names (Bjorn)
>>>
>>> v6:
>>>
>>> Make the PWM node child of TCSR (Rob Herring)
>>>
>>> Add assigned-clocks/assigned-clock-rates (Uwe Kleine-König)
>>>
>>> v5: Use qcom,pwm-regs for TCSR phandle instead of direct regs
>>>
>>> v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring)
>>>
>>> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 15 ++++++++++++++-
>>> 1 file changed, 14 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>>> index 47b8b1d6730a..cadd2c583526 100644
>>> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>>> @@ -398,8 +398,21 @@ tcsr_mutex: hwlock@1905000 {
>>> };
>>>
>>> tcsr: syscon@1937000 {
>>> - compatible = "qcom,tcsr-ipq6018", "syscon";
>>> + compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd";
>>> reg = <0x0 0x01937000 0x0 0x21000>;
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + ranges = <0x0 0x0 0x01937000 0x21000>;
>>> +
>> Hi Krzysztof,
>> Referring to
>> https://lore.kernel.org/all/20220909091056.128949-1-krzysztof.kozlowski@linaro.org/,
>> it seems that the TCSR block should
>> not have any child nodes. Could you pls provide your suggestions on pwm
>> being added as the child node?
>
> If you are sure that TCSR contains PWM and all registers are there, then
> feel free to add proper binding. Sending untested patch is not the way
> to go.
Sure, okay
Thanks,
Devi Priya
>
> Best regards,
> Krzysztof
>
prev parent reply other threads:[~2023-09-30 17:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 6:59 [PATCH V12 0/3] Add PWM support for IPQ chipsets Devi Priya
2023-09-25 6:59 ` [PATCH V12 1/3] pwm: driver for qualcomm ipq6018 pwm block Devi Priya
2023-09-25 6:59 ` [PATCH V12 2/3] dt-bindings: pwm: add IPQ6018 binding Devi Priya
2023-09-25 7:11 ` Krzysztof Kozlowski
2023-09-29 7:55 ` Devi Priya
2023-09-29 8:56 ` Devi Priya
2023-09-30 15:32 ` Krzysztof Kozlowski
2023-09-30 17:12 ` Devi Priya
2023-09-25 7:26 ` Rob Herring
2023-09-25 6:59 ` [PATCH V12 3/3] arm64: dts: ipq6018: add pwm node Devi Priya
2023-09-25 7:13 ` Krzysztof Kozlowski
2023-09-29 11:47 ` Devi Priya
2023-09-30 15:35 ` Krzysztof Kozlowski
2023-09-30 17:13 ` Devi Priya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446f4c92-ca04-d325-4a5f-140b9bcdbd19@quicinc.com \
--to=quic_devipriy@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=baruch@tkos.co.il \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=trix@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox