From: Jie Gan <jie.gan@oss.qualcomm.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
James Clark <james.clark@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Mao Jinlong <jinlong.mao@oss.qualcomm.com>,
Konrad Dybcio <konradybcio@kernel.org>,
devicetree@vger.kernel.org,
Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: Re: [PATCH v8 5/8] dt-bindings: arm: add an interrupt property for Coresight CTCU
Date: Thu, 11 Dec 2025 15:35:32 +0800 [thread overview]
Message-ID: <44b8df0e-2786-420b-9402-ee19f4cda0d2@oss.qualcomm.com> (raw)
In-Reply-To: <176543802198.60924.10267408914731981420.robh@kernel.org>
On 12/11/2025 3:27 PM, Rob Herring (Arm) wrote:
>
> On Thu, 11 Dec 2025 14:10:44 +0800, Jie Gan wrote:
>> Add an interrupt property to CTCU device. The interrupt will be triggered
>> when the data size in the ETR buffer exceeds the threshold of the
>> BYTECNTRVAL register. Programming a threshold in the BYTECNTRVAL register
>> of CTCU device will enable the interrupt.
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Reviewed-by: Mike Leach <mike.leach@linaro.org>
>> Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
>> ---
>> .../devicetree/bindings/arm/qcom,coresight-ctcu.yaml | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Error: Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.example.dts:36.31-32 syntax error
> FATAL ERROR: Unable to parse input tree
Will fix it in next version.
Thanks,
Jie
> make[2]: *** [scripts/Makefile.dtbs:141: Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1559: dt_binding_check] Error 2
> make: *** [Makefile:248: __sub-make] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.kernel.org/project/devicetree/patch/20251211-enable-byte-cntr-for-ctcu-v8-5-3e12ff313191@oss.qualcomm.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
next prev parent reply other threads:[~2025-12-11 7:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 6:10 [PATCH v8 0/8] coresight: ctcu: Enable byte-cntr function for TMC ETR Jie Gan
2025-12-11 6:10 ` [PATCH v8 1/8] coresight: core: Refactoring ctcu_get_active_port and make it generic Jie Gan
2025-12-11 6:10 ` [PATCH v8 2/8] coresight: core: add a new API to retrieve the helper device Jie Gan
2025-12-13 12:38 ` kernel test robot
2025-12-18 17:50 ` Suzuki K Poulose
2025-12-19 9:24 ` Jie Gan
2025-12-11 6:10 ` [PATCH v8 3/8] coresight: tmc: add create/clean functions for etr_buf_list Jie Gan
2025-12-11 6:10 ` [PATCH v8 4/8] coresight: tmc: Introduce sysfs_read_ops to wrap sysfs read operations Jie Gan
2025-12-11 6:10 ` [PATCH v8 5/8] dt-bindings: arm: add an interrupt property for Coresight CTCU Jie Gan
2025-12-11 7:27 ` Rob Herring (Arm)
2025-12-11 7:35 ` Jie Gan [this message]
2025-12-11 13:37 ` Rob Herring
2025-12-12 1:12 ` Jie Gan
2025-12-18 10:17 ` Krzysztof Kozlowski
2025-12-18 23:19 ` Suzuki K Poulose
2025-12-19 2:05 ` Jie Gan
2025-12-19 9:54 ` Suzuki K Poulose
2025-12-22 6:58 ` Jie Gan
2025-12-22 9:17 ` Jie Gan
2025-12-11 6:10 ` [PATCH v8 6/8] coresight: ctcu: enable byte-cntr for TMC ETR devices Jie Gan
2025-12-11 6:10 ` [PATCH v8 7/8] coresight: tmc: integrate byte-cntr's read_ops with sysfs file_ops Jie Gan
2025-12-11 6:10 ` [PATCH v8 8/8] arm64: dts: qcom: lemans: Add interrupts to CTCU device Jie Gan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44b8df0e-2786-420b-9402-ee19f4cda0d2@oss.qualcomm.com \
--to=jie.gan@oss.qualcomm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=jinlong.mao@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei.zhang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox