From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE3FEB64D9 for ; Thu, 15 Jun 2023 10:12:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241252AbjFOKMa (ORCPT ); Thu, 15 Jun 2023 06:12:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230130AbjFOKM3 (ORCPT ); Thu, 15 Jun 2023 06:12:29 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31A1C271C for ; Thu, 15 Jun 2023 03:12:27 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-30fa23e106bso4795200f8f.3 for ; Thu, 15 Jun 2023 03:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686823945; x=1689415945; h=content-transfer-encoding:in-reply-to:subject:organization :references:cc:to:content-language:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=zz9EX+Ta4PloLk34RJ2hnXK/x9oTdPVOw0dFQbZy70I=; b=frDkKppf7lZoIiLPcx/27B7RgHBKXqgtzlP/rh77BLFE3SROa9LxxSjX0hYVsi93Eh pihQ2Zb5eyq7gMv33tbGJsRj+Qug3TvDMAJx+xdvCazTNVcRub4Ku3T2MqOG/t9CJ4VA BGlhoRaR5ctRw9tEmpJZ2DsMImtcr2nxcf6TtacCV71di92Q2LJrLGygNFVjKwT2SuCf 2AMISPslSoznjAM6va9T7YngkUzSBuU6lJUPjNsasWZUiKvG6RFDdYYIxyDVbOOE86f0 VowdSZaUy1Yp2rGYAOwJLEtpaJ+JYGdGN0MqOMnuQxxPUpY4ckofRlcherP+O8FWZeYw Vy1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686823945; x=1689415945; h=content-transfer-encoding:in-reply-to:subject:organization :references:cc:to:content-language:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zz9EX+Ta4PloLk34RJ2hnXK/x9oTdPVOw0dFQbZy70I=; b=EYYbqo2+wwObrHF0lQbNzq/50X3dju3tMq3aETgu8fMs5E9lUlGun/y7jJlBCSRIBt /MLOyXdWR0X3w9ipAVjQAxmORZ5fHkBARx16mzCXOm+RP07xwj2SBi/sB179sDw036AA ZLBk9ZC4wzY4GY7PdlF0LQNB7XCRcFDxW4y6+Ry/flz9dWdmGxeuVwmCSQc2hZqvslM7 d35vVKOLdVEizVCz/JSradAXameYqy8XKXlP3dJieciabiZKRSKdxvWOiZNv72T4kELG hlUcdZ9IkNBG8wOpsWsIZMWwj8zMuxnRfwAZvNb5vLLy6RVqfgysXye7AqJUX+blemSM OqzQ== X-Gm-Message-State: AC+VfDz5WijIcwsSw4qRMsT8rE4nJv8F1NE/35/ZnJyzmdXNvE1fWnYs MCMXTL6tejWlS3ujtgMsd6pn8Q== X-Google-Smtp-Source: ACHHUZ6cP3h9pbkk+CWbJrI5Giw2RTOJdpJN7rRK57+WSwcGuPKNLwcuav9AADz+5ttsuona8PGN8g== X-Received: by 2002:a5d:6442:0:b0:311:d35:e23f with SMTP id d2-20020a5d6442000000b003110d35e23fmr2990366wrw.27.1686823945596; Thu, 15 Jun 2023 03:12:25 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:f60a:f5e3:7ae:6745? ([2a01:e0a:982:cbb0:f60a:f5e3:7ae:6745]) by smtp.gmail.com with ESMTPSA id f11-20020a5d50cb000000b0030fb828511csm13974283wrt.100.2023.06.15.03.12.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jun 2023 03:12:25 -0700 (PDT) Message-ID: <44ebcc5e-d424-0e5f-1384-19397a0c36ae@linaro.org> Date: Thu, 15 Jun 2023 12:12:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Content-Language: en-US To: Greg Kroah-Hartman Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Heikki Krogerus , Liam Girdwood , Mark Brown , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230601-topic-sm8x50-upstream-redriver-v3-0-988c560e2195@linaro.org> <20230601-topic-sm8x50-upstream-redriver-v3-2-988c560e2195@linaro.org> <2023061514-wager-iphone-cf71@gregkh> Organization: Linaro Developer Services Subject: Re: [PATCH v3 2/2] usb: typec: add support for the nb7vpq904m Type-C Linear Redriver In-Reply-To: <2023061514-wager-iphone-cf71@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 15/06/2023 11:47, Greg Kroah-Hartman wrote: > On Tue, Jun 13, 2023 at 04:50:08PM +0200, neil.armstrong@linaro.org wrote: >> From: Dmitry Baryshkov >> >> Add support for the ON Semiconductor NB7VPQ904M Type-C USB SuperSpeed >> and DisplayPort ALT Mode Linear Redriver chip found on some devices >> with a Type-C port. >> >> The redriver compensates ultra High-Speeed DisplayPort and USB >> Super Speed signal integrity losses mainly due to PCB & transmission >> cables. >> >> The redriver doesn't support SuperSpeed lines swapping, but >> can support Type-C SBU lines swapping. >> >> Signed-off-by: Dmitry Baryshkov >> Signed-off-by: Neil Armstrong >> --- >> drivers/usb/typec/mux/Kconfig | 8 + >> drivers/usb/typec/mux/Makefile | 1 + >> drivers/usb/typec/mux/nb7vpq904m.c | 529 +++++++++++++++++++++++++++++++++++++ >> 3 files changed, 538 insertions(+) > > I get the following build error on my system with this applied: > > CC [M] drivers/usb/typec/mux/nb7vpq904m.o > drivers/usb/typec/mux/nb7vpq904m.c: In function ‘nb7vpq904m_register_bridge’: > drivers/usb/typec/mux/nb7vpq904m.c:327:20: error: ‘struct drm_bridge’ has no member named ‘of_node’ > 327 | nb7->bridge.of_node = nb7->client->dev.of_node; > | ^ > > > What went wrong? DRM bridge attach should be protected by #ifdef CONFIG_OF aswell, I'll send a v4 with such fix. Thanks for the report, Neil > > thanks, > > greg k-h