From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 028DDECAAD3 for ; Wed, 31 Aug 2022 08:00:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231147AbiHaIAV (ORCPT ); Wed, 31 Aug 2022 04:00:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230443AbiHaIAT (ORCPT ); Wed, 31 Aug 2022 04:00:19 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF46429832 for ; Wed, 31 Aug 2022 01:00:16 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id p7so7682329lfu.3 for ; Wed, 31 Aug 2022 01:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=TkPqKp6gjbypc/OlKyeoW96EDJplATwLNsEk96PSFw0=; b=MTUOrhqogrdKBywcj6iVZObqLr9LtK41Fa7tE0ONyzIEGA2gcdnVAiT2IYoUGHFn42 JJ1txb5RAyot1y7RhYJj8ZnUvT5Ay54NqNP2/Ym4sq74dM3Wi8Jia9wLF/Q4kJ2vKxRc NHkmKWXkDpQStP34F8m0RpQwddMlHTTiiK+xbK33ib1PidqTVJ4kHIOWvirVoJomGTro qjCtjZCuQjQCjHd1z0dpUppi8pDeU+IfgM7HN7nThSVWAwpFO33yLuob8fB0DXElZ694 vpa/vvbV4AM6S2vsntcwqyIG++SFPpKDWcCgVlBySdtrzBXanjLX4utjh+eF/Ymem0CC SaMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=TkPqKp6gjbypc/OlKyeoW96EDJplATwLNsEk96PSFw0=; b=kQvLcFBWVsM9ObQK7dHGNZPN/UXbs7HiWXWp5hCYeX17gBSTd0Mj9Zc+mJlDV9h3Vw ZIvxg+KAu+/sDeKvsRFZnZ0NR2G1BnRRzTs3MiKd6gqIA2/QGyQ/Krs3YEvYxWNpqnG8 uVxPGhzuFgAYzZ5z99jWLxYbnjDjDjlQ1QEl67Apc5xXLjWfWpWPJVeXEaTRbDa/+PLr bJu2QPonNmqjP0Y7wLHXA5VGPHyGE29OggTEsDRUZQWEBmNvDbqCBLqq/knNTxBZyomV eFNBSmN+B9pEw0Z3cHyq0fjF9/S49p+DcN7TKQIXmg89sIkh/LYTVYwTxQ+YbrsKaB5i rLmA== X-Gm-Message-State: ACgBeo1FGIhVlyJkyz5AN8OFB3CZbHG44tOefUrGvYq0qBaVV3qOF2XE HCQGpuNHAZ3V2mPoClWP9aSPJklGyU3X9SUT X-Google-Smtp-Source: AA6agR7rMAk7sMgv9IVgAja5rZ33cvoPjgDiqkWUnA14ZXoUxzCPS+ETLO9oYpWGc8dYWm5yhYqxhA== X-Received: by 2002:a05:6512:20cd:b0:494:6f1f:216 with SMTP id u13-20020a05651220cd00b004946f1f0216mr3416426lfr.617.1661932815313; Wed, 31 Aug 2022 01:00:15 -0700 (PDT) Received: from [192.168.28.124] (balticom-73-99-134.balticom.lv. [109.73.99.134]) by smtp.gmail.com with ESMTPSA id f24-20020a2eb5b8000000b0025e5cd1620fsm1175777ljn.57.2022.08.31.01.00.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 01:00:14 -0700 (PDT) Message-ID: <453bce1e-e2d3-bf26-9954-774e1e267d82@linaro.org> Date: Wed, 31 Aug 2022 11:00:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [RESEND PATCH v2 1/5] dt-bindings: firmware: qcom-scm: Add "allow-multi-call" property Content-Language: en-US To: Guru Das Srinagesh , Andy Gross , Bjorn Andersson , Philipp Zabel , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: David Heidelberg , Robert Marko , Rajendra Nayak , Elliot Berman References: <1661898311-30126-1-git-send-email-quic_gurus@quicinc.com> <1661898311-30126-2-git-send-email-quic_gurus@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <1661898311-30126-2-git-send-email-quic_gurus@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 31/08/2022 01:25, Guru Das Srinagesh wrote: > For firmware that supports it, allow multiple SCM calls to be passed > down to it by removing the serialization lock in the SCM driver. > > This patch is based on this YAML conversion patch [1] that is in-flight > currently. > > [1] https://lore.kernel.org/lkml/20220708090431.30437-1-david@ixit.cz/ > > Signed-off-by: Guru Das Srinagesh Thank you for your patch. There is something to discuss/improve. If you make a resend, at least be sure you Cc proper people. Use scripts/get_maintainers.pl to CC all maintainers and relevant mailing lists. This was not Cced to device tree maintainers, therefore it has to be NAK-ed. > --- > Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > index 9fdeee0..e279fd2 100644 > --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > @@ -70,6 +70,11 @@ properties: > '#reset-cells': > const: 1 > > + allow-multi-call: > + description: > + Specify this flag to remove SCM call serialization. Need to ensure that > + the firmware being used supports this feature first. Missing vendor prefix, missing type. Isn't support for this obvious from compatible?\ Best regards, Krzysztof