From: Akash Asthana <akashast@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>, gregkh@linuxfoundation.org
Cc: linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
mgautam@codeaurora.org, bjorn.andersson@linaro.org
Subject: Re: [PATCH V2 2/2] tty: serial: qcom_geni_serial: Wakeup over UART RX
Date: Tue, 5 Nov 2019 15:26:47 +0530 [thread overview]
Message-ID: <454445c2-635e-83fa-50d8-b5e2a24dd466@codeaurora.org> (raw)
In-Reply-To: <5db70280.1c69fb81.c9f08.a848@mx.google.com>
On 10/28/2019 8:30 PM, Stephen Boyd wrote:
> Quoting Akash Asthana (2019-10-17 04:10:10)
>> On 10/16/2019 1:40 AM, Stephen Boyd wrote:
>>> Why can't we make this driver use runtime PM?
>> Currently there are no plans to use runtime PM as we are interested in
>> enabling wakeup irq as part of system suspend only.
>>
>>
> Does the wakeup irq code require runtime PM? I thought that any wake irq
> attached to a device is armed during system wide suspend and disabled on
> resume. See device_wakeup_arm_wake_irqs() called from
> dpm_suspend_noirq().
>
> So why can't we use the common code that manages wakeup irqs for
> devices?
After reading about device_wakeup_arm_wake_irqs() and
dpm_suspend_noirq() APIs it's clear to me
that we don't require runtime PM feature. We have now aligned our driver
to use common code that manages
wakeup irqs for devices.
Thanks for suggesting this changes!
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
prev parent reply other threads:[~2019-11-05 9:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 9:46 [PATCH V2 2/2] tty: serial: qcom_geni_serial: Wakeup over UART RX Akash Asthana
2019-10-10 14:25 ` Stephen Boyd
2019-10-11 9:48 ` Akash Asthana
2019-10-15 20:10 ` Stephen Boyd
2019-10-17 11:10 ` Akash Asthana
2019-10-28 15:00 ` Stephen Boyd
2019-11-05 9:56 ` Akash Asthana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=454445c2-635e-83fa-50d8-b5e2a24dd466@codeaurora.org \
--to=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox