Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: qcom: gdsc: Add pm_runtime hooks
Date: Mon, 18 Nov 2024 13:19:49 +0000	[thread overview]
Message-ID: <45c0950a-0cde-4bb9-9e3d-7f25b8a3da31@linaro.org> (raw)
In-Reply-To: <atg6yw64f4aojcbjyarljb57cejqk56g2qnddrloa3smmupm6d@fk3oyiycnuco>

On 18/11/2024 13:10, Dmitry Baryshkov wrote:
>> Introduce pm_runtime_get() and pm_runtime_put_sync() on the
>> gdsc_toggle_logic().
>>
>> This allows for the switching of the GDSC on/off to propagate to the parent
>> clock controller and consequently for any list of power-domains powering
>> that controller to be switched on/off.
> What is the end result of this patch? Does it bring up a single PM
> domain or all of them? Or should it be a part of the driver's PM
> callbacks? If the CC has multiple parent PM domains, shouldn't we also
> use some of them as GDSC's parents?

It brings up every PM domain in the list

clock_cc {
     power-domains = <somedomain0>, <another-domain>;
};

No different to what the core code does for a single domain - except we 
can actually turn the PDs off with the pm_runtime_put().

  reply	other threads:[~2024-11-18 13:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18  2:24 [PATCH 0/2] clk: qcom: Add support for multiple power-domains for a clock controller Bryan O'Donoghue
2024-11-18  2:24 ` [PATCH 1/2] clk: qcom: common: Add support for power-domain attachment Bryan O'Donoghue
2024-11-18 13:03   ` Dmitry Baryshkov
2024-11-18 13:17     ` Bryan O'Donoghue
2024-11-18 22:17   ` Vladimir Zapolskiy
2024-11-18 22:52     ` Bryan O'Donoghue
2024-11-19 15:41   ` Bjorn Andersson
2024-11-20 16:49     ` Bryan O'Donoghue
2024-11-21 21:59       ` Dmitry Baryshkov
2024-11-21 23:25         ` Bryan O'Donoghue
2024-11-18  2:24 ` [PATCH 2/2] clk: qcom: gdsc: Add pm_runtime hooks Bryan O'Donoghue
2024-11-18 13:10   ` Dmitry Baryshkov
2024-11-18 13:19     ` Bryan O'Donoghue [this message]
2024-11-18 13:39       ` Dmitry Baryshkov
2024-11-18 13:47         ` Bryan O'Donoghue
2024-11-19 15:34   ` Bjorn Andersson
2024-11-20 17:09     ` Bryan O'Donoghue
2024-11-26 17:23       ` Bjorn Andersson
2024-11-26 23:45         ` Bryan O'Donoghue
2024-11-18 13:15 ` [PATCH 0/2] clk: qcom: Add support for multiple power-domains for a clock controller Dmitry Baryshkov
2024-11-18 13:22   ` Bryan O'Donoghue
2024-11-18 13:46     ` Bryan O'Donoghue
2024-11-19  6:08 ` Taniya Das
2024-11-19  9:46   ` Bryan O'Donoghue
2024-11-19 15:28   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45c0950a-0cde-4bb9-9e3d-7f25b8a3da31@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox