public inbox for linux-arm-msm@vger.kernel.org
 help / color / mirror / Atom feed
From: Gary R Hook <gary.hook-5C7GfCeVMHo@public.gmane.org>
To: Sinan Kaya <okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"open list:AMD IOMMU (AMD-VI)"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V4 11/26] iommu/amd: deprecate pci_get_bus_and_slot()
Date: Thu, 4 Jan 2018 10:28:31 -0600	[thread overview]
Message-ID: <46ccdb85-1c23-c9eb-994c-9a66e6fce7cc@amd.com> (raw)
In-Reply-To: <8a5dad82-2886-2a51-28bc-b84ab253c361-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>

On 01/04/2018 06:25 AM, Sinan Kaya wrote:
> On 12/19/2017 12:37 AM, Sinan Kaya wrote:
>> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
>> where a PCI device is present. This restricts the device drivers to be
>> reused for other domain numbers.
>>
>> Getting ready to remove pci_get_bus_and_slot() function in favor of
>> pci_get_domain_bus_and_slot().
>>
>> Hard-code the domain number as 0 for the AMD IOMMU driver.

<snip>

 >
 > Any comments from the IOMMU people?
 >

pci_get_bus_and_slot() appears to (now) be a convenience function that 
wraps pci_get_domain_bus_and_slot() while using a 0 for the domain 
value. Exactly what you are doing here, albeit in a more overt way.

How is this patch advantageous? Seems to me that if other domains need 
to be enabled, that driver could be changed if and when that requirement 
arises.

But perhaps I'm missing a nuance here.

  parent reply	other threads:[~2018-01-04 16:28 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19  5:37 [PATCH V4 00/26] PCI: deprecate pci_get_bus_and_slot() Sinan Kaya
2017-12-19  5:37 ` [PATCH V4 01/26] alpha/PCI: " Sinan Kaya
2018-01-03 12:43   ` Sinan Kaya
2017-12-19  5:37 ` [PATCH V4 02/26] powerpc/PCI: " Sinan Kaya
2017-12-19 10:29   ` Michael Ellerman
2017-12-19 12:24     ` Sinan Kaya
2017-12-19  5:37 ` [PATCH V4 03/26] x86/PCI: " Sinan Kaya
2017-12-19  5:37 ` [PATCH V4 04/26] ata: " Sinan Kaya
2017-12-19  5:37 ` [PATCH V4 05/26] agp: nvidia: " Sinan Kaya
2018-01-03 12:44   ` Sinan Kaya
2018-01-29 21:43     ` Dave Airlie
2018-01-29 22:01       ` Sinan Kaya
2018-01-29 22:38       ` Bjorn Helgaas
2018-01-29 22:43         ` Dave Airlie
2017-12-19  5:37 ` [PATCH V4 06/26] edd: " Sinan Kaya
2018-01-03 12:48   ` Sinan Kaya
2017-12-19  5:37 ` [PATCH V4 07/26] ibft: " Sinan Kaya
2017-12-19  5:37 ` [PATCH V4 08/26] drm/gma500: " Sinan Kaya
2018-01-04 12:27   ` Sinan Kaya
2017-12-19  5:37 ` [PATCH V4 10/26] Drivers: ide: " Sinan Kaya
2017-12-19 14:13   ` David Miller
     [not found] ` <1513661883-28662-1-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-19  5:37   ` [PATCH V4 09/26] drm/nouveau: " Sinan Kaya
2018-01-04 12:26     ` Sinan Kaya
2017-12-19  5:37   ` [PATCH V4 11/26] iommu/amd: " Sinan Kaya
2018-01-04 12:25     ` Sinan Kaya
     [not found]       ` <8a5dad82-2886-2a51-28bc-b84ab253c361-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-01-04 16:28         ` Gary R Hook [this message]
2018-01-04 16:32           ` Sinan Kaya
2018-01-04 17:25             ` Gary R Hook
2018-01-17 13:02     ` Joerg Roedel
2017-12-19  5:37 ` [PATCH V4 12/26] powerpc/powermac: " Sinan Kaya
2017-12-19  5:37 ` [PATCH V4 13/26] bnx2x: " Sinan Kaya
2017-12-19 14:14   ` David Miller
2017-12-19  5:37 ` [PATCH V4 14/26] pch_gbe: " Sinan Kaya
2017-12-19 10:45   ` Andy Shevchenko
2017-12-19 12:17     ` Sinan Kaya
2017-12-19 13:24       ` Andy Shevchenko
2017-12-19 14:53       ` David Miller
2017-12-19 14:13   ` David Miller
2017-12-19  5:37 ` [PATCH V4 15/26] PCI: cpqhp: " Sinan Kaya
2017-12-19  5:37 ` [PATCH V4 16/26] PCI: ibmphp: " Sinan Kaya
2017-12-19  5:37 ` [PATCH V4 17/26] PCI/quirks: " Sinan Kaya
2017-12-19  5:37 ` [PATCH V4 18/26] PCI/syscall: " Sinan Kaya
2017-12-19  5:37 ` [PATCH V4 19/26] xen: " Sinan Kaya
2017-12-19  5:37 ` [PATCH V4 20/26] openprom: " Sinan Kaya
2017-12-19 14:13   ` David Miller
2017-12-19  5:37 ` [PATCH V4 21/26] backlight: " Sinan Kaya
2017-12-19  8:51   ` Lee Jones
2017-12-19  5:37 ` [PATCH V4 22/26] video: fbdev: intelfb: " Sinan Kaya
2018-01-02 13:38   ` Sinan Kaya
2018-01-03 11:18     ` Bartlomiej Zolnierkiewicz
2017-12-19  5:37 ` [PATCH V4 23/26] video: fbdev: nvidia: " Sinan Kaya
2018-01-02 13:38   ` Sinan Kaya
2018-01-03 11:18     ` Bartlomiej Zolnierkiewicz
2017-12-19  5:38 ` [PATCH V4 24/26] video: fbdev: riva: " Sinan Kaya
2018-01-02 13:37   ` Sinan Kaya
2018-01-03 11:18     ` Bartlomiej Zolnierkiewicz
2017-12-19  5:38 ` [PATCH V4 25/26] i7300_idle: remove unused file Sinan Kaya
2018-01-02 13:36   ` Sinan Kaya
2018-01-02 13:44     ` Greg Kroah-Hartman
2017-12-19  5:38 ` [PATCH V4 26/26] PCI: Remove pci_get_bus_and_slot() function Sinan Kaya
2018-02-16 14:55   ` Bjorn Helgaas
2018-01-11 23:57 ` [PATCH V4 00/26] PCI: deprecate pci_get_bus_and_slot() Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46ccdb85-1c23-c9eb-994c-9a66e6fce7cc@amd.com \
    --to=gary.hook-5c7gfcevmho@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox