From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH] drm/msm: Fix NULL deref in adreno_load_gpu Date: Wed, 20 Dec 2017 12:18:21 +0530 Message-ID: <47ac0981-5b3b-86b3-6fd8-77fa769b7c56@codeaurora.org> References: <20171214054150.20943-1-architt@codeaurora.org> <20171215153325.GA25601@jcrouse-lnx.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171215153325.GA25601@jcrouse-lnx.qualcomm.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: robdclark@gmail.com, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: linux-arm-msm@vger.kernel.org CgpPbiAxMi8xNS8yMDE3IDA5OjAzIFBNLCBKb3JkYW4gQ3JvdXNlIHdyb3RlOgo+IE9uIFRodSwg RGVjIDE0LCAyMDE3IGF0IDExOjExOjUwQU0gKzA1MzAsIEFyY2hpdCBUYW5lamEgd3JvdGU6Cj4+ IFRoZSBtc20va21zIGRyaXZlciBzaG91bGQgd29yayBldmVuIGlmIHRoZXJlIGlzIG5vIEdQVSBk ZXZpY2Ugc3BlY2lmaWVkCj4+IGluIERULiBDdXJyZW50bHksIHdlIGdldCBhIE5VTEwgZGVyZWZl cmVuY2UgY3Jhc2ggaW4gYWRyZW5vX2xvYWRfZ3B1Cj4+IHNpbmNlIHRoZSBkcml2ZXIgYXNzdW1l cyB0aGF0IHByaXYtPmdwdV9wZGV2IGlzIG5vbi1OVUxMLgo+Pgo+PiBQZXJmb3JtIGFuIGFkZGl0 aW9uYWwgY2hlY2sgb24gcHJpdi0+Z3B1X3BkZXYgYmVmb3JlIHRyeWluZyB0byByZXRyaWV2ZQo+ PiB0aGUgbXNtX2dwdSBwb2ludGVyIGZyb20gaXQuCj4+Cj4+IEZpeGVzOiBlZWM4NzRjZTVmZjEg KGRybS9tc20vYWRyZW5vOiBsb2FkIGdwdSBhdCBwcm9iZS9iaW5kIHRpbWUpCj4+Cj4+IFNpZ25l ZC1vZmYtYnk6IEFyY2hpdCBUYW5lamEgPGFyY2hpdHRAY29kZWF1cm9yYS5vcmc+Cj4+IC0tLQo+ PiAgIGRyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2FkcmVub19kZXZpY2UuYyB8IDExICsrKysr KysrKy0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2FkcmVub19k ZXZpY2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2FkcmVub19kZXZpY2UuYwo+PiBp bmRleCAwNTAyMmVhMmEwMDcuLmFjNjBjZjNjNzk0ZSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL21zbS9hZHJlbm8vYWRyZW5vX2RldmljZS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9tc20vYWRyZW5vL2FkcmVub19kZXZpY2UuYwo+PiBAQCAtMTI0LDEwICsxMjQsMTcgQEAgY29u c3Qgc3RydWN0IGFkcmVub19pbmZvICphZHJlbm9faW5mbyhzdHJ1Y3QgYWRyZW5vX3JldiByZXYp Cj4+ICAgc3RydWN0IG1zbV9ncHUgKmFkcmVub19sb2FkX2dwdShzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2KQo+PiAgIHsKPj4gICAJc3RydWN0IG1zbV9kcm1fcHJpdmF0ZSAqcHJpdiA9IGRldi0+ZGV2 X3ByaXZhdGU7Cj4+IC0Jc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldiA9IHByaXYtPmdwdV9w ZGV2Owo+PiAtCXN0cnVjdCBtc21fZ3B1ICpncHUgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwcml2 LT5ncHVfcGRldik7Cj4+ICsJc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldjsKPj4gKwlzdHJ1 Y3QgbXNtX2dwdSAqZ3B1Owo+PiAgIAlpbnQgcmV0Owo+PiAgIAo+PiArCXBkZXYgPSBwcml2LT5n cHVfcGRldjsKPj4gKwlpZiAoIXBkZXYpIHsKPj4gKwkJZGV2X2RiZyhkZXYtPmRldiwgIm5vIGFk cmVubyBwbGF0Zm9ybSBkZXZpY2UgZm91bmRcbiIpOwo+PiArCQlyZXR1cm4gTlVMTDsKPj4gKwl9 Cj4+ICsKPj4gKwlncHUgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKPj4gICAJaWYgKCFn cHUpIHsKPj4gICAJCWRldl9lcnIoZGV2LT5kZXYsICJubyBhZHJlbm8gZGV2aWNlXG4iKTsKPj4g ICAJCXJldHVybiBOVUxMOwo+IAo+IE9idmlvdXNseSBjb3JyZWN0IGZpeCBidXQgSSBjYW4ndCBo ZWxwIGJ1dCB0aGluayB0aGF0IHdlIHNob3VsZCBzaGFyZSB0aGUgc2FtZQo+IGVycm9yIG1lc3Nh Z2UsIHNvIHNvbWV0aGluZyBsaWtlOgo+IAo+IHN0cnVjdCBtc21fZ3B1ICpncHUgPSBOVUxMOwo+ IAo+IC4uCj4gCj4gaWYgKHByaXYtPmdwdV9wZGV2KQo+ICAgICBncHUgPSBwbGF0Zm9ybV9nZXRf ZHJ2ZGF0YShwcml2LT5ncHVfcGRldik7Cj4gCj4gaWYgKCFncHUpIHsKPiAJZGV2X2VycihkZXYt PmRldiwgIk5vIEdQVSBkZXZpY2Ugd2FzIHdhcyBmb3VuZFxuIik7Cj4gICAJcmV0dXJuIE5VTEw7 Cj4gfQo+IAo+IChhbHNvLCBJIGNhbid0IGhlbHAgYnV0IHRoaW5rIG1heWJlIHRoYXQgZGV2X2Vy ciBzaG91bGQgYmUgYSBPTkNFIHNvIHlvdSBkb24ndAo+IGdldCBhIG5hc3R5IG1lc3NhZ2UgZXZl cnkgdGltZSB5b3Ugb3BlbiB0aGUgZmlsZSBkZXNjcmlwdG9yKS4KClRoaXMgYXBwcm9hY2ggbG9v a3MgYmV0dGVyLiBJJ2xsIHJlLXNwaW4uCgpUaGFua3MsCkFyY2hpdAoKPiAKPiBKb3JkYW4KPiAK Ci0tIApRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIG1lbWJlciBvZiBDb2Rl IEF1cm9yYSBGb3J1bSwKYSBMaW51eCBGb3VuZGF0aW9uIENvbGxhYm9yYXRpdmUgUHJvamVjdApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK