From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Marijn Suijten <marijn.suijten@somainline.org>,
Rob Clark <robdclark@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
"Sean Paul" <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Adam Skladowski <a39.skl@gmail.com>,
Loic Poulain <loic.poulain@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
"Kuogee Hsieh" <quic_khsieh@quicinc.com>,
Robert Foss <rfoss@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: Jami Kettunen <jami.kettunen@somainline.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
Jordan Crouse <jordan@cosmicpenguin.net>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Martin Botka <martin.botka@somainline.org>,
<~postmarketos/upstreaming@lists.sr.ht>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
<freedreno@lists.freedesktop.org>
Subject: Re: [Freedreno] [PATCH v4 06/22] drm/msm/dpu: Use V2 DITHER PINGPONG sub-block in SM8[34]50/SC8280XP
Date: Wed, 26 Apr 2023 15:45:13 -0700 [thread overview]
Message-ID: <4875712e-5d52-06d0-daae-eee2eba3e730@quicinc.com> (raw)
In-Reply-To: <20230411-dpu-intf-te-v4-6-27ce1a5ab5c6@somainline.org>
On 4/26/2023 3:37 PM, Marijn Suijten wrote:
> According to downstream sources this DITHER sub-block sits at an offset
> of 0xe0 with version 0x20000. The PP_BLK_DITHER macro is _not_ used as
> downstream still says the size of the PINGPONG block is 0xd4 and not 0.
>
> Fixes: 4a352c2fc15a ("drm/msm/dpu: Introduce SC8280XP")
> Fixes: 0e91bcbb0016 ("drm/msm/dpu: Add SM8350 to hw catalog")
> Fixes: 100d7ef6995d ("drm/msm/dpu: add support for SM8450")
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
As discussed, will drop "The PP_BLK_DITHER macro is _not_ used as
downstream still says the size of the PINGPONG block is 0xd4 and not 0"
from the commit text while applying, otherwise
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
next prev parent reply other threads:[~2023-04-26 22:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 22:37 [PATCH v4 00/22] drm/msm/dpu: Implement tearcheck support on INTF block Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 01/22] drm/msm/dpu: Remove unused INTF0 interrupt mask from SM6115/QCM2290 Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 02/22] drm/msm/dpu: Remove TE2 block and feature from DPU >= 5.0.0 hardware Marijn Suijten
2023-04-26 22:42 ` Abhinav Kumar
2023-04-27 14:15 ` Dmitry Baryshkov
2023-04-26 22:37 ` [PATCH v4 03/22] drm/msm/dpu: Move non-MDP_TOP INTF_INTR offsets out of hwio header Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 04/22] drm/msm/dpu: Reindent REV_7xxx interrupt masks with tabs Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 05/22] drm/msm/dpu: Fix PP_BLK_DIPHER -> DITHER typo Marijn Suijten
2023-04-27 16:00 ` Neil Armstrong
2023-04-26 22:37 ` [PATCH v4 06/22] drm/msm/dpu: Use V2 DITHER PINGPONG sub-block in SM8[34]50/SC8280XP Marijn Suijten
2023-04-26 22:45 ` Abhinav Kumar [this message]
2023-04-26 22:37 ` [PATCH v4 07/22] drm/msm/dpu: Set PINGPONG block length to zero for DPU >= 7.0.0 Marijn Suijten
2023-04-26 22:46 ` Abhinav Kumar
2023-04-27 17:42 ` Dmitry Baryshkov
2023-04-26 22:37 ` [PATCH v4 08/22] drm/msm/dpu: Remove duplicate register defines from INTF Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 09/22] drm/msm/dpu: Remove extraneous register define indentation Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 10/22] drm/msm/dpu: Sort INTF registers numerically Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 11/22] drm/msm/dpu: Take INTF index as parameter in interrupt register defines Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 12/22] drm/msm/dpu: Drop unused poll_timeout_wr_ptr PINGPONG callback Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 13/22] drm/msm/dpu: Move autorefresh disable from CMD encoder to pingpong Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 14/22] drm/msm/dpu: Disable pingpong TE on DPU 5.0.0 and above Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 15/22] drm/msm/dpu: Disable MDP vsync source selection " Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 16/22] drm/msm/dpu: Move dpu_hw_{tear_check,pp_vsync_info} to dpu_hw_mdss.h Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 17/22] drm/msm/dpu: Factor out shared interrupt register in INTF_BLK macro Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 18/22] drm/msm/dpu: Describe TEAR interrupt registers for DSI interfaces Marijn Suijten
2023-04-27 17:46 ` Dmitry Baryshkov
2023-04-26 22:37 ` [PATCH v4 19/22] drm/msm/dpu: Add TEAR-READ-pointer interrupt to INTF block Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 20/22] drm/msm/dpu: Merge setup_- and enable_tearcheck pingpong callbacks Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 21/22] drm/msm/dpu: Implement tearcheck support on INTF block Marijn Suijten
2023-04-26 22:37 ` [PATCH v4 22/22] drm/msm/dpu: Remove intr_rdptr from DPU >= 5.0.0 pingpong config Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4875712e-5d52-06d0-daae-eee2eba3e730@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=a39.skl@gmail.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jami.kettunen@somainline.org \
--cc=jordan@cosmicpenguin.net \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=vkoul@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox