From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A09ADC64ED6 for ; Tue, 28 Feb 2023 15:37:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230059AbjB1PhS (ORCPT ); Tue, 28 Feb 2023 10:37:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229962AbjB1PhR (ORCPT ); Tue, 28 Feb 2023 10:37:17 -0500 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC03927486 for ; Tue, 28 Feb 2023 07:37:15 -0800 (PST) Received: by mail-lj1-x230.google.com with SMTP id f16so10684226ljq.10 for ; Tue, 28 Feb 2023 07:37:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677598634; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PmZThYj/LApm7g8E3Vb/uN+vkTQ915AMf1R2olPZ3NU=; b=ElrpRhI3WQ3X5hsHrwaar/fvHU6EmGpxSEUDJK57GQ/39+NUkwXWShyocCIsQRKcIg pbEJVkzhuWjSlfgnaEtAi57MM3iF4cVm2SmGDERNDxIQ7Dbj9+4OOGH18kWC6t7zP5FR aH1L8CmT0CVfi37dAI0TCjmnp9R2RR1Z2IZLjG51iV53rr/Nslk+EoA+AJ5mS4FQKh4A Z0Ojih9GGDIKxFtBQ3PWfiGwTP1s4mpmlpI2PTV+jb3loe6IeCeMh4cwLNQNG85eSVlh qdNq5I1kt7EDOXbuMQtzfu0CAoOQRyBQcdDK6iPlZanYUfbwD8c3MWNQkd9ghOa0fhtg Xd/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677598634; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PmZThYj/LApm7g8E3Vb/uN+vkTQ915AMf1R2olPZ3NU=; b=LXTz9Cc+2i8v1qeULTDuOKgoARuuKbmwR4ce4ZtJ+cs90sOyNQGw9XKwGaj2uytK0x ZLnbegaLePaYySVOXYpIN5Sr/DvcCodKBcEMlnlvrR/itqmSi9jIviw7p3eS4qNS166a Z9ar2In4VwzWwFcwiDd0sLf52GaZNS/hAl7xZ5Z7IFpOM4qjfKsKWh53lMEMY9Ovf03U RDYH4NOPQbzxncjM4RtCym0c3cIQmMRhmkZl2mfsHsVhAl38s4HP9OMfmp1zekD6zSuL 8I7nDlCOayB4UWkKEN+DqESEXXyp7lteB6Qjy3KrjlDjS/RgRVKUz/8xlTtvWDd2xe5E 8tng== X-Gm-Message-State: AO0yUKXX18Wso21mD3CnbG17vOx7FYlvEpdXU7+olNpHdyzqKbn3EY18 cKqwFwu4D/7FoUaqAPGPGwVOPA== X-Google-Smtp-Source: AK7set8OR7nGA538ny3cM3lrTAmK0UyJgkUspqLu+Y4G4AHnYMu9ODpfNIvu2SNyqODgJf5yS33kBQ== X-Received: by 2002:a05:651c:383:b0:295:9829:47b0 with SMTP id e3-20020a05651c038300b00295982947b0mr802542ljp.49.1677598634002; Tue, 28 Feb 2023 07:37:14 -0800 (PST) Received: from [192.168.1.101] (abym99.neoplus.adsl.tpnet.pl. [83.9.32.99]) by smtp.gmail.com with ESMTPSA id u5-20020a05651c130500b002959f550084sm1213885lja.100.2023.02.28.07.37.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 07:37:13 -0800 (PST) Message-ID: <48ac4272-0e11-d943-e950-0be8d93fb036@linaro.org> Date: Tue, 28 Feb 2023 16:37:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 01/18] media: venus: hfi_venus: Set venus_sys_idle_indicator to false on V6 Content-Language: en-US To: Bryan O'Donoghue , Stanimir Varbanov , Vikash Garodia , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Dikshita Agarwal , Dikshita Agarwal , Mansur Alisha Shaik , Jonathan Marek Cc: Mauro Carvalho Chehab , Stanimir Varbanov , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Vikash Garodia References: <20230228-topic-venus-v1-0-58c2c88384e9@linaro.org> <20230228-topic-venus-v1-1-58c2c88384e9@linaro.org> <99eeebc6-69aa-c6ba-139b-92672c299747@linaro.org> <893851c9-c8be-ed7f-ebde-5d90b9313f6d@linaro.org> From: Konrad Dybcio In-Reply-To: <893851c9-c8be-ed7f-ebde-5d90b9313f6d@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 28.02.2023 16:31, Bryan O'Donoghue wrote: > On 28/02/2023 15:26, Bryan O'Donoghue wrote: >> On 28/02/2023 15:24, Konrad Dybcio wrote: >>> This call does not seem to have been cast on any kernel with support >>> for VPU-1.0 or newer (and by extension, HFI6 and newer). >> >> We tested this on sm8250 >> >> Restrict it >>> to V4 only, as it seems to have been enabled by mistake and causes a >>> hang & reboot to EDL on at least one occasion with SM6115 / AR50L >>> >>> Fixes: 7ed9e0b3393c ("media: venus: hfi, vdec: v6 Add IS_V6() to existing IS_V4() if locations") >>> Signed-off-by: Konrad Dybcio >> >> Right. This may indeed fix it for you on SM6115, could you test it on RB5 and verify the above statement ? >> >> --- >> bod > > For example. > > Doesn't your later patch take account of VPU h/w version ? IRIS_1, IRIS_2 etc. > > When we added for V6 here, we meant for current tested V6 hardware at that point - at least sm8250. > > Can you not differentiate sm6115 based on VPU hardware identifier ? We want to retain this logic for 8250 and then assuming your patch is correct, not do this for sm6115. As far as my only source of information (msm-4.19 techpack) goes, this is unnecessary/incorrect on 8250 as well. I doubt downstream would ship Venus with no/broken low-power modes.. Konrad > > --- > bod