From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeykumar Sankaran Subject: Re: [DPU PATCH 03/11] drm/msm: Refactor complete_commit() to look more the helpers Date: Thu, 08 Mar 2018 17:01:50 -0800 Message-ID: <48b0278eddbc305aa32292c0ec3189e3@codeaurora.org> References: <20180228191906.185417-1-seanpaul@chromium.org> <20180228191906.185417-4-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180228191906.185417-4-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Sean Paul Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gMjAxOC0wMi0yOCAxMToxOCwgU2VhbiBQYXVsIHdyb3RlOgo+IEZhY3RvciBvdXQgdGhlIGNv bW1pdF90YWlsKCkgcG9ydGlvbnMgb2YgY29tcGxldGVfY29tbWl0KCkgaW50byBhCj4gc2VwYXJh dGUgZnVuY3Rpb24gdG8gZmFjaWxpdGF0ZSBtb3ZpbmcgdG8gdGhlIGF0b21pYyBoZWxwZXJzIGlu IGZ1dHVyZQo+IHBhdGNoZXMuCj4gCj4gQ2hhbmdlLUlkOiBJNGI4NThhZDlmZTM1NmIzMWVkMGVk OWVlY2RiMzk0YTYxMDQ4ZTM5Ywo+IFNpZ25lZC1vZmYtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxA Y2hyb21pdW0ub3JnPgoKUmV2aWV3ZWQtYnk6IEpleWt1bWFyIFNhbmthcmFuIDxqc2Fua2FAY29k ZWF1cm9yYS5vcmc+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9hdG9taWMuYyB8 IDI1ICsrKysrKysrKysrKysrKystLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE2IGluc2Vy dGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9tc20vbXNtX2F0b21pYy5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9hdG9taWMuYwo+ IGluZGV4IGY1Nzk0ZGNlMjVkZC4uZWIyY2NkYTVkYTBmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9tc20vbXNtX2F0b21pYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9tc21f YXRvbWljLmMKPiBAQCAtODQsMTggKzg0LDEyIEBAIHN0YXRpYyB2b2lkIG1zbV9hdG9taWNfd2Fp dF9mb3JfY29tbWl0X2RvbmUoCj4gIAl9Cj4gIH0KPiAKPiAtLyogVGhlIChwb3RlbnRpYWxseSkg YXN5bmNocm9ub3VzIHBhcnQgb2YgdGhlIGNvbW1pdC4gIEF0IHRoaXMgcG9pbnQKPiAtICogbm90 aGluZyBjYW4gZmFpbCBzaG9ydCBvZiBhcm1hZ2VkZG9uLgo+IC0gKi8KPiAtc3RhdGljIHZvaWQg Y29tcGxldGVfY29tbWl0KHN0cnVjdCBtc21fY29tbWl0ICpjKQo+ICtzdGF0aWMgdm9pZCBtc21f YXRvbWljX2NvbW1pdF90YWlsKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgewo+ IC0Jc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlID0gYy0+c3RhdGU7Cj4gIAlzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2ID0gc3RhdGUtPmRldjsKPiAgCXN0cnVjdCBtc21fZHJtX3ByaXZhdGUg KnByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ICAJc3RydWN0IG1zbV9rbXMgKmttcyA9IHByaXYt PmttczsKPiAKPiAtCWRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2ZlbmNlcyhkZXYsIHN0YXRl LCBmYWxzZSk7Cj4gLQo+ICAJa21zLT5mdW5jcy0+cHJlcGFyZV9jb21taXQoa21zLCBzdGF0ZSk7 Cj4gCj4gIAlkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfbW9kZXNldF9kaXNhYmxlcyhkZXYsIHN0 YXRlKTsKPiBAQCAtMTI3LDEwICsxMjEsMjEgQEAgc3RhdGljIHZvaWQgY29tcGxldGVfY29tbWl0 KHN0cnVjdCBtc21fY29tbWl0ICpjKQo+ICAJZHJtX2F0b21pY19oZWxwZXJfY2xlYW51cF9wbGFu ZXMoZGV2LCBzdGF0ZSk7Cj4gCj4gIAlrbXMtPmZ1bmNzLT5jb21wbGV0ZV9jb21taXQoa21zLCBz dGF0ZSk7Cj4gK30KPiAKPiAtCWRybV9hdG9taWNfc3RhdGVfcHV0KHN0YXRlKTsKPiArLyogVGhl IChwb3RlbnRpYWxseSkgYXN5bmNocm9ub3VzIHBhcnQgb2YgdGhlIGNvbW1pdC4gIEF0IHRoaXMg cG9pbnQKPiArICogbm90aGluZyBjYW4gZmFpbCBzaG9ydCBvZiBhcm1hZ2VkZG9uLgo+ICsgKi8K PiArc3RhdGljIHZvaWQgY29tcGxldGVfY29tbWl0KHN0cnVjdCBtc21fY29tbWl0ICpjKQo+ICt7 Cj4gKwlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUgPSBjLT5zdGF0ZTsKPiArCXN0cnVj dCBkcm1fZGV2aWNlICpkZXYgPSBzdGF0ZS0+ZGV2Owo+IAo+IC0JY29tbWl0X2Rlc3Ryb3koYyk7 Cj4gKwlkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl9mZW5jZXMoZGV2LCBzdGF0ZSwgZmFsc2Up Owo+ICsKPiArCW1zbV9hdG9taWNfY29tbWl0X3RhaWwoc3RhdGUpOwo+ICsKPiArCWRybV9hdG9t aWNfc3RhdGVfcHV0KHN0YXRlKTsKPiAgfQo+IAo+ICBzdGF0aWMgdm9pZCBfbXNtX2RybV9jb21t aXRfd29ya19jYihzdHJ1Y3Qga3RocmVhZF93b3JrICp3b3JrKQo+IEBAIC0xNDUsNiArMTUwLDgg QEAgc3RhdGljIHZvaWQgX21zbV9kcm1fY29tbWl0X3dvcmtfY2Ioc3RydWN0Cj4ga3RocmVhZF93 b3JrICp3b3JrKQo+ICAJY29tbWl0ID0gY29udGFpbmVyX29mKHdvcmssIHN0cnVjdCBtc21fY29t bWl0LCBjb21taXRfd29yayk7Cj4gCj4gIAljb21wbGV0ZV9jb21taXQoY29tbWl0KTsKPiArCj4g Kwljb21taXRfZGVzdHJveShjb21taXQpOwo+ICB9Cj4gCj4gIHN0YXRpYyBzdHJ1Y3QgbXNtX2Nv bW1pdCAqY29tbWl0X2luaXQoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAoKLS0gCkpl eWt1bWFyIFMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K RnJlZWRyZW5vIG1haWxpbmcgbGlzdApGcmVlZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZnJlZWRyZW5vCg==