Re: [PATCH v3 01/11] dt-bindings: arm: Add support for DSB element size

Krzysztof Kozlowski
2023-03-25T11:35:11Z

On 24/03/2023 10:15, Tao Zhang wrote:
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +    minimum: 32
>>>> +    maximum: 64
>>>
>>> Shouldn't this be something like oneOf ? It is not a range, but one of
>>> those two specific values ?
>>
>> Yes, "qcom,dsb-element-size" should be an optional option required in
>> TPDM
>>
>> devicetree. Other properties like "qcom,cmb-element-size",
>> "qcom,tc-element-size"
>>
>> and etc. will be added in a later patch series.
>>
>> I will update this doc according to your advice in the next version of
>> the patch.
>>
>> Tao
>>
> Correct my misunderstanding in the mail above.
>
> You are right, DSB element size should be 32-bit or 64-bit. I will
> update this in the next

Then 'enum', not 'oneOf'.

Best regards,
Krzysztof