From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeykumar Sankaran Subject: Re: [PATCH v2 19/24] drm/msm: dpu: Remove vblank_callback from encoder Date: Mon, 19 Nov 2018 12:11:11 -0800 Message-ID: <49433c0b23f20ad585631f65f2eefde9@codeaurora.org> References: <20181116184238.170034-1-sean@poorly.run> <20181116184238.170034-20-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181116184238.170034-20-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Sean Paul Cc: Sean Paul , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gMjAxOC0xMS0xNiAxMDo0MiwgU2VhbiBQYXVsIHdyb3RlOgo+IEZyb206IFNlYW4gUGF1bCA8 c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IFRoZSBpbmRpcmVjdGlvbiBvZiByZWdpc3Rlcmlu ZyBhIGNhbGxiYWNrIGFuZCBvcGFxdWUgcG9pbnRlciBpc24ndCAKPiByZWFsbAo+IHVzZWZ1bCB3 aGVuIHRoZXJlJ3Mgb25seSBvbmUgY2FsbHNpdGUuIFNvIGluc3RlYWQgb2YgaGF2aW5nIHRoZQo+ IHZibGFua19jYiByZWdpc3RyYXRpb24sIGp1c3QgZ2l2ZSBlbmNvZGVyIGEgY3J0YyBhbmQgbGV0 IGl0IGRpcmVjdGx5Cj4gY2FsbCB0aGUgdmJsYW5rIGhhbmRsZXIuCj4gCj4gSW4gYSBsYXRlciBw YXRjaCwgd2UnbGwgbWFrZSB1c2Ugb2YgdGhpcyBmdXJ0aGVyLgo+IAo+IENoYW5nZXMgaW4gdjI6 Cj4gLSBOb25lCj4gCj4gQ2M6IEpleWt1bWFyIFNhbmthcmFuIDxqc2Fua2FAY29kZWF1cm9yYS5v cmc+Cj4gU2lnbmVkLW9mZi1ieTogU2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+CgpS ZXZpZXdlZC1ieTogSmV5a3VtYXIgU2Fua2FyYW4gPGpzYW5rYUBjb2RlYXVyb3JhLm9yZz4KCj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMgICAgfCAgOCAr KystLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmggICAgfCAg NiArKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlci5jIHwg MjUgKysrKysrKysrKystLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUx L2RwdV9lbmNvZGVyLmggfCAxMCArKysrLS0tLS0KPiAgNCBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNl cnRpb25zKCspLCAyMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL21zbS9kaXNwL2RwdTEvZHB1X2NydGMuYwo+IGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNw L2RwdTEvZHB1X2NydGMuYwo+IGluZGV4IDE0MWVkMWIwZTkwYS4uNGQ3ZjlmZjFlOWY0IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5jCj4gQEAgLTI5Myw5ICsy OTMsOCBAQCBlbnVtIGRwdV9pbnRmX21vZGUgZHB1X2NydGNfZ2V0X2ludGZfbW9kZShzdHJ1Y3QK PiBkcm1fY3J0YyAqY3J0YykKPiAgCXJldHVybiBJTlRGX01PREVfTk9ORTsKPiAgfQo+IAo+IC1z dGF0aWMgdm9pZCBkcHVfY3J0Y192YmxhbmtfY2Iodm9pZCAqZGF0YSkKPiArdm9pZCBkcHVfY3J0 Y192YmxhbmtfY2FsbGJhY2soc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ICB7Cj4gLQlzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMgPSAoc3RydWN0IGRybV9jcnRjICopZGF0YTsKPiAgCXN0cnVjdCBkcHVf Y3J0YyAqZHB1X2NydGMgPSB0b19kcHVfY3J0YyhjcnRjKTsKPiAKPiAgCS8qIGtlZXAgc3RhdGlz dGljcyBvbiB2YmxhbmsgY2FsbGJhY2sgLSB3aXRoIGF1dG8gcmVzZXQgdmlhCj4gZGVidWdmcyAq Lwo+IEBAIC03NzEsOCArNzcwLDcgQEAgc3RhdGljIHZvaWQgX2RwdV9jcnRjX3ZibGFua19lbmFi bGVfbm9fbG9jaygKPiAgCQkJCQkJICAgICBEUk1JRChlbmMpLCBlbmFibGUsCj4gIAkJCQkJCSAg ICAgZHB1X2NydGMpOwo+IAo+IC0JCQlkcHVfZW5jb2Rlcl9yZWdpc3Rlcl92YmxhbmtfY2FsbGJh Y2soZW5jLAo+IC0JCQkJCWRwdV9jcnRjX3ZibGFua19jYiwgKHZvaWQgKiljcnRjKTsKPiArCQkJ ZHB1X2VuY29kZXJfYXNzaWduX2NydGMoZW5jLCBjcnRjKTsKPiAgCQl9Cj4gIAl9IGVsc2Ugewo+ ICAJCWxpc3RfZm9yX2VhY2hfZW50cnkoZW5jLCAmZGV2LT5tb2RlX2NvbmZpZy5lbmNvZGVyX2xp c3QsCj4gaGVhZCkgewo+IEBAIC03ODMsNyArNzgxLDcgQEAgc3RhdGljIHZvaWQgX2RwdV9jcnRj X3ZibGFua19lbmFibGVfbm9fbG9jaygKPiAgCQkJCQkJICAgICBEUk1JRChlbmMpLCBlbmFibGUs Cj4gIAkJCQkJCSAgICAgZHB1X2NydGMpOwo+IAo+IC0JCQlkcHVfZW5jb2Rlcl9yZWdpc3Rlcl92 YmxhbmtfY2FsbGJhY2soZW5jLCBOVUxMLAo+IE5VTEwpOwo+ICsJCQlkcHVfZW5jb2Rlcl9hc3Np Z25fY3J0YyhlbmMsIE5VTEwpOwo+ICAJCX0KPiAgCX0KPiAgfQo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5oCj4gYi9kcml2ZXJzL2dwdS9kcm0v bXNtL2Rpc3AvZHB1MS9kcHVfY3J0Yy5oCj4gaW5kZXggOTNkMjFhNjFhMDQwLi41NDU5NWNjMjli ZTUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2NydGMu aAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9jcnRjLmgKPiBAQCAt MjcwLDYgKzI3MCwxMiBAQCBzdGF0aWMgaW5saW5lIGludCBkcHVfY3J0Y19mcmFtZV9wZW5kaW5n KHN0cnVjdAo+IGRybV9jcnRjICpjcnRjKQo+ICAgKi8KPiAgaW50IGRwdV9jcnRjX3ZibGFuayhz dHJ1Y3QgZHJtX2NydGMgKmNydGMsIGJvb2wgZW4pOwo+IAo+ICsvKioKPiArICogZHB1X2NydGNf dmJsYW5rX2NhbGxiYWNrIC0gY2FsbGVkIG9uIHZibGFuayBpcnEsIGlzc3VlcyBjb21wbGV0aW9u Cj4gZXZlbnRzCj4gKyAqIEBjcnRjOiBQb2ludGVyIHRvIGRybSBjcnRjIG9iamVjdAo+ICsgKi8K PiArdm9pZCBkcHVfY3J0Y192YmxhbmtfY2FsbGJhY2soc3RydWN0IGRybV9jcnRjICpjcnRjKTsK PiArCj4gIC8qKgo+ICAgKiBkcHVfY3J0Y19jb21taXRfa2lja29mZiAtIHRyaWdnZXIga2lja29m ZiBvZiB0aGUgY29tbWl0IGZvciB0aGlzIAo+IGNydGMKPiAgICogQGNydGM6IFBvaW50ZXIgdG8g ZHJtIGNydGMgb2JqZWN0Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9k cHUxL2RwdV9lbmNvZGVyLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9l bmNvZGVyLmMKPiBpbmRleCBkODlhYzUyMGY3ZTYuLmZkNjUxNGY2ODFhZSAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlci5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2VuY29kZXIuYwo+IEBAIC0xNDIsOSArMTQy LDExIEBAIGVudW0gZHB1X2VuY19yY19zdGF0ZXMgewo+ICAgKiBAaW50ZnNfc3dhcHBlZAlXaGV0 aGVyIG9yIG5vdCB0aGUgcGh5c19lbmMgaW50ZXJmYWNlcyBoYXZlIGJlZW4KPiBzd2FwcGVkCj4g ICAqCQkJZm9yIHBhcnRpYWwgdXBkYXRlIHJpZ2h0LW9ubHkgY2FzZXMsIHN1Y2ggYXMKPiBwaW5n cG9uZwo+ICAgKgkJCXNwbGl0IHdoZXJlIHZpcnR1YWwgcGluZ3BvbmcgZG9lcyBub3QgZ2VuZXJh dGUKPiBJUlFzCj4gLSAqIEBjcnRjX3ZibGFua19jYjoJQ2FsbGJhY2sgaW50byB0aGUgdXBwZXIg bGF5ZXIgLyBDUlRDIGZvcgo+IC0gKgkJCW5vdGlmaWNhdGlvbiBvZiB0aGUgVkJMQU5LCj4gLSAq IEBjcnRjX3ZibGFua19jYl9kYXRhOglEYXRhIGZyb20gdXBwZXIgbGF5ZXIgZm9yIFZCTEFOSwo+ IG5vdGlmaWNhdGlvbgo+ICsgKiBAY3J0YzoJCVBvaW50ZXIgdG8gdGhlIGN1cnJlbnRseSBhc3Np Z25lZCBjcnRjLiBOb3JtYWxseQo+IHlvdQo+ICsgKgkJCXdvdWxkIHVzZSBjcnRjLT5zdGF0ZS0+ ZW5jb2Rlcl9tYXNrIHRvIGRldGVybWluZQo+IHRoZQo+ICsgKgkJCWxpbmsgYmV0d2VlbiBlbmNv ZGVyL2NydGMuIEhvd2V2ZXIgaW4gdGhpcyBjYXNlIHdlCj4gbmVlZAo+ICsgKgkJCXRvIHRyYWNr IGNydGMgaW4gdGhlIGRpc2FibGUoKSBob29rIHdoaWNoIGlzCj4gY2FsbGVkCj4gKyAqCQkJX2Fm dGVyXyBlbmNvZGVyX21hc2sgaXMgY2xlYXJlZC4KPiAgICogQGNydGNfa2lja29mZl9jYjoJCUNh bGxiYWNrIGludG8gQ1JUQyB0aGF0IHdpbGwgZmx1c2ggJiBzdGFydAo+ICAgKgkJCQlhbGwgQ1RM IHBhdGhzCj4gICAqIEBjcnRjX2tpY2tvZmZfY2JfZGF0YToJT3BhcXVlIHVzZXIgZGF0YSBnaXZl biB0byBjcnRjX2tpY2tvZmZfY2IKPiBAQCAtMTg2LDggKzE4OCw3IEBAIHN0cnVjdCBkcHVfZW5j b2Rlcl92aXJ0IHsKPiAKPiAgCWJvb2wgaW50ZnNfc3dhcHBlZDsKPiAKPiAtCXZvaWQgKCpjcnRj X3ZibGFua19jYikodm9pZCAqKTsKPiAtCXZvaWQgKmNydGNfdmJsYW5rX2NiX2RhdGE7Cj4gKwlz dHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4gCj4gIAlzdHJ1Y3QgZGVudHJ5ICpkZWJ1Z2ZzX3Jvb3Q7 Cj4gIAlzdHJ1Y3QgbXV0ZXggZW5jX2xvY2s7Cj4gQEAgLTEyNDEsOCArMTI0Miw4IEBAIHN0YXRp YyB2b2lkIGRwdV9lbmNvZGVyX3ZibGFua19jYWxsYmFjayhzdHJ1Y3QKPiBkcm1fZW5jb2RlciAq ZHJtX2VuYywKPiAgCWRwdV9lbmMgPSB0b19kcHVfZW5jb2Rlcl92aXJ0KGRybV9lbmMpOwo+IAo+ ICAJc3Bpbl9sb2NrX2lycXNhdmUoJmRwdV9lbmMtPmVuY19zcGlubG9jaywgbG9ja19mbGFncyk7 Cj4gLQlpZiAoZHB1X2VuYy0+Y3J0Y192YmxhbmtfY2IpCj4gLQkJZHB1X2VuYy0+Y3J0Y192Ymxh bmtfY2IoZHB1X2VuYy0+Y3J0Y192YmxhbmtfY2JfZGF0YSk7Cj4gKwlpZiAoZHB1X2VuYy0+Y3J0 YykKPiArCQlkcHVfY3J0Y192YmxhbmtfY2FsbGJhY2soZHB1X2VuYy0+Y3J0Yyk7Cj4gIAlzcGlu X3VubG9ja19pcnFyZXN0b3JlKCZkcHVfZW5jLT5lbmNfc3BpbmxvY2ssIGxvY2tfZmxhZ3MpOwo+ IAo+ICAJYXRvbWljX2luYygmcGh5X2VuYy0+dnN5bmNfY250KTsKPiBAQCAtMTI2MiwxNSArMTI2 MywxNCBAQCBzdGF0aWMgdm9pZCAKPiBkcHVfZW5jb2Rlcl91bmRlcnJ1bl9jYWxsYmFjayhzdHJ1 Y3QKPiBkcm1fZW5jb2RlciAqZHJtX2VuYywKPiAgCURQVV9BVFJBQ0VfRU5EKCJlbmNvZGVyX3Vu ZGVycnVuX2NhbGxiYWNrIik7Cj4gIH0KPiAKPiAtdm9pZCBkcHVfZW5jb2Rlcl9yZWdpc3Rlcl92 YmxhbmtfY2FsbGJhY2soc3RydWN0IGRybV9lbmNvZGVyICpkcm1fZW5jLAo+IC0JCXZvaWQgKCp2 YmxfY2IpKHZvaWQgKiksIHZvaWQgKnZibF9kYXRhKQo+ICt2b2lkIGRwdV9lbmNvZGVyX2Fzc2ln bl9jcnRjKHN0cnVjdCBkcm1fZW5jb2RlciAqZHJtX2VuYywgc3RydWN0IAo+IGRybV9jcnRjCj4g KmNydGMpCj4gIHsKPiAgCXN0cnVjdCBkcHVfZW5jb2Rlcl92aXJ0ICpkcHVfZW5jID0gdG9fZHB1 X2VuY29kZXJfdmlydChkcm1fZW5jKTsKPiAgCXVuc2lnbmVkIGxvbmcgbG9ja19mbGFnczsKPiAg CWJvb2wgZW5hYmxlOwo+ICAJaW50IGk7Cj4gCj4gLQllbmFibGUgPSB2YmxfY2IgPyB0cnVlIDog ZmFsc2U7Cj4gKwllbmFibGUgPSBjcnRjID8gdHJ1ZSA6IGZhbHNlOwo+IAo+ICAJaWYgKCFkcm1f ZW5jKSB7Cj4gIAkJRFBVX0VSUk9SKCJpbnZhbGlkIGVuY29kZXJcbiIpOwo+IEBAIC0xMjc5LDgg KzEyNzksOSBAQCB2b2lkIGRwdV9lbmNvZGVyX3JlZ2lzdGVyX3ZibGFua19jYWxsYmFjayhzdHJ1 Y3QKPiBkcm1fZW5jb2RlciAqZHJtX2VuYywKPiAgCXRyYWNlX2RwdV9lbmNfdmJsYW5rX2NiKERS TUlEKGRybV9lbmMpLCBlbmFibGUpOwo+IAo+ICAJc3Bpbl9sb2NrX2lycXNhdmUoJmRwdV9lbmMt PmVuY19zcGlubG9jaywgbG9ja19mbGFncyk7Cj4gLQlkcHVfZW5jLT5jcnRjX3ZibGFua19jYiA9 IHZibF9jYjsKPiAtCWRwdV9lbmMtPmNydGNfdmJsYW5rX2NiX2RhdGEgPSB2YmxfZGF0YTsKPiAr CS8qIGNydGMgc2hvdWxkIGFsd2F5cyBiZSBjbGVhcmVkIGJlZm9yZSByZS1hc3NpZ25pbmcgKi8K PiArCVdBUk5fT04oY3J0YyAmJiBkcHVfZW5jLT5jcnRjKTsKPiArCWRwdV9lbmMtPmNydGMgPSBj cnRjOwo+ICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZHB1X2VuYy0+ZW5jX3NwaW5sb2NrLCBs b2NrX2ZsYWdzKTsKPiAKPiAgCWZvciAoaSA9IDA7IGkgPCBkcHVfZW5jLT5udW1fcGh5c19lbmNz OyBpKyspIHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1 X2VuY29kZXIuaAo+IGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X2VuY29kZXIu aAo+IGluZGV4IGFhNGYxMzUyMThmYS4uYmUxZDgwODY3ODM0IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9lbmNvZGVyLmgKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfZW5jb2Rlci5oCj4gQEAgLTU1LDE0ICs1NSwxMiBAQCB2 b2lkIGRwdV9lbmNvZGVyX2dldF9od19yZXNvdXJjZXMoc3RydWN0IAo+IGRybV9lbmNvZGVyCj4g KmVuY29kZXIsCj4gIAkJCQkgIHN0cnVjdCBkcHVfZW5jb2Rlcl9od19yZXNvdXJjZXMKPiAqaHdf cmVzKTsKPiAKPiAgLyoqCj4gLSAqIGRwdV9lbmNvZGVyX3JlZ2lzdGVyX3ZibGFua19jYWxsYmFj ayAtIHByb3ZpZGUgY2FsbGJhY2sgdG8gZW5jb2Rlcgo+IHRoYXQKPiAtICoJd2lsbCBiZSBjYWxs ZWQgb24gdGhlIG5leHQgdmJsYW5rLgo+ICsgKiBkcHVfZW5jb2Rlcl9hc3NpZ25fY3J0YyAtIExp bmsgdGhlIGVuY29kZXIgdG8gdGhlIGNydGMgaXQncyAKPiBhc3NpZ25lZAo+IHRvCj4gICAqIEBl bmNvZGVyOgllbmNvZGVyIHBvaW50ZXIKPiAtICogQGNiOgkJY2FsbGJhY2sgcG9pbnRlciwgcHJv dmlkZSBOVUxMIHRvIGRlcmVnaXN0ZXIgYW5kCj4gZGlzYWJsZSBJUlFzCj4gLSAqIEBkYXRhOgl1 c2VyIGRhdGEgcHJvdmlkZWQgdG8gY2FsbGJhY2sKPiArICogQGNydGM6CWNydGMgcG9pbnRlcgo+ ICAgKi8KPiAtdm9pZCBkcHVfZW5jb2Rlcl9yZWdpc3Rlcl92YmxhbmtfY2FsbGJhY2soc3RydWN0 IGRybV9lbmNvZGVyICplbmNvZGVyLAo+IC0JCXZvaWQgKCpjYikodm9pZCAqKSwgdm9pZCAqZGF0 YSk7Cj4gK3ZvaWQgZHB1X2VuY29kZXJfYXNzaWduX2NydGMoc3RydWN0IGRybV9lbmNvZGVyICpl bmNvZGVyLAo+ICsJCQkgICAgIHN0cnVjdCBkcm1fY3J0YyAqY3J0Yyk7Cj4gCj4gIC8qKgo+ICAg KiBkcHVfZW5jb2Rlcl9yZWdpc3Rlcl9mcmFtZV9ldmVudF9jYWxsYmFjayAtIHByb3ZpZGUgY2Fs bGJhY2sgdG8KPiBlbmNvZGVyIHRoYXQKCi0tIApKZXlrdW1hciBTCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkZyZWVkcmVubyBtYWlsaW5nIGxpc3QKRnJl ZWRyZW5vQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ZyZWVkcmVubwo=