From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Johan Hovold <johan+linaro@kernel.org>,
Georgi Djakov <djakov@kernel.org>
Cc: "Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Artur Świgoń" <a.swigon@samsung.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, "Luca Weiss" <luca.weiss@fairphone.com>
Subject: Re: [PATCH 09/23] interconnect: qcom: rpmh: fix probe child-node error handling
Date: Fri, 3 Feb 2023 03:54:33 +0100 [thread overview]
Message-ID: <4969bf69-ca1f-a6e2-48cd-2cb27ee5a25e@linaro.org> (raw)
In-Reply-To: <20230201101559.15529-10-johan+linaro@kernel.org>
On 1.02.2023 11:15, Johan Hovold wrote:
> Make sure to clean up and release resources properly also in case probe
> fails when populating child devices.
>
> Fixes: 57eb14779dfd ("interconnect: qcom: icc-rpmh: Support child NoC device probe")
> Cc: stable@vger.kernel.org # 6.0
> Cc: Luca Weiss <luca.weiss@fairphone.com>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> drivers/interconnect/qcom/icc-rpmh.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/interconnect/qcom/icc-rpmh.c b/drivers/interconnect/qcom/icc-rpmh.c
> index fd17291c61eb..5168bbf3d92f 100644
> --- a/drivers/interconnect/qcom/icc-rpmh.c
> +++ b/drivers/interconnect/qcom/icc-rpmh.c
> @@ -235,8 +235,11 @@ int qcom_icc_rpmh_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, qp);
>
> /* Populate child NoC devices if any */
> - if (of_get_child_count(dev->of_node) > 0)
> - return of_platform_populate(dev->of_node, NULL, NULL, dev);
> + if (of_get_child_count(dev->of_node) > 0) {
> + ret = of_platform_populate(dev->of_node, NULL, NULL, dev);
> + if (ret)
> + goto err;
> + }
>
> return 0;
> err:
next prev parent reply other threads:[~2023-02-03 2:55 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 10:15 [PATCH 00/23] interconnect: fix racy provider registration Johan Hovold
2023-02-01 10:15 ` [PATCH 01/23] interconnect: fix mem leak when freeing nodes Johan Hovold
2023-02-01 11:18 ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 02/23] interconnect: fix icc_provider_del() error handling Johan Hovold
2023-02-01 11:16 ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 03/23] interconnect: fix provider registration API Johan Hovold
2023-02-03 2:48 ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 04/23] interconnect: imx: fix registration race Johan Hovold
2023-02-03 2:49 ` Konrad Dybcio
2023-02-03 16:01 ` Luca Ceresoli
2023-02-06 8:09 ` Johan Hovold
2023-02-06 20:52 ` Luca Ceresoli
2023-02-01 10:15 ` [PATCH 05/23] interconnect: qcom: osm-l3: " Johan Hovold
2023-02-03 2:51 ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 06/23] interconnect: qcom: rpm: fix probe child-node error handling Johan Hovold
2023-02-03 2:52 ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 07/23] interconnect: qcom: rpm: fix probe PM domain " Johan Hovold
2023-02-03 2:53 ` Konrad Dybcio
2023-03-11 18:17 ` Christophe JAILLET
2023-03-13 8:18 ` Johan Hovold
2023-02-01 10:15 ` [PATCH 08/23] interconnect: qcom: rpm: fix registration race Johan Hovold
2023-02-03 2:53 ` Konrad Dybcio
2023-02-03 4:06 ` Jun Nie
2023-02-01 10:15 ` [PATCH 09/23] interconnect: qcom: rpmh: fix probe child-node error handling Johan Hovold
2023-02-03 2:54 ` Konrad Dybcio [this message]
2023-02-01 10:15 ` [PATCH 10/23] interconnect: qcom: rpmh: fix registration race Johan Hovold
2023-02-03 2:55 ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 11/23] interconnect: qcom: msm8974: " Johan Hovold
2023-02-02 23:13 ` Brian Masney
2023-02-03 2:56 ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 12/23] interconnect: qcom: sm8450: " Johan Hovold
2023-02-03 2:56 ` Konrad Dybcio
2023-02-06 12:10 ` Vinod Koul
2023-02-01 10:15 ` [PATCH 13/23] interconnect: qcom: sm8550: " Johan Hovold
2023-02-01 10:20 ` Abel Vesa
2023-02-03 2:57 ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 14/23] interconnect: exynos: fix node leak in probe PM QoS error path Johan Hovold
2023-02-02 10:58 ` Krzysztof Kozlowski
2023-02-01 10:15 ` [PATCH 15/23] interconnect: exynos: fix registration race Johan Hovold
2023-02-02 11:04 ` Krzysztof Kozlowski
2023-02-02 12:17 ` Johan Hovold
2023-02-02 12:20 ` Krzysztof Kozlowski
2023-02-01 10:15 ` [PATCH 16/23] interconnect: exynos: drop redundant link destroy Johan Hovold
2023-02-02 11:09 ` Krzysztof Kozlowski
2023-02-01 10:15 ` [PATCH 17/23] memory: tegra: fix interconnect registration race Johan Hovold
2023-02-02 12:21 ` Krzysztof Kozlowski
2023-02-01 10:15 ` [PATCH 18/23] memory: tegra124-emc: " Johan Hovold
2023-02-02 12:21 ` Krzysztof Kozlowski
2023-02-01 10:15 ` [PATCH 19/23] memory: tegra20-emc: " Johan Hovold
2023-02-02 12:21 ` Krzysztof Kozlowski
2023-02-01 10:15 ` [PATCH 20/23] memory: tegra30-emc: " Johan Hovold
2023-02-02 12:21 ` Krzysztof Kozlowski
2023-02-01 10:15 ` [PATCH 21/23] interconnect: drop racy registration API Johan Hovold
2023-02-03 2:58 ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 22/23] interconnect: drop unused icc_get() interface Johan Hovold
2023-02-03 2:59 ` Konrad Dybcio
2023-02-01 10:15 ` [PATCH 23/23] interconnect: drop unused icc_link_destroy() interface Johan Hovold
2023-02-02 11:13 ` [PATCH 00/23] interconnect: fix racy provider registration Krzysztof Kozlowski
2023-02-02 12:20 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4969bf69-ca1f-a6e2-48cd-2cb27ee5a25e@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=a.swigon@samsung.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=djakov@kernel.org \
--cc=festevam@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=s.hauer@pengutronix.de \
--cc=s.nawrocki@samsung.com \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).