From: Krzysztof Kozlowski <krzk@kernel.org>
To: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Danila Tikhonov <danila@jiaxyga.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Vladimir Lypak <vladimir.lypak@gmail.com>,
Adam Skladowski <a39.skl@gmail.com>,
Sibi Sankar <quic_sibis@quicinc.com>,
Rohit Agarwal <quic_rohiagar@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
Andrew Halaney <ahalaney@redhat.com>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_mdtipton@quicinc.com, quic_okukatla@quicinc.com
Subject: Re: [PATCH 2/2] interconnect: qcom: add QCS8300 interconnect provider driver
Date: Tue, 27 Aug 2024 17:28:23 +0200 [thread overview]
Message-ID: <498fc1c9-9ade-4443-b64c-0d8fc9b7931b@kernel.org> (raw)
In-Reply-To: <20240827151622.305-3-quic_rlaggysh@quicinc.com>
On 27/08/2024 17:16, Raviteja Laggyshetty wrote:
> Add driver for the Qualcomm interconnect buses found in QCS8300
> based platforms. The topology consists of several NoCs that are
> controlled by a remote processor that collects the aggregated
> bandwidth for each master-slave pairs.
>
> +
> +static struct qcom_icc_node *nspa_noc_nodes[] = {
> + [MASTER_CDSP_NOC_CFG] = &qhm_nsp_noc_config,
> + [MASTER_CDSP_PROC] = &qxm_nsp,
> + [SLAVE_HCP_A] = &qns_hcp,
> + [SLAVE_CDSP_MEM_NOC] = &qns_nsp_gemnoc,
> + [SLAVE_SERVICE_NSP_NOC] = &service_nsp_noc,
> +};
> +
> +static struct qcom_icc_desc qcs8300_nspa_noc = {
Sorry, but no. Start from scratch from MAINLINE driver so you won't
repeat all the issues we fixed last years. Everything was fixed but then
you send one more driver with exact same issues. EXACT.
This applies to all QCS8300 submissions... actually this applies to all
contributions to Linux kernel. Don't send your downstream code.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-27 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 15:16 [PATCH 0/2] Add interconnect support for QCS8300 SoC Raviteja Laggyshetty
2024-08-27 15:16 ` [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm QCS8300 DT bindings Raviteja Laggyshetty
2024-08-27 15:32 ` Krzysztof Kozlowski
2024-09-04 4:15 ` Raviteja Laggyshetty
2024-08-27 15:16 ` [PATCH 2/2] interconnect: qcom: add QCS8300 interconnect provider driver Raviteja Laggyshetty
2024-08-27 15:28 ` Krzysztof Kozlowski [this message]
2024-09-04 4:21 ` Raviteja Laggyshetty
2024-08-29 19:49 ` Konrad Dybcio
2024-09-04 4:23 ` Raviteja Laggyshetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498fc1c9-9ade-4443-b64c-0d8fc9b7931b@kernel.org \
--to=krzk@kernel.org \
--cc=a39.skl@gmail.com \
--cc=ahalaney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=danila@jiaxyga.com \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_okukatla@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_rlaggysh@quicinc.com \
--cc=quic_rohiagar@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh@kernel.org \
--cc=vladimir.lypak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox