From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:44202 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754938Ab0GLIz3 (ORCPT ); Mon, 12 Jul 2010 04:55:29 -0400 Message-ID: <4C3AD87C.1010407@codeaurora.org> Date: Mon, 12 Jul 2010 14:25:24 +0530 From: Trilok Soni MIME-Version: 1.0 Subject: Re: [PATCH v2] gpio: sx150x: Add Semtech I2C sx150x gpio expander driver. References: <1278617834-14970-1-git-send-email-gbean@codeaurora.org> <4C370EB4.4040906@codeaurora.org> In-Reply-To: <4C370EB4.4040906@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Gregory Bean Cc: akpm@linux-foundation.org, khali@linux-fr.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org Hi Jean, Andrew, On 7/9/2010 5:27 PM, Trilok Soni wrote: > On 7/9/2010 1:07 AM, Gregory Bean wrote: >> Add support for Semtech SX150-series I2C GPIO expanders. >> Compatible models include: >> >> 8 bits: sx1508q >> 16 bits: sx1509q >> >> Signed-off-by: Gregory Bean >> --- >> drivers/gpio/Kconfig | 11 + >> drivers/gpio/Makefile | 1 + >> drivers/gpio/sx150x.c | 646 ++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/i2c/sx150x.h | 78 ++++++ >> 4 files changed, 736 insertions(+), 0 deletions(-) >> create mode 100644 drivers/gpio/sx150x.c >> create mode 100644 include/linux/i2c/sx150x.h >> > > Looks good to me. > > Reviewed-by: Trilok Soni > Any review comments on this new version of the driver? -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.