From: Michael Bohan <mbohan@codeaurora.org>
To: "David Lanzendörfer" <david.lanzendoerfer@o2s.ch>
Cc: linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] Adding usb gadget support
Date: Fri, 16 Jul 2010 10:14:07 -0700 [thread overview]
Message-ID: <4C40935F.1010400@codeaurora.org> (raw)
In-Reply-To: <201007160933.10288.david.lanzendoerfer@o2s.ch>
On 7/16/2010 12:33 AM, David Lanzendörfer wrote:
> Also here we are using phy_reset
> https://www.codeaurora.org/gitweb/quic/la/?p=kernel/msm.git;a=blob;f=drivers/usb/gadget/msm72k_udc.c;h=f3669507bcd929b043e573d08e600171cc0c87de;hb=refs/heads/aosp/android-msm-2.6.32
>
> Its needed for cable plug/unplug event recognition as it looks like.
> So we realy seem to need phy_reset.
> In the android branch phy_reset() was declared inside a second devices.c file called
> devices_htc.c
> I considered it a bit confusing, and I'm not sure, where to actually introduce it now.
> Could QuIC take a look please?
Look at the file you mentioned for an example of how to connect the phy
reset function:
https://www.codeaurora.org/gitweb/quic/la/?p=kernel/msm.git;a=blob;f=arch/arm/mach-msm/devices_htc.c;h=e5f65e720656db1e0349e2d981e50f514eac8f2f;hb=refs/heads/aosp/android-msm-2.6.32
You just need to:
1. Make an instance of the msm_hsusb_platform_data.
2. Assign the 'phy_reset' pointer to your added function.
3. Assign that msm_device_hsusb platform_data to your pdata struct.
4. Register the platform device.
Michael
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
next prev parent reply other threads:[~2010-07-16 17:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 7:33 [PATCH] Adding usb gadget support David Lanzendörfer
2010-07-16 17:14 ` Michael Bohan [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-07-16 7:33 David Lanzendörfer
2010-07-15 17:31 David Lanzendörfer
2010-07-15 17:49 ` Michael Bohan
2010-07-15 19:05 ` David Lanzendörfer
2010-07-15 21:46 ` David Lanzendörfer
2010-07-15 22:34 ` Michael Bohan
2010-07-15 23:08 ` Tim HRM
2010-07-16 6:07 ` Pavan Kondeti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C40935F.1010400@codeaurora.org \
--to=mbohan@codeaurora.org \
--cc=david.lanzendoerfer@o2s.ch \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).