From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:19869 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752978Ab0GPROJ (ORCPT ); Fri, 16 Jul 2010 13:14:09 -0400 Message-ID: <4C40935F.1010400@codeaurora.org> Date: Fri, 16 Jul 2010 10:14:07 -0700 From: Michael Bohan MIME-Version: 1.0 Subject: Re: [PATCH] Adding usb gadget support References: <201007160933.10288.david.lanzendoerfer@o2s.ch> In-Reply-To: <201007160933.10288.david.lanzendoerfer@o2s.ch> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: =?ISO-8859-1?Q?David_Lanzend=F6rfer?= Cc: linux-arm-msm@vger.kernel.org On 7/16/2010 12:33 AM, David Lanzendörfer wrote: > Also here we are using phy_reset > https://www.codeaurora.org/gitweb/quic/la/?p=kernel/msm.git;a=blob;f=drivers/usb/gadget/msm72k_udc.c;h=f3669507bcd929b043e573d08e600171cc0c87de;hb=refs/heads/aosp/android-msm-2.6.32 > > Its needed for cable plug/unplug event recognition as it looks like. > So we realy seem to need phy_reset. > In the android branch phy_reset() was declared inside a second devices.c file called > devices_htc.c > I considered it a bit confusing, and I'm not sure, where to actually introduce it now. > Could QuIC take a look please? Look at the file you mentioned for an example of how to connect the phy reset function: https://www.codeaurora.org/gitweb/quic/la/?p=kernel/msm.git;a=blob;f=arch/arm/mach-msm/devices_htc.c;h=e5f65e720656db1e0349e2d981e50f514eac8f2f;hb=refs/heads/aosp/android-msm-2.6.32 You just need to: 1. Make an instance of the msm_hsusb_platform_data. 2. Assign the 'phy_reset' pointer to your added function. 3. Assign that msm_device_hsusb platform_data to your pdata struct. 4. Register the platform device. Michael -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum